Issue 1508573 in chromium: Flag expired : encrypted-client-hello is expired in M122

[chrome-branch-day via monorail]

Comment #1 on issue 1508573 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : encrypted-client-hello is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508573#c1

This flag has been marked as expiring in M122 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M122 branch you're all set; if you do it after the M122 branch you'll need to merge that CL to the M122 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[dtapuska via monorail]

Updates:
Components: Internals>Network

Comment #2 on issue 1508573 by dtap...@chromium.org: Flag expired : encrypted-client-hello is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508573#c2

(No comment was entered for this change.)

[mmenke via monorail]

Updates:
Components: -Internals>Network Internals>Network>SSL

Comment #3 on issue 1508573 by mme...@chromium.org: Flag expired : encrypted-client-hello is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508573#c3

[Git Watcher via monorail]

Updates:
Status: Fixed

Comment #4 on issue 1508573 by Git Watcher: Flag expired : encrypted-client-hello is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508573#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/1808fed970405f67b0866340be1f76a12525abb7

commit 1808fed970405f67b0866340be1f76a12525abb7
Author: David Benjamin <davi...@chromium.org>
Date: Thu Dec 14 16:35:42 2023

Post-launch ECH cleanup

We no longer need the (already enabled by default) base::Feature and
about:flags entry. (This does not impact the admin policy.)

Fixed: 1508573
Bug: 1091403
Change-Id: I8820adb4d9e14de5546f1d63e0f623a7d26dcb95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5100554
Reviewed-by: Matt Mueller <ma...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Commit-Queue: David Benjamin <davi...@chromium.org>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Reviewed-by: Julian Pastarmov <pasta...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1237552}

[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/socket/ssl_connect_job_unittest.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/base/features.h
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/quic/quic_chromium_client_session.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/chrome/browser/about_flags.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/socket/ssl_connect_job.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/socket/transport_connect_job_unittest.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/http/http_stream_factory_job_controller_unittest.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/chrome/browser/flag-metadata.json
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/base/features.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/socket/transport_connect_job.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/quic/quic_stream_factory_test.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/ssl/ssl_config_service.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/quic/quic_stream_factory.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/ssl/ssl_config_service.h
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/net/url_request/http_with_dns_over_https_unittest.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/1808fed970405f67b0866340be1f76a12525abb7/chrome/browser/policy/policy_network_browsertest.cc