Issue 1499374 in chromium: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13

[histogram-eraser via monorail]

Status: Untriaged
Owner: ----
CC: davi...@chromium.org, trusty-t...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Pri: 3
Type: Task

New issue 1499374 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Net.HttpJob.TotalTime.TLS13 (expired as of 2022-06-19)
- Net.HttpTimeToFirstByte.TLS13 (expired as of 2022-05-11)

The following code locations were found:

net/url_request/url_request_http_job.cc:1658:
base::UmaHistogramMediumTimes("Net.HttpTimeToFirstByte.TLS13", to_start);
net/url_request/url_request_http_job.cc:1660:
base::UmaHistogramMediumTimes("Net.HttpTimeToFirstByte.TLS13.Google",
net/url_request/url_request_http_job.cc:1739:
base::UmaHistogramTimes("Net.HttpJob.TotalTime.TLS13", total_time);
net/url_request/url_request_http_job.cc:1741:
base::UmaHistogramTimes("Net.HttpJob.TotalTime.TLS13.Google",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- If the histogram should be removed:
- Recommended: Mark the bug as Available and add the label Proj-CodeHealthRotation-Bug.
- Or, assign to yourself if you'd prefer to do the clean up yourself.
- Otherwise, annotate the histograms as intentionally expired (see above) and update the bug.
- If you believe the bug was filed in error, cc:asvi...@chromium.org and mention the problem.

Available bugs with the label Proj-CodeHealthRotation-Bug will be eligible for cleanup by participants in the code health rotation.

If the bug is left in the Untriaged state without any activity by histogram owner(s), we will consider that the histogram is not needed and it will be considered for removal.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[chikamune via monorail]

Updates:
Owner: chik...@chromium.org

Comment #1 on issue 1499374 by chik...@google.com: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374#c1

(No comment was entered for this change.)

[chikamune via monorail]

Comment #2 on issue 1499374 by chik...@google.com: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374#c2

Net.HttpJob.TotalTime.TLS13.Google will expire after 2024-03-17, and Net.HttpJob.TotalTime.TLS13 already expired.
davidben@, do you want to extend the expiration date for Net.HttpJob.TotalTime.TLS13?

[chikamune via monorail]

Comment #3 on issue 1499374 by chik...@google.com: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374#c3

Same thing applies to Net.HttpTimeToFirstByte.TLS13 and Net.HttpTimeToFirstByte.TLS13.Google.
I want to confirm if I can really remove Net.HttpTimeToFirstByte.TLS13 as a part of the code health rotation.

[chikamune via monorail]

Updates:
Owner: ----

Comment #4 on issue 1499374 by chik...@chromium.org: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374#c4

(No comment was entered for this change.)

[christinesm via monorail]

Updates:
Owner: chris...@chromium.org
Status: Started

Comment #5 on issue 1499374 by chris...@chromium.org: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374#c5

picking up for code health rotation - will attempt to remove since there hasn't been feedback since the last person on rotation took a look at this bug

[Git Watcher via monorail]

Comment #6 on issue 1499374 by Git Watcher: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374#c6

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/cad30d023f794858c161d246abefb02177ca83cb

commit cad30d023f794858c161d246abefb02177ca83cb
Author: Christine Smith <chris...@chromium.org>
Date: Mon Dec 04 15:10:28 2023

[Code Health] Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13

Removes two expired Net.* histograms. Per the code health rotation
instructions, an obsoletion message is not required for removing these
histograms.

Bug: 1499374
Change-Id: I1827acaf83f0e168d68906fa20b618fc645ca94a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5076741
Reviewed-by: Charlie Harrison <cshar...@chromium.org>
Commit-Queue: Christine Smith <chris...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1232709}

[modify] https://crrev.com/cad30d023f794858c161d246abefb02177ca83cb/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/cad30d023f794858c161d246abefb02177ca83cb/tools/metrics/histograms/metadata/net/histograms.xml

[christinesm via monorail]

Updates:
Status: Fixed

Comment #7 on issue 1499374 by chris...@chromium.org: Remove expired histograms Net.HttpJob.TotalTime.TLS13, Net.HttpTimeToFirstByte.TLS13
https://bugs.chromium.org/p/chromium/issues/detail?id=1499374#c7

(No comment was entered for this change.)