Issue 1490245 in chromium: Flag expired : use-sha1-server-handshakes is expired in M120

[chrome-branch-day via monorail]

Comment #1 on issue 1490245 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : use-sha1-server-handshakes is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490245#c1

This flag has been marked as expiring in M120 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M120 branch you're all set; if you do it after the M120 branch you'll need to merge that CL to the M120 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[chrome-branch-day via monorail]

Comment #2 on issue 1490245 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : use-sha1-server-handshakes is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490245#c2

This flag has been marked as expiring in M121 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.

- If you do this before the M121 branch you're all set; if you do it after the M121 branch you'll need to merge that CL to the M121 branch as well.

[davidben via monorail]

Updates:
Components: Internals>Network>SSL
Owner: b...@chromium.org
Status: Assigned

Comment #3 on issue 1490245 by davi...@chromium.org: Flag expired : use-sha1-server-handshakes is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490245#c3

Assigning to bbe, as part of post-SHA1-launch cleanup.

[chrome-branch-day via monorail]

Comment #4 on issue 1490245 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : use-sha1-server-handshakes is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490245#c4

This flag has been marked as expiring in M122 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.

- If you do this before the M122 branch you're all set; if you do it after the M122 branch you'll need to merge that CL to the M122 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

[Git Watcher via monorail]

Comment #5 on issue 1490245 by Git Watcher: Flag expired : use-sha1-server-handshakes is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490245#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/8ca38a3aac259e23b4603dee57cc9d4b9b672298

commit 8ca38a3aac259e23b4603dee57cc9d4b9b672298
Author: Bob Beck <b...@google.com>
Date: Thu Dec 07 00:14:45 2023

Remove expired use-sha1-server-handshakes flag

Bug: 1490245
Change-Id: I069ca5e487eef17e5aba8c64d297d435418f99e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5096474
Commit-Queue: Bob Beck <b...@chromium.org>
Reviewed-by: David Benjamin <davi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234250}

[modify] https://crrev.com/8ca38a3aac259e23b4603dee57cc9d4b9b672298/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/8ca38a3aac259e23b4603dee57cc9d4b9b672298/chrome/browser/about_flags.cc
[modify] https://crrev.com/8ca38a3aac259e23b4603dee57cc9d4b9b672298/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/8ca38a3aac259e23b4603dee57cc9d4b9b672298/chrome/browser/flag-metadata.json

[Git Watcher via monorail]

Comment #6 on issue 1490245 by Git Watcher: Flag expired : use-sha1-server-handshakes is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1490245#c6

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/9bbe4b38f31a2a85b368f1a712cf1469040f336f

commit 9bbe4b38f31a2a85b368f1a712cf1469040f336f
Author: Bob Beck <b...@google.com>
Date: Mon Dec 11 17:54:06 2023

Remove base::feature::kSHA1ServerSignature

We retain the InsecureHashesEnabled enterprise option until 123

Bug: 1490245
Change-Id: I098350731fdba1add7d80c121fa1dc28044aef0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5106440
Reviewed-by: Tommy Nyquist <nyq...@chromium.org>

Commit-Queue: Bob Beck <b...@chromium.org>
Reviewed-by: David Benjamin <davi...@chromium.org>

Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1235809}

[modify] https://crrev.com/9bbe4b38f31a2a85b368f1a712cf1469040f336f/net/socket/ssl_connect_job_unittest.cc
[modify] https://crrev.com/9bbe4b38f31a2a85b368f1a712cf1469040f336f/net/base/features.h
[modify] https://crrev.com/9bbe4b38f31a2a85b368f1a712cf1469040f336f/net/ssl/ssl_config_service.cc
[modify] https://crrev.com/9bbe4b38f31a2a85b368f1a712cf1469040f336f/net/base/features.cc
[modify] https://crrev.com/9bbe4b38f31a2a85b368f1a712cf1469040f336f/chrome/browser/policy/policy_network_browsertest.cc