Kalvin Lee (Gerrit)

unread,

Jul 1, 2026, 5:09:28 AM (2 days ago) Jul 1

to Eric Seckler, devtools...@chromium.org, chromium...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, headless...@chromium.org, tracing...@chromium.org

Attention needed from Eric Seckler

Kalvin Lee has uploaded the change for review

Kalvin Lee would like Eric Seckler to review this change.

Commit message

IWYU: `base::span`

This change was generated (and formatted) mostly automatically.
For specific asks, leave a comment to elicit a fleshy response.

This particular CL is scoped to
['base/trace_event', 'components/headless', 'headless', 'services/tracing']

This CL was uploaded by git cl split.

R=esec...@chromium.org

Bug: 529948677

Change-Id: I22070c647b588d44a0e9f8b0c9d3b19ee29b6678

Change diff

Change information

Files:

M base/trace_event/memory_allocator_dump_guid.cc
M base/trace_event/memory_infra_background_allowlist.cc
M base/trace_event/process_memory_dump_unittest.cc
M base/trace_event/trace_logging_minimal_win.cc
M components/headless/test/pdf_utils.cc
M headless/lib/browser/headless_devtools_manager_delegate.cc
M headless/lib/browser/headless_devtools_manager_delegate.h
M headless/lib/browser/protocol/headless_devtools_session.cc
M headless/lib/browser/protocol/headless_devtools_session.h
M headless/test/headless_printtopdf_browsertest.cc
M services/tracing/public/cpp/background_tracing/background_tracing_manager.cc
M services/tracing/public/cpp/background_tracing/trace_upload_list.h
M services/tracing/public/cpp/perfetto/perfetto_tracing_backend.cc
M services/tracing/public/cpp/perfetto/producer_test_utils.cc
M services/tracing/public/cpp/perfetto/trace_packet_tokenizer.cc
M services/tracing/public/cpp/trace_startup.cc
M services/tracing/public/cpp/trace_startup_config.cc

Change size: S

Delta: 17 files changed, 17 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Eric Seckler

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eric Seckler (Gerrit)

unread,

Jul 1, 2026, 7:11:16 AM (2 days ago) Jul 1

to Kalvin Lee, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Kalvin Lee

Eric Seckler voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Kalvin Lee

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 1, 2026, 8:17:49 AM (2 days ago) Jul 1

to Kalvin Lee, Eric Seckler, chromium...@chromium.org, devtools...@chromium.org, headless...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

IWYU: `base::span`

This change was generated (and formatted) mostly automatically.
For specific asks, leave a comment to elicit a fleshy response.

This particular CL is scoped to
['base/trace_event', 'components/headless', 'headless', 'services/tracing']

This CL was uploaded by git cl split.

R=esec...@chromium.org

Bug: 529948677

Change-Id: I22070c647b588d44a0e9f8b0c9d3b19ee29b6678

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8030381

Commit-Queue: Eric Seckler <esec...@chromium.org>

Auto-Submit: Kalvin Lee <kd...@chromium.org>

Reviewed-by: Eric Seckler <esec...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1655426}

Files:

M base/trace_event/memory_allocator_dump_guid.cc
M base/trace_event/memory_infra_background_allowlist.cc
M base/trace_event/process_memory_dump_unittest.cc
M base/trace_event/trace_logging_minimal_win.cc
M components/headless/test/pdf_utils.cc
M headless/lib/browser/headless_devtools_manager_delegate.cc
M headless/lib/browser/headless_devtools_manager_delegate.h
M headless/lib/browser/protocol/headless_devtools_session.cc
M headless/lib/browser/protocol/headless_devtools_session.h
M headless/test/headless_printtopdf_browsertest.cc
M services/tracing/public/cpp/background_tracing/background_tracing_manager.cc
M services/tracing/public/cpp/background_tracing/trace_upload_list.h
M services/tracing/public/cpp/perfetto/perfetto_tracing_backend.cc
M services/tracing/public/cpp/perfetto/producer_test_utils.cc
M services/tracing/public/cpp/perfetto/trace_packet_tokenizer.cc
M services/tracing/public/cpp/trace_startup.cc
M services/tracing/public/cpp/trace_startup_config.cc

Change size: S

Delta: 17 files changed, 17 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Eric Seckler

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

IWYU: `base::span` [chromium/src : main]

Kalvin Lee (Gerrit)

Kalvin Lee has uploaded the change for review

Commit message

Change diff

Change information

Related details

Eric Seckler (Gerrit)

Eric Seckler voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information