services: Migrate BASE_FEATURE macros to 2-argument version [chromium/src : main]

1 view

Skip to first unread message

Xiaohan Wang (Gerrit)

unread,

Aug 19, 2025, 7:23:58 PMAug 19

to Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, ningxin hu, Jiewei Qian, Rijubrata Bhaumik, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, marinacio...@chromium.org, mattreyno...@chromium.org, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Xiaohan Wang added 1 comment

File services/tracing/public/cpp/tracing_features.cc

Line 40, Patchset 1 (Latest):

BASE_FEATURE(
    EnablePerfettoSystemTracing,

Xiaohan Wang . resolved

FWIW, `git cl upload` doesn't complain about this. Though after manual edit it doesn't complain about the alternative either.

This will trigger an error since it's a "not supported" case:

https://source.chromium.org/chromium/chromium/src/+/main:build/android/gyp/java_cpp_features_tests.py;drc=20495680e85bc851e9bb13e5008b063f541d45a3;l=182

I'll try to fix build/android/gyp/java_cpp_features.py in a different CL.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Xiaohan Wang (Gerrit)

unread,

Aug 26, 2025, 6:02:20 AMAug 26

Xiaohan Wang abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages