[BRP] Remove #constexpr-* exclusions (and modernize comments) [chromium/src : main]

0 views
Skip to first unread message

Bartek Nowierski (Gerrit)

unread,
Jun 18, 2024, 10:01:12 AM (13 days ago) Jun 18
to Keishi Hattori, Łukasz Anforowicz, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nikhil Nayunigari, andrewxu+wat...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, chadduffin+w...@chromium.org, chromiumme...@microsoft.com, dmblack+watc...@google.com, druber...@chromium.org, ejcaruso+wa...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, gavin...@chromium.org, gordonseto+w...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, multipaste-...@google.com, net-r...@chromium.org, network-ser...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tjohnsonkanu+...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Keishi Hattori

Bartek Nowierski voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6b8002e424dc4d6b3952567382eb81b926e55244
Gerrit-Change-Number: 5632968
Gerrit-PatchSet: 1
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Jun 2024 14:00:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keishi Hattori (Gerrit)

unread,
Jun 23, 2024, 4:05:00 PM (8 days ago) Jun 23
to Bartek Nowierski, Łukasz Anforowicz, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, Nikhil Nayunigari, andrewxu+wat...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, chadduffin+w...@chromium.org, chromiumme...@microsoft.com, dmblack+watc...@google.com, druber...@chromium.org, ejcaruso+wa...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, gavin...@chromium.org, gordonseto+w...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, multipaste-...@google.com, net-r...@chromium.org, network-ser...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tjohnsonkanu+...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Bartek Nowierski

Keishi Hattori voted and added 1 comment

Votes added by Keishi Hattori

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Keishi Hattori . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Bartek Nowierski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6b8002e424dc4d6b3952567382eb81b926e55244
Gerrit-Change-Number: 5632968
Gerrit-PatchSet: 3
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Łukasz Anforowicz <luk...@chromium.org>
Gerrit-Attention: Bartek Nowierski <bar...@chromium.org>
Gerrit-Comment-Date: Sun, 23 Jun 2024 20:04:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 23, 2024, 5:34:32 PM (8 days ago) Jun 23
to Bartek Nowierski, Keishi Hattori, Łukasz Anforowicz, chromium...@chromium.org, Daniel Cheng, Nikhil Nayunigari, andrewxu+wat...@google.com, andysjl...@chromium.org, asvitki...@chromium.org, blundell+...@chromium.org, chadduffin+w...@chromium.org, chromiumme...@microsoft.com, dmblack+watc...@google.com, druber...@chromium.org, ejcaruso+wa...@chromium.org, feature-me...@chromium.org, fuzzin...@chromium.org, gavin...@chromium.org, gordonseto+w...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, jonmann+wa...@chromium.org, khorimoto+w...@chromium.org, multipaste-...@google.com, net-r...@chromium.org, network-ser...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tjohnsonkanu+...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[BRP] Remove #constexpr-* exclusions (and modernize comments)

No rewrites were necessary. In vast majority of cases there was another exclusion reason barring from making a rewrite. In the 2 cases where no other reason was listed, turns out the embedding struct is STACK_ALLOCATED, so we don't rewrite such pointers.
Bug: 346694917
Change-Id: I6b8002e424dc4d6b3952567382eb81b926e55244
Reviewed-by: Keishi Hattori <kei...@chromium.org>
Commit-Queue: Keishi Hattori <kei...@chromium.org>
Auto-Submit: Bartek Nowierski <bar...@chromium.org>
Owners-Override: Keishi Hattori <kei...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318385}
Files:
  • M base/metrics/field_trial_params.h
  • M chrome/browser/ui/ash/clipboard_history_browsertest.cc
  • M chromeos/components/onc/onc_utils_unittest.cc
  • M components/flags_ui/feature_entry.h
  • M components/safe_browsing/core/common/features.cc
  • M components/segmentation_platform/internal/metadata/metadata_writer.h
  • M components/supervised_user/core/browser/supervised_user_error_page_unittest.cc
  • M content/browser/media/session/media_session_impl.h
  • M content/browser/shape_detection/shape_detection_browsertest.cc
  • M ipc/ipc_channel_proxy_unittest.cc
  • M net/disk_cache/disk_cache_fuzzer.cc
  • M services/network/trust_tokens/scoped_boringssl_bytes.h
  • M services/tracing/perfetto/privacy_filtered_fields-inl.h
  • M ui/base/interaction/element_identifier.h
  • M ui/gfx/animation/keyframe/animation_curve.h
  • M ui/gfx/native_widget_types.h
  • M ui/gfx/vector_icon_types.h
  • M ui/gl/android/scoped_a_native_window.h
Change size: M
Delta: 18 files changed, 33 insertions(+), 60 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keishi Hattori
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6b8002e424dc4d6b3952567382eb81b926e55244
Gerrit-Change-Number: 5632968
Gerrit-PatchSet: 4
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages