Emit Android Choreographer data only when `viz` is enabled [chromium/src : main]

0 views

Skip to first unread message

Kartar Singh (Gerrit)

unread,

11:28 AM (8 hours ago) 11:28 AM

to AyeAye, Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, cc-...@chromium.org

Kartar Singh added 1 comment

File components/viz/service/frame_sinks/external_begin_frame_source_android.cc

Line 186, Patchset 2:

  bool emit_choreographer_data_in_trace_event = false;
  TRACE_EVENT_CATEGORY_GROUP_ENABLED("viz",
                                     &emit_choreographer_data_in_trace_event);

Petr Cermak . resolved

Is there a reason why this has to happen before `TRACE_EVENT_END`?

Kartar Singh

No, just moved it close to emission.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages