Improve Memory.DumpProvider.* histograms [chromium/src : main]

0 views
Skip to first unread message

Joe Mason (Gerrit)

unread,
Jan 8, 2026, 3:31:00 PM (3 days ago) Jan 8
to Etienne Pierre-Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Joe Mason voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia8bf8b2f813096dc8ef4ff42e094e7515d9ddadb
Gerrit-Change-Number: 7412858
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 20:30:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jan 9, 2026, 2:22:57 PM (3 days ago) Jan 9
to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia8bf8b2f813096dc8ef4ff42e094e7515d9ddadb
Gerrit-Change-Number: 7412858
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 19:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 9, 2026, 2:26:21 PM (3 days ago) Jan 9
to Etienne Pierre-Doray, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Improve Memory.DumpProvider.* histograms

Adds an unsuffixed variant of each Memory.DumpProvider.* histogram,
aggregating all providers names.

Rebuckets Memory.DumpProvider.FollowingProviders (renaming it to
FollowingProviders2) since many samples were in the overflow bucket.

OBSOLETE_HISTOGRAMS=Patterned histogram
Memory.DumpProvider.FollowingProviders.{Name} is replaced by
Memory.DumpProvider.FollowingProviders2.{Name}
Bug: 450929521
Change-Id: Ia8bf8b2f813096dc8ef4ff42e094e7515d9ddadb
Auto-Submit: Joe Mason <joenot...@google.com>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567089}
Files:
  • M base/trace_event/measured_memory_dump_provider_info.cc
  • M tools/metrics/histograms/metadata/memory/histograms.xml
Change size: M
Delta: 2 files changed, 99 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia8bf8b2f813096dc8ef4ff42e094e7515d9ddadb
Gerrit-Change-Number: 7412858
Gerrit-PatchSet: 3
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages