Sayed Elabady (Gerrit)

unread,

Feb 13, 2026, 12:40:58 PMFeb 13

to Alexei Svitkine, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Alexei Svitkine

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sayed Elabady (Gerrit)

unread,

Feb 13, 2026, 12:50:32 PMFeb 13

to Alexei Svitkine, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Alexei Svitkine

Sayed Elabady added 1 comment

File android_webview/java/src/org/chromium/android_webview/SystemStateUtil.java

Line 77, Patchset 5 (Latest): public static String getProcessName() {

Sayed Elabady . resolved

I've added it here because `SystemStateUtil` already contains static methods for system state queries, making it seem like a reasonable and simple place for this functionality.

I considered creating a new dedicated utility class, but that felt like overkill for a single method. However, I'm open to moving it to a more appropriate location if you think it should be moved.

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Feb 13, 2026, 3:38:03 PMFeb 13

to Sayed Elabady, Peter Beverloo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Peter Beverloo and Sayed Elabady

Alexei Svitkine added 4 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Alexei Svitkine . resolved

+beverloo to review from the AW side

Commit Message

Line 22, Patchset 5 (Latest):Bug: 466315206

Alexei Svitkine . unresolved

Use: b:466315206 syntax since it's an internal bug.

File android_webview/browser/metrics/system_state_util.h

Line 59, Patchset 5 (Latest):AgsaProcessName GetAgsaProcessNameEnum(const std::string& process_name);

Alexei Svitkine . unresolved

Add a comment.

Pass param by string_view.

Line 57, Patchset 5 (Latest):std::string GetProcessName();

Alexei Svitkine . unresolved

Add a comment.

Maybe explain where this is coming from.

Open in Gerrit

Related details

Attention is currently required from:

Peter Beverloo
Sayed Elabady

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Feb 13, 2026, 3:40:10 PMFeb 13

to Sayed Elabady, Peter Beverloo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Peter Beverloo and Sayed Elabady

Alexei Svitkine added 1 comment

File android_webview/browser/metrics/android_metrics_provider.cc

Line 35, Patchset 5 (Latest): "com.google.android.googlequicksearchbox") {

Alexei Svitkine . unresolved

It seems a bit weird to have this logic here, while GetAgsaProcessNameEnum() is implemented elsewhere.

I think it would make sense for both of them to be implemented together.

Perhaps the API should be GetAgsaProcessNameEnum() without a param, which would return an empty string if the package name is not AGSA.

For testing, you can have an GetAgsaProcessNameEnumImpl() in an "internal" namespace that still takes the param.

satisfied_requirement

unsatisfied_requirement

open

diffy

Sayed Elabady (Gerrit)

unread,

Feb 16, 2026, 7:08:09 AM (12 days ago) Feb 16

to Peter Beverloo, Alexei Svitkine, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Alexei Svitkine and Peter Beverloo

Sayed Elabady voted and added 4 comments

Votes added by Sayed Elabady

Commit-Queue

+1

4 comments

Commit Message

Line 22, Patchset 5:Bug: 466315206

Alexei Svitkine . resolved

Use: b:466315206 syntax since it's an internal bug.

Sayed Elabady

Done

File android_webview/browser/metrics/android_metrics_provider.cc

Line 35, Patchset 5: "com.google.android.googlequicksearchbox") {

Alexei Svitkine . resolved

It seems a bit weird to have this logic here, while GetAgsaProcessNameEnum() is implemented elsewhere.
I think it would make sense for both of them to be implemented together.
Perhaps the API should be GetAgsaProcessNameEnum() without a param, which would return an empty string if the package name is not AGSA.
For testing, you can have an GetAgsaProcessNameEnumImpl() in an "internal" namespace that still takes the param.

Sayed Elabady

Done

File android_webview/browser/metrics/system_state_util.h

Line 59, Patchset 5:AgsaProcessName GetAgsaProcessNameEnum(const std::string& process_name);

Alexei Svitkine . resolved

Add a comment.
Pass param by string_view.

Sayed Elabady

Done

Line 57, Patchset 5:std::string GetProcessName();

Alexei Svitkine . resolved

Add a comment.
Maybe explain where this is coming from.

Sayed Elabady

Done

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Peter Beverloo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Peter Beverloo (Gerrit)

unread,

Feb 16, 2026, 8:53:02 AM (12 days ago) Feb 16

to Sayed Elabady, Peter Beverloo, Alexei Svitkine, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Alexei Svitkine and Sayed Elabady

Peter Beverloo added 3 comments

File android_webview/browser/metrics/android_metrics_provider_unittest.cc

Line 62, Patchset 9 (Latest): histogram_tester_.ExpectTotalCount("Android.WebView.PrimaryCpuAbiBitness", 1);

Peter Beverloo . unresolved

nit: add this line to keep the listed histograms in these three tests in sync:

```
  histogram_tester_.ExpectTotalCount("Android.WebView.AgsaProcessName", 0);
```

File android_webview/browser/metrics/system_state_util.h

Line 45, Patchset 9 (Latest): kUnknown = 0,

Peter Beverloo . unresolved

When do we emit `kUnknown`? Since we don't emit this histogram at all in the non-AGA case, can we merge `kOther` into it?

File android_webview/browser/metrics/system_state_util.cc

Line 48, Patchset 9 (Latest):AgsaProcessName GetAgsaProcessNameEnumImpl(std::string_view process_name) {

Peter Beverloo . unresolved

Do we need all of these? If the list is currently exhaustive, what's the plan for keeping it up-to-date?

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Sayed Elabady

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sayed Elabady (Gerrit)

unread,

Feb 16, 2026, 9:56:28 AM (12 days ago) Feb 16

to Peter Beverloo, Alexei Svitkine, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Alexei Svitkine and Peter Beverloo

Sayed Elabady added 3 comments

File android_webview/browser/metrics/android_metrics_provider_unittest.cc

Line 62, Patchset 9: histogram_tester_.ExpectTotalCount("Android.WebView.PrimaryCpuAbiBitness", 1);

Peter Beverloo . resolved

nit: add this line to keep the listed histograms in these three tests in sync:
```
  histogram_tester_.ExpectTotalCount("Android.WebView.AgsaProcessName", 0);
```

Sayed Elabady

Done

File android_webview/browser/metrics/system_state_util.h

Line 45, Patchset 9: kUnknown = 0,

Peter Beverloo . resolved

When do we emit `kUnknown`? Since we don't emit this histogram at all in the non-AGA case, can we merge `kOther` into it?

Sayed Elabady

Done

File android_webview/browser/metrics/system_state_util.cc

Line 48, Patchset 9:AgsaProcessName GetAgsaProcessNameEnumImpl(std::string_view process_name) {

Peter Beverloo . resolved

Do we need all of these? If the list is currently exhaustive, what's the plan for keeping it up-to-date?

Sayed Elabady

I had a chat with jinbo@ and we are primarily interested in `:googleapp`, `:search`, and `:interactor`. I’ve kept those and omitted the others. We can always revisit this list later if need be.

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Peter Beverloo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sayed Elabady (Gerrit)

unread,

Feb 16, 2026, 9:56:39 AM (12 days ago) Feb 16

to Peter Beverloo, Alexei Svitkine, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Alexei Svitkine and Peter Beverloo

Sayed Elabady voted Commit-Queue+1

Commit-Queue

+1

satisfied_requirement

unsatisfied_requirement

open

diffy

Peter Beverloo (Gerrit)

unread,

Feb 16, 2026, 12:32:51 PM (11 days ago) Feb 16

to Sayed Elabady, Peter Beverloo, Alexei Svitkine, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Alexei Svitkine and Sayed Elabady

Peter Beverloo voted and added 2 comments

Votes added by Peter Beverloo

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Peter Beverloo . resolved

lgtm w/ comment applied

File android_webview/browser/metrics/system_state_util.h

Line 54, Patchset 10 (Latest):std::string GetProcessName();

Peter Beverloo . unresolved

Please remove this from the header file, in fact, just merge the call it makes into `GetAgsaProcessNameEnum()`?

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Sayed Elabady

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Feb 17, 2026, 10:38:42 AM (11 days ago) Feb 17

to Sayed Elabady, Peter Beverloo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Sayed Elabady

Alexei Svitkine voted and added 1 comment

Votes added by Alexei Svitkine

Code-Review

+1

1 comment

File android_webview/browser/metrics/system_state_util.h

Line 9, Patchset 10 (Latest):#include <string>

Alexei Svitkine . unresolved

When you address Peter's comment below, this include can also be removed.

Open in Gerrit

Related details

Attention is currently required from:

Sayed Elabady

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sayed Elabady (Gerrit)

unread,

Feb 17, 2026, 12:20:52 PM (10 days ago) Feb 17

to Alexei Svitkine, Peter Beverloo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Sayed Elabady added 2 comments

File android_webview/browser/metrics/system_state_util.h

Line 54, Patchset 10:std::string GetProcessName();

Peter Beverloo . resolved

Please remove this from the header file, in fact, just merge the call it makes into `GetAgsaProcessNameEnum()`?

Sayed Elabady

Done

Line 9, Patchset 10:#include <string>

Alexei Svitkine . resolved

When you address Peter's comment below, this include can also be removed.

Sayed Elabady

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Sayed Elabady (Gerrit)

unread,

Feb 17, 2026, 12:20:55 PM (10 days ago) Feb 17

to Alexei Svitkine, Peter Beverloo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Sayed Elabady voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Sayed Elabady (Gerrit)

unread,

Feb 18, 2026, 5:44:26 AM (10 days ago) Feb 18

to Alexei Svitkine, Peter Beverloo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Sayed Elabady voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 18, 2026, 5:47:57 AM (10 days ago) Feb 18

to Sayed Elabady, Alexei Svitkine, Peter Beverloo, Chromium Metrics Reviews, chromium...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

10 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: android_webview/browser/metrics/system_state_util.cc
Insertions: 5, Deletions: 6.

@@ -4,6 +4,8 @@
 
 #include "android_webview/browser/metrics/system_state_util.h"
 
+#include <string>
+
 #include "base/android/apk_info.h"
 #include "base/android/jni_string.h"
 
@@ -28,17 +30,14 @@
   return primary_cpu_abi_bitness;
 }
 
-std::string GetProcessName() {
-  return base::android::ConvertJavaStringToUTF8(
-      Java_SystemStateUtil_getProcessName(jni_zero::AttachCurrentThread()));
-}
-
 std::optional<AgsaProcessName> GetAgsaProcessNameEnum() {
   if (base::android::apk_info::host_package_name() !=
       "com.google.android.googlequicksearchbox") {
     return std::nullopt;
   }
-  return internal::GetAgsaProcessNameEnumImpl(GetProcessName());
+  std::string process_name = base::android::ConvertJavaStringToUTF8(
+      Java_SystemStateUtil_getProcessName(jni_zero::AttachCurrentThread()));
+  return internal::GetAgsaProcessNameEnumImpl(process_name);
 }
 
 namespace internal {
```
```
The name of the file: android_webview/browser/metrics/system_state_util.h
Insertions: 0, Deletions: 5.

@@ -6,7 +6,6 @@
 #define ANDROID_WEBVIEW_BROWSER_METRICS_SYSTEM_STATE_UTIL_H_
 
 #include <optional>
-#include <string>
 #include <string_view>
 
 namespace android_webview {
@@ -49,10 +48,6 @@
   kMaxValue = kOther,
 };
 
-// Returns the name of the current process, retrieved from the Java
-// ActivityThread via ContextUtils.
-std::string GetProcessName();
-
 // Returns the AGSA process name enum if the host app is AGSA, otherwise
 // nullopt.
 std::optional<AgsaProcessName> GetAgsaProcessNameEnum();
```

Change information

Commit message:

[WebView] Update AGSA process name UMA histogram enums

This CL updates the enumerated histogram used to record the process name
for AGSA in WebView UMA metrics.

The enum values in the histogram definition (histograms.xml) have been
updated to include the key processes used by AGSA, such as :googleapp,
 :search, :interactor, and others.

The client code in android_metrics_provider.cc is also updated to map
the process strings to these new enum values.

This ensures more accurate and comprehensive filtering of UMA data
based on the specific AGSA process.

Bug: b:466315206

Change-Id: Ifd76d515ca058a595caa725be3b66edeeb846a35

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7572107

Reviewed-by: Peter Beverloo <pe...@chromium.org>

Reviewed-by: Alexei Svitkine <asvi...@chromium.org>

Commit-Queue: Sayed Elabady <elabad...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1586314}

Files:

M android_webview/browser/metrics/android_metrics_provider.cc
M android_webview/browser/metrics/android_metrics_provider_unittest.cc
M android_webview/browser/metrics/system_state_util.cc
M android_webview/browser/metrics/system_state_util.h
M android_webview/java/src/org/chromium/android_webview/SystemStateUtil.java
M tools/metrics/histograms/metadata/android/enums.xml
M tools/metrics/histograms/metadata/android/histograms.xml

Change size: M

Delta: 7 files changed, 115 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Peter Beverloo, +1 by Alexei Svitkine

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[WebView] Update AGSA process name UMA histogram enums [chromium/src : main]

Sayed Elabady (Gerrit)

New activity on the change

Related details

Sayed Elabady (Gerrit)

Sayed Elabady added 1 comment

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine added 4 comments

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine added 1 comment

Sayed Elabady (Gerrit)

Sayed Elabady voted and added 4 comments

Votes added by Sayed Elabady

4 comments

Related details

Peter Beverloo (Gerrit)

Peter Beverloo added 3 comments

Related details

Sayed Elabady (Gerrit)

Sayed Elabady added 3 comments

Related details

Sayed Elabady (Gerrit)

Sayed Elabady voted Commit-Queue+1

Peter Beverloo (Gerrit)

Peter Beverloo voted and added 2 comments

Votes added by Peter Beverloo

2 comments

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine voted and added 1 comment

Votes added by Alexei Svitkine

1 comment

Related details

Sayed Elabady (Gerrit)

Sayed Elabady added 2 comments

Related details

Sayed Elabady (Gerrit)

Sayed Elabady voted Commit-Queue+1

Related details

Sayed Elabady (Gerrit)

Sayed Elabady voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information