tracing: add file I/O ETW provider [chromium/src : main]
2 views
Skip to first unread message
Jesse McKenna (Gerrit)
Oct 2, 2025, 6:48:54 PMOct 2
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jesse McKenna
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Oct 2, 2025, 8:26:09 PMOct 2
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Jesse McKenna . resolved
False start, sorry - I just realized this is missing something - back to WIP!
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Oct 8, 2025, 8:03:23 PMOct 8
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 10, 2025, 1:54:39 PMOct 10
to Jesse McKenna, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Etienne Pierre-Doray . resolved
Nice! Could you add some tests in components/tracing/common/etw_consumer_win_unittest.cc? Mainly:
- basic routing and decoding
- too short packet
- filtered packet
File components/tracing/common/etw_consumer_win.cc
Line 687, Patchset 9 (Latest):
create_event->set_open_path(base::WideToUTF8(*CopyWString(iterator)));Etienne Pierre-Doray . unresolved
Let's skip this if privacy filters are on, see:
https://source.chromium.org/chromium/chromium/src/+/main:services/tracing/public/cpp/perfetto/metadata_data_source.cc;l=98?q=MetadataDataSource&ss=chromium
The field is filtered anyways later on based on allowlist, but this avoids needlessly filling the trace buffer.
Here and below for string fields.
Related details
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Oct 28, 2025, 12:32:01 PM (13 days ago) Oct 28
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Etienne Pierre-Doray . resolved
Nice! Could you add some tests in components/tracing/common/etw_consumer_win_unittest.cc? Mainly:
- basic routing and decoding
- too short packet
- filtered packet
Jesse McKenna
Done
File components/tracing/common/etw_consumer_win.cc
Line 687, Patchset 9:
create_event->set_open_path(base::WideToUTF8(*CopyWString(iterator)));Etienne Pierre-Doray . resolved
Let's skip this if privacy filters are on, see:
https://source.chromium.org/chromium/chromium/src/+/main:services/tracing/public/cpp/perfetto/metadata_data_source.cc;l=98?q=MetadataDataSource&ss=chromiumThe field is filtered anyways later on based on allowlist, but this avoids needlessly filling the trace buffer.
Here and below for string fields.
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 28, 2025, 5:35:32 PM (13 days ago) Oct 28
to Jesse McKenna, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Etienne Pierre-Doray voted and added 2 comments![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
2 comments
Patchset-level comments
File components/tracing/common/etw_consumer_win.cc
Line 688, Patchset 10 (Latest):
if (inclusion_policy_.ShouldIncludeThreadId(header.ThreadId)) {Etienne Pierre-Doray . unresolved
I don't think these are needed; since the whole function is already guarded by the stricter ShouldRecordFileIoEvents()?
Related details
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Nov 4, 2025, 8:03:47 PM (6 days ago) Nov 4
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 11:
Jesse McKenna . resolved
Thank you for reviewing!
I added `privacy_filtered_fields-inl.h` which removed the CR+1 - would you mind taking another look? Thanks!
File components/tracing/common/etw_consumer_win.cc
Line 688, Patchset 10:
if (inclusion_policy_.ShouldIncludeThreadId(header.ThreadId)) {Etienne Pierre-Doray . resolved
I don't think these are needed; since the whole function is already guarded by the stricter ShouldRecordFileIoEvents()?
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Nov 6, 2025, 12:15:26 PM (4 days ago) Nov 6
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jesse McKenna . resolved
Thank you for reviewing!
I added `privacy_filtered_fields-inl.h` which removed the CR+1 - would you mind taking another look? Thanks!
Jesse McKenna
Never mind, a separate change was uploaded today that updates this file: crrev.com/c/7124325. I'll just wait for that CL to land, then land this.
Would you mind stamping this CL again? The CR+1 got removed in the last two patchsets. Thanks!
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Nov 6, 2025, 12:34:58 PM (4 days ago) Nov 6
to Jesse McKenna, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
Etienne Pierre-Doray . resolved
LGTM
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Nov 7, 2025, 2:03:55 PM (3 days ago) Nov 7
to Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Jesse McKenna voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jesse McKenna
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Nov 7, 2025, 2:11:59 PM (3 days ago) Nov 7
to Matt Mueller, Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Matt Mueller
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jesse McKenna . resolved
+mattm@ for the new DEP on `//crypto` - PTAL, thanks!
Related details
Attention is currently required from:
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Mueller (Gerrit)
Nov 7, 2025, 5:55:59 PM (3 days ago) Nov 7
to Jesse McKenna, Matt Mueller, Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Matt Mueller voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Nov 7, 2025, 6:05:48 PM (3 days ago) Nov 7
to Matt Mueller, Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Jesse McKenna voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 7, 2025, 6:08:56 PM (3 days ago) Nov 7
to Jesse McKenna, Matt Mueller, Etienne Pierre-Doray, AyeAye, chromium...@chromium.org, droger+w...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
tracing: add file I/O ETW provider
This change enables Chrome tracing to capture and decode file I/O ETW
events, to be passed to Perfetto. These are Windows native events that
describe file I/O operations like file creation, read, write, etc.
The corresponding Perfetto protos can be seen here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/perfetto/protos/perfetto/trace/etw/etw.proto;l=211;drc=a01a11ae2a7c0476c9ddfb0e0f77891b86110663
This is part of a broader effort to add ETW kernel events to Chrome
traces for Perfetto (Google-internal design doc:
go/windows-system-tracing). A subsequent change to Perfetto will add
visualization for these events.
Note: this CL will be submitted after cl/814443722 (Google-internal).
Bug: 400769108
Change-Id: I3b94dfcc55f4ee47118afa153e4d3d0b69a5975d
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Matt Mueller <ma...@chromium.org>
Commit-Queue: Jesse McKenna <jessem...@google.com>
Cr-Commit-Position: refs/heads/main@{#1542057}
Files:
- M components/tracing/BUILD.gn
- M components/tracing/DEPS
- M components/tracing/common/etw_consumer_win.cc
- M components/tracing/common/etw_consumer_win.h
- M components/tracing/common/etw_consumer_win_unittest.cc
- M components/tracing/common/etw_system_data_source_win.cc
- M components/tracing/common/inclusion_policy_win.cc
- M components/tracing/common/inclusion_policy_win.h
- M content/browser/resources/traces_internals/trace_recorder.ts
Change size: XL
Delta: 9 files changed, 991 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matt Mueller, +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages