[FrameDeadlineDecider] Allowlist FrameDeadlineDecider proto message [chromium/src : main]

4 views
Skip to first unread message

Kartar Singh (Gerrit)

unread,
Aug 5, 2026, 7:21:16 AM (21 hours ago) Aug 5
to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Petr Cermak

Kartar Singh added 1 comment

File services/tracing/perfetto/privacy_filtered_fields-inl.h
Line 675, Patchset 1 (Latest):// Proto Message: FrameDeadlineDecider
inline constexpr int kFrameDeadlineDeciderIndices[] = {1, 2, -1};
inline constexpr MessageInfo const* kFrameDeadlineDeciderComplexMessages[] = {
&kFrameTimeline, nullptr};
inline constexpr MessageInfo kFrameDeadlineDecider = {
kFrameDeadlineDeciderIndices, kFrameDeadlineDeciderComplexMessages};
Kartar Singh . resolved

This is the main bit I wanted to sync.

Open in Gerrit

Related details

Attention is currently required from:
  • Petr Cermak
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I134f5dca9ab63eb755e637102fa88a79fb2a1357
Gerrit-Change-Number: 8199705
Gerrit-PatchSet: 1
Gerrit-Owner: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
Gerrit-Attention: Petr Cermak <petrc...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Aug 2026 11:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kartar Singh (Gerrit)

unread,
Aug 5, 2026, 7:22:45 AM (21 hours ago) Aug 5
to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Petr Cermak

Kartar Singh added 1 comment

File services/tracing/perfetto/privacy_filtered_fields-inl.h
Line 33, Patchset 1 (Latest):inline constexpr int kClockIndices[] = {1, 2, 3, 4, -1};
Kartar Singh . resolved

These(`inline`s) are a result of recent [change](http://cl/944014702) in the syncing script internally in Google.

Open in Gerrit

Related details

Attention is currently required from:
  • Petr Cermak
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I134f5dca9ab63eb755e637102fa88a79fb2a1357
Gerrit-Change-Number: 8199705
Gerrit-PatchSet: 1
Gerrit-Owner: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
Gerrit-Attention: Petr Cermak <petrc...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Aug 2026 11:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Petr Cermak (Gerrit)

unread,
Aug 5, 2026, 7:42:43 AM (21 hours ago) Aug 5
to Kartar Singh, Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Kartar Singh

Petr Cermak voted and added 1 comment

Votes added by Petr Cermak

Code-Review+1

1 comment

File services/tracing/perfetto/privacy_filtered_fields-inl.h
Line 33, Patchset 1 (Latest):inline constexpr int kClockIndices[] = {1, 2, 3, 4, -1};
Kartar Singh . resolved

These(`inline`s) are a result of recent [change](http://cl/944014702) in the syncing script internally in Google.

Petr Cermak

Ack

Open in Gerrit

Related details

Attention is currently required from:
  • Kartar Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I134f5dca9ab63eb755e637102fa88a79fb2a1357
Gerrit-Change-Number: 8199705
Gerrit-PatchSet: 1
Gerrit-Owner: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
Gerrit-Attention: Kartar Singh <karta...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 11:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kartar Singh <karta...@google.com>
satisfied_requirement
open
diffy

Kartar Singh (Gerrit)

unread,
Aug 5, 2026, 7:45:44 AM (21 hours ago) Aug 5
to Petr Cermak, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Kartar Singh voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I134f5dca9ab63eb755e637102fa88a79fb2a1357
Gerrit-Change-Number: 8199705
Gerrit-PatchSet: 1
Gerrit-Owner: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Aug 2026 11:45:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 5, 2026, 8:23:08 AM (20 hours ago) Aug 5
to Kartar Singh, Petr Cermak, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[FrameDeadlineDecider] Allowlist FrameDeadlineDecider proto message

Allowlist ChromeTrackEvent.frame_deadline_decider in
privacy_filtered_fields-inl.h for field tracing.

TAG=agy
Bug: 500826814, b/530161880
Change-Id: I134f5dca9ab63eb755e637102fa88a79fb2a1357
Reviewed-by: Petr Cermak <petrc...@chromium.org>
Commit-Queue: Kartar Singh <karta...@google.com>
Cr-Commit-Position: refs/heads/main@{#1674048}
Files:
  • M services/tracing/perfetto/privacy_filtered_fields-inl.h
Change size: L
Delta: 1 file changed, 507 insertions(+), 453 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Petr Cermak
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I134f5dca9ab63eb755e637102fa88a79fb2a1357
Gerrit-Change-Number: 8199705
Gerrit-PatchSet: 2
Gerrit-Owner: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-Reviewer: Petr Cermak <petrc...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages