Implement early startup background tracing [chromium/src : main]

0 views

Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,

Jun 12, 2024, 12:35:01 PMJun 12

to Eric Seckler, AyeAye, Chromium LUCI CQ, Tricium, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Eric Seckler

Etienne Pierre-Doray added 1 comment

Patchset-level comments

File-level comment, Patchset 28 (Latest):

Etienne Pierre-Doray . resolved

PTAL
Some telemetry_unittests are still failing.
The issue seems to be a mismatch in trace format between startup tracing and devtool. Tracing format isn't passed at Chrome launch. However, telemetry assumes the default is json and provides it to devtool API. Not sure if this should be fixed at Chrome level (assume that devtool is json by default) or in catapult (provide explicit output format at chrome launch).
https://source.chromium.org/chromium/chromium/src/+/main:third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py;l=190?q=StartTracing%20file:.py%20backend&ss=chromium

Mac content_browsertest is also failing, I'm still investigating why.

Open in Gerrit

Related details

Attention is currently required from:

Eric Seckler

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages