Remove unnecessary //build/config/features.gni imports [chromium/src : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

Oct 15, 2025, 9:42:58 PMOct 15

to Lei Zhang, Sylvain Defresne, Arnaud Mandy, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Michael Moss, Peter Beverloo, Rijubrata Bhaumik, Sarah Krakowiak, Wei4 Wang, Chromium LUCI CQ, abigailbk...@google.com, anastas...@google.com, andysjl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, byronle...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, christia...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chungshe...@google.com, cros-print...@google.com, cros-report...@google.com, dennyh...@google.com, derinel+wat...@google.com, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdonnel...@chromium.org, johnyki...@google.com, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, language...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mpdento...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rizvis...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, rsesek...@chromium.org, shannc...@chromium.org, sky+...@chromium.org, spang...@chromium.org, subresource-f...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, vaapi-...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Sylvain Defresne

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Auto-Submit

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Lei Zhang . resolved

Please OO+1 as //build/OWNERS.

Open in Gerrit

Related details

Attention is currently required from:

Sylvain Defresne

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sylvain Defresne (Gerrit)

unread,

Oct 16, 2025, 5:28:03 AMOct 16

to Lei Zhang, Arnaud Mandy, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Michael Moss, Peter Beverloo, Rijubrata Bhaumik, Sarah Krakowiak, Wei4 Wang, Chromium LUCI CQ, abigailbk...@google.com, anastas...@google.com, andysjl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, byronle...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, christia...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chungshe...@google.com, cros-print...@google.com, cros-report...@google.com, dennyh...@google.com, derinel+wat...@google.com, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdonnel...@chromium.org, johnyki...@google.com, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, language...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mpdento...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rizvis...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, rsesek...@chromium.org, shannc...@chromium.org, sky+...@chromium.org, spang...@chromium.org, subresource-f...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, vaapi-...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Lei Zhang

Sylvain Defresne voted and added 1 comment

Votes added by Sylvain Defresne

Code-Review	+1
Commit-Queue	+2
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Sylvain Defresne . resolved

lgtm

OO for large mechanical change

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 16, 2025, 5:34:53 AMOct 16

to Lei Zhang, Sylvain Defresne, Akihiro Ota, Arnaud Mandy, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Kenneth R Christiansen, Raphael Kubo da Costa, Michael Moss, Peter Beverloo, Rijubrata Bhaumik, Sarah Krakowiak, Wei4 Wang, abigailbk...@google.com, anastas...@google.com, andysjl...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, browser-comp...@chromium.org, byronle...@chromium.org, cbe-cep-eng...@google.com, chfreme...@chromium.org, christia...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chungshe...@google.com, cros-print...@google.com, cros-report...@google.com, dennyh...@google.com, derinel+wat...@google.com, dmurph+wat...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng+c...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, fuzzin...@chromium.org, gcasto+w...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdonnel...@chromium.org, johnyki...@google.com, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, language...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, media-cro...@chromium.org, menghua...@google.com, mfoltz+wa...@chromium.org, mpdento...@chromium.org, msrame...@chromium.org, nektar...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, print-rev...@chromium.org, rizvis...@google.com, roblia...@chromium.org, rrsilva+wat...@google.com, rsesek...@chromium.org, shannc...@chromium.org, sky+...@chromium.org, spang...@chromium.org, subresource-f...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tracing...@chromium.org, vaapi-...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove unnecessary //build/config/features.gni imports

This .gni file only defines a few GN variables. Files that don't use
those variables don't need to import this .gni file.

Change-Id: I06e1e20e348cf7d29238c80430a3139b72b3fc9a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7047261

Commit-Queue: Sylvain Defresne <sdef...@chromium.org>

Owners-Override: Sylvain Defresne <sdef...@chromium.org>

Auto-Submit: Lei Zhang <the...@chromium.org>

Reviewed-by: Sylvain Defresne <sdef...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1530708}

Files:

M apps/BUILD.gn
M ash/BUILD.gn
M build/config/buildflags_paint_preview.gni
M build/config/freetype/BUILD.gn
M build/config/linux/atk/BUILD.gn
M build_overrides/build.gni
M chrome/BUILD.gn
M chrome/browser/apps/platform_apps/api/BUILD.gn
M chrome/browser/devtools/BUILD.gn
M chrome/browser/downgrade/buildflags.gni
M chrome/browser/enterprise/connectors/device_trust/attestation/common/BUILD.gn
M chrome/browser/password_manager/actor_login/BUILD.gn
M chrome/browser/password_manager/actor_login/internal/BUILD.gn
M chrome/browser/password_manager/password_change/BUILD.gn
M chrome/browser/policy/BUILD.gn
M chrome/browser/policy/messaging_layer/proto/BUILD.gn
M chrome/browser/policy/messaging_layer/storage_selector/BUILD.gn
M chrome/browser/prefetch/BUILD.gn
M chrome/browser/resources/accessibility/chromevox_helper/BUILD.gn
M chrome/browser/resources/accessibility/embedded_a11y_helper/BUILD.gn
M chrome/browser/resources/accessibility/reading_mode_gdocs_helper/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv2/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/braille_ime/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/chromevox/mv2/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/chromevox/mv3/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/common/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/enhanced_network_tts/mv2/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/enhanced_network_tts/mv3/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/select_to_speak/mv2/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/select_to_speak/mv3/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/switch_access/mv2/BUILD.gn
M chrome/browser/resources/chromeos/accessibility/switch_access/mv3/BUILD.gn
M chrome/chrome_repack_locales.gni
M chrome/common/apps/platform_apps/api/BUILD.gn
M chrome/common/apps/platform_apps/api/api_sources.gni
M chrome/common/chromeos/extensions/api/api_sources.gni
M chrome/common/controlled_frame/api/api_sources.gni
M chrome/common/extensions/BUILD.gn
M chrome/common/extensions/api/BUILD.gn
M chrome/common/extensions/api/api_sources.gni
M chrome/installer/linux/BUILD.gn
M chrome/installer/mac/BUILD.gn
M chrome/installer/mini_installer/BUILD.gn
M chrome/renderer/BUILD.gn
M chrome/renderer/extensions/BUILD.gn
M chrome/services/file_util/BUILD.gn
M chrome/services/file_util/public/cpp/BUILD.gn
M chrome/services/file_util/public/mojom/BUILD.gn
M chrome/services/system_signals/BUILD.gn
M chrome/services/system_signals/public/cpp/browser/BUILD.gn
M chrome/tools/service_discovery_sniffer/BUILD.gn
M chrome/updater/mac/signing/BUILD.gn
M chrome/utility/BUILD.gn
M chromecast/BUILD.gn
M components/accessibility/BUILD.gn
M components/app_launch_prefetch/BUILD.gn
M components/autofill/ios/browser/BUILD.gn
M components/autofill/ios/form_util/BUILD.gn
M components/browser_sync/BUILD.gn
M components/cast/api_bindings/BUILD.gn
M components/cast/message_port/BUILD.gn
M components/content_settings/core/common/BUILD.gn
M components/country_codes/BUILD.gn
M components/crash/core/common/BUILD.gn
M components/enterprise/buildflags/buildflags.gni
M components/enterprise/data_controls/content/browser/BUILD.gn
M components/feedback/BUILD.gn
M components/fingerprinting_protection_filter/common/BUILD.gn
M components/language_detection/content/browser/BUILD.gn
M components/language_detection/content/renderer/BUILD.gn
M components/language_detection/ios/browser/BUILD.gn
M components/manta/BUILD.gn
M components/on_load_script_injector/browser/BUILD.gn
M components/on_load_script_injector/renderer/BUILD.gn
M components/ownership/BUILD.gn
M components/page_info/BUILD.gn
M components/password_manager/core/browser/actor_login/BUILD.gn
M components/password_manager/core/browser/actor_login/internal/BUILD.gn
M components/password_manager/core/browser/actor_login/test/BUILD.gn
M components/password_manager/core/browser/affiliation/BUILD.gn
M components/password_manager/core/browser/export/BUILD.gn
M components/password_manager/core/browser/generation/BUILD.gn
M components/password_manager/core/browser/import/BUILD.gn
M components/password_manager/core/browser/password_store/BUILD.gn
M components/password_manager/core/browser/sharing/BUILD.gn
M components/password_manager/core/browser/sync/BUILD.gn
M components/password_manager/core/browser/ui/BUILD.gn
M components/password_manager/core/browser/well_known_change_password/BUILD.gn
M components/password_manager/ios/BUILD.gn
M components/password_manager/services/csv_password/BUILD.gn
M components/pdf/browser/BUILD.gn
M components/plugins/renderer/BUILD.gn
M components/policy/BUILD.gn
M components/policy/core/browser/BUILD.gn
M components/policy/core/common/BUILD.gn
M components/reporting/client/BUILD.gn
M components/reporting/compression/BUILD.gn
M components/reporting/encryption/BUILD.gn
M components/reporting/health/BUILD.gn
M components/reporting/resources/BUILD.gn
M components/reporting/storage/BUILD.gn
M components/reporting/util/BUILD.gn
M components/safe_browsing/content/browser/BUILD.gn
M components/safe_browsing/content/browser/download/BUILD.gn
M components/safe_browsing/content/browser/notification_content_detection/BUILD.gn
M components/safe_browsing/content/browser/triggers/BUILD.gn
M components/safe_browsing/content/common/BUILD.gn
M components/safe_browsing/content/renderer/BUILD.gn
M components/safe_browsing/content/renderer/phishing_classifier/BUILD.gn
M components/safe_browsing/core/browser/BUILD.gn
M components/safe_browsing/core/browser/sync/BUILD.gn
M components/safe_browsing/core/common/BUILD.gn
M components/search_engines/BUILD.gn
M components/security_state/ios/BUILD.gn
M components/services/font/BUILD.gn
M components/services/font_data/BUILD.gn
M components/services/heap_profiling/public/cpp/BUILD.gn
M components/signin/ios/browser/BUILD.gn
M components/subresource_filter/content/shared/browser/BUILD.gn
M components/sync/BUILD.gn
M components/sync/base/BUILD.gn
M components/sync/invalidations/BUILD.gn
M components/sync/service/BUILD.gn
M components/sync_bookmarks/BUILD.gn
M components/sync_device_info/BUILD.gn
M components/sync_preferences/BUILD.gn
M components/sync_preferences/cross_device_pref_tracker/BUILD.gn
M components/system_cpu/BUILD.gn
M components/translate/content/browser/BUILD.gn
M components/translate/content/renderer/BUILD.gn
M components/translate/ios/browser/BUILD.gn
M components/ukm/ios/BUILD.gn
M components/webauthn/ios/BUILD.gn
M content/app/BUILD.gn
M content/child/BUILD.gn
M content/common/BUILD.gn
M content/public/common/BUILD.gn
M content/public/renderer/BUILD.gn
M content/renderer/BUILD.gn
M content/shell/BUILD.gn
M crypto/features.gni
M device/base/BUILD.gn
M extensions/browser/BUILD.gn
M extensions/common/BUILD.gn
M extensions/common/api/BUILD.gn
M extensions/renderer/BUILD.gn
M extensions/shell/BUILD.gn
M google_apis/BUILD.gn
M google_apis/calendar/BUILD.gn
M google_apis/classroom/BUILD.gn
M google_apis/common/BUILD.gn
M google_apis/drive/BUILD.gn
M google_apis/tasks/BUILD.gn
M ios/build/chrome_build.gni
M ios/web_view/features.gni
M media/base/BUILD.gn
M media/capture/BUILD.gn
M media/capture/video/win/BUILD.gn
M media/cdm/library_cdm/clear_key_cdm/BUILD.gn
M media/cdm/win/test/BUILD.gn
M media/gpu/mac/BUILD.gn
M media/gpu/v4l2/BUILD.gn
M media/gpu/vaapi/BUILD.gn
M mojo/public/tools/fuzzers/BUILD.gn
M pdf/BUILD.gn
M pdf/mojom/BUILD.gn
M printing/BUILD.gn
M remoting/build/config/BUILD.gn
M remoting/build/config/remoting_build.gni
M remoting/host/it2me/BUILD.gn
M remoting/protocol/BUILD.gn
M sandbox/linux/BUILD.gn
M services/device/compute_pressure/BUILD.gn
M services/device/fingerprint/BUILD.gn
M services/device/power_monitor/BUILD.gn
M services/device/public/cpp/BUILD.gn
M services/device/public/cpp/compute_pressure/buildflags.gni
M services/device/public/cpp/hid/BUILD.gn
M services/device/public/cpp/power_monitor/BUILD.gn
M services/device/screen_orientation/BUILD.gn
M services/device/time_zone_monitor/BUILD.gn
M services/device/vibration/BUILD.gn
M services/tracing/public/cpp/background_tracing/BUILD.gn
M testing/libfuzzer/BUILD.gn
M testing/libfuzzer/fuzzer_test.gni
M testing/libfuzzer/fuzzers/BUILD.gn
M third_party/blink/public/test/mojom/BUILD.gn
M third_party/blink/renderer/platform/BUILD.gn
M third_party/crc32c/BUILD.gn
M third_party/fontconfig/fontconfig.gni
M third_party/harfbuzz-ng/BUILD.gn
M third_party/widevine/cdm/BUILD.gn
M tools/json_schema_compiler/test/BUILD.gn
M tools/typescript/webui_ts_library.gni
M ui/accessibility/BUILD.gn
M ui/message_center/BUILD.gn
M ui/views/BUILD.gn

Change size: L

Delta: 199 files changed, 4 insertions(+), 265 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Sylvain Defresne

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages