[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks. [chromium/src : master]

Etienne Pierre-Doray (Gerrit)

unread,

Aug 27, 2018, 4:31:02 PM8/27/18

to Simon Hatch, tracing...@chromium.org, wfh+...@chromium.org, chromium...@chromium.org

Etienne Pierre-Doray would like Simon Hatch to review this change.

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /content/browser/tracing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=simon...@chromium.org

Bug: 874080
Change-Id: I947898f0650e7a14a3133a4114c7fc30f326dedc
---
M content/browser/tracing/tracing_controller_impl_data_endpoint.cc
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/content/browser/tracing/tracing_controller_impl_data_endpoint.cc b/content/browser/tracing/tracing_controller_impl_data_endpoint.cc
index 6f3d4fa..b138d9f 100644
--- a/content/browser/tracing/tracing_controller_impl_data_endpoint.cc
+++ b/content/browser/tracing/tracing_controller_impl_data_endpoint.cc
@@ -11,6 +11,7 @@
 #include "base/sequenced_task_runner.h"
 #include "base/strings/pattern.h"
 #include "base/task/post_task.h"
+#include "base/threading/scoped_blocking_call.h"
 #include "content/browser/tracing/tracing_controller_impl.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/tracing_controller.h"
@@ -89,7 +90,8 @@
   }
 
   bool OpenFileIfNeededOnBlockingThread() {
-    base::AssertBlockingAllowed();
+    base::ScopedBlockingCall scoped_blocking_call(
+        base::BlockingType::MAY_BLOCK);
     if (file_ != nullptr)
       return true;
     file_ = base::OpenFile(file_path_, "w");

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Etienne Pierre-Doray (Gerrit)

unread,

Oct 5, 2018, 11:48:22 AM10/5/18

to oysteine, tracing...@chromium.org, wfh+...@chromium.org, chromium...@chromium.org, Commit Bot

Etienne Pierre-Doray uploaded patch set #2 to this change.

View Change

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /content/browser/tracing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.

  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).


    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=simon...@chromium.org

Bug: 874080
Change-Id: I947898f0650e7a14a3133a4114c7fc30f326dedc
---
M content/browser/tracing/tracing_controller_impl_data_endpoint.cc
1 file changed, 3 insertions(+), 1 deletion(-)

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

oysteine (Gerrit)

unread,

Oct 18, 2018, 2:12:54 PM10/18/18

to Etienne Pierre-Doray, tracing...@chromium.org, wfh+...@chromium.org, Commit Bot, chromium...@chromium.org

Patch set 2:Code-Review +1

View Change

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Etienne Pierre-Doray (Gerrit)

unread,

Oct 19, 2018, 4:11:17 AM10/19/18

to tracing...@chromium.org, wfh+...@chromium.org, Simon Hatch, oysteine, Commit Bot, chromium...@chromium.org

Patch set 3:Commit-Queue +2

View Change

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 19, 2018, 4:11:23 AM10/19/18

to Etienne Pierre-Doray, tracing...@chromium.org, wfh+...@chromium.org, Simon Hatch, oysteine, chromium...@chromium.org

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/1191806/3

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1191806/3

Bot data: {"action": "start", "triggered_at": "2018-10-19T08:11:14.0Z", "cq_cfg_revision": "b62fa55343ae752de4c938affba0490094dda6c4", "revision": "b05f96339c27795160c4523631b6c83ca1f55529"}

View Change

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 19, 2018, 4:15:17 AM10/19/18

to Etienne Pierre-Doray, tracing...@chromium.org, wfh+...@chromium.org, Simon Hatch, oysteine, chromium...@chromium.org

Try jobs failed on following builders:
  android-binary-size on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-binary-size/79925)
  fuchsia_x64 on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/fuchsia_x64/131239)

View Change

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Etienne Pierre-Doray (Gerrit)

unread,

Oct 19, 2018, 4:20:09 AM10/19/18

to Simon Hatch, oysteine, tracing...@chromium.org, wfh+...@chromium.org, chromium...@chromium.org, Commit Bot

Etienne Pierre-Doray uploaded patch set #4 to this change.

View Change

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /content/browser/tracing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.

  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).

    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=simon...@chromium.org

Bug: 874080
Change-Id: I947898f0650e7a14a3133a4114c7fc30f326dedc
---
M content/browser/tracing/tracing_controller_impl_data_endpoint.cc
1 file changed, 3 insertions(+), 1 deletion(-)

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Etienne Pierre-Doray (Gerrit)

unread,

Oct 19, 2018, 4:20:34 AM10/19/18

to tracing...@chromium.org, wfh+...@chromium.org, Simon Hatch, oysteine, Commit Bot, chromium...@chromium.org

Patch set 4:Commit-Queue +2

View Change

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 19, 2018, 4:20:40 AM10/19/18

to Etienne Pierre-Doray, tracing...@chromium.org, wfh+...@chromium.org, Simon Hatch, oysteine, chromium...@chromium.org

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.

"" https://chromium-review.googlesource.com/c/1191806/4

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1191806/4

Bot data: {"action": "start", "triggered_at": "2018-10-19T08:20:28.0Z", "cq_cfg_revision": "b62fa55343ae752de4c938affba0490094dda6c4", "revision": "a89aaf092a44d2b323925dd4802a71ac55c17dc8"}

View Change

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 19, 2018, 6:27:38 AM10/19/18

to Etienne Pierre-Doray, tracing...@chromium.org, wfh+...@chromium.org, Simon Hatch, oysteine, chromium...@chromium.org

Commit Bot merged this change.

View Change

Approvals:
  oysteine: Looks good to me
  Etienne Pierre-Doray: Commit

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /content/browser/tracing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.

  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).

    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=simon...@chromium.org

Bug: 874080
Change-Id: I947898f0650e7a14a3133a4114c7fc30f326dedc

Reviewed-on: https://chromium-review.googlesource.com/c/1191806
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: oysteine <oyst...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601102}


---
M content/browser/tracing/tracing_controller_impl_data_endpoint.cc
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/content/browser/tracing/tracing_controller_impl_data_endpoint.cc b/content/browser/tracing/tracing_controller_impl_data_endpoint.cc
index e3179d9..25bb0ba 100644


--- a/content/browser/tracing/tracing_controller_impl_data_endpoint.cc
+++ b/content/browser/tracing/tracing_controller_impl_data_endpoint.cc
@@ -11,6 +11,7 @@
 #include "base/sequenced_task_runner.h"
 #include "base/strings/pattern.h"
 #include "base/task/post_task.h"
+#include "base/threading/scoped_blocking_call.h"
 #include "content/browser/tracing/tracing_controller_impl.h"

 #include "content/public/browser/browser_task_traits.h"
 #include "content/public/browser/browser_thread.h"
@@ -90,7 +91,8 @@
   }
 
   bool OpenFileIfNeededOnBlockingThread() {
-    base::AssertBlockingAllowedDeprecated();


+    base::ScopedBlockingCall scoped_blocking_call(
+        base::BlockingType::MAY_BLOCK);
     if (file_ != nullptr)
       return true;
     file_ = base::OpenFile(file_path_, "w");

To view, visit change 1191806. To unsubscribe, or for help writing mail filters, visit settings.

Etienne Pierre-Doray (Gerrit)

unread,

Oct 25, 2018, 4:37:40 PM10/25/18

to aboxhal...@chromium.org, aburag...@chromium.org, achuit...@chromium.org, acourbo...@chromium.org, agriev...@chromium.org, ajwong...@chromium.org, alemat...@chromium.org, aleventh...@chromium.org, alexmo...@chromium.org, alito...@chromium.org, alokp...@chromium.org, android-web...@chromium.org, anthonyvd+a...@chromium.org, anthonyvd+p...@chromium.org, apavlo...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, atotic+...@chromium.org, autofill_ass...@google.com, beaufort.f...@gmail.com, binji...@chromium.org, blakeo+v...@chromium.org, blink-lay...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, blundell+serv...@chromium.org, blundell+...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, bpasten...@chromium.org, bradnels...@chromium.org, breve-tea...@chromium.org, browser-comp...@chromium.org, bruthig+...@chromium.org, carlos...@chromium.org, caseq...@chromium.org, cc-...@chromium.org, certificate-tra...@googlegroups.com, chasej...@chromium.org, chengx...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chirant...@chromium.org, chrome-grc-r...@chromium.org, chrome-gr...@chromium.org, cq-confi...@chromium.org, creis...@chromium.org, croissant-...@chromium.org, cros-enterpris...@chromium.org, cros-perf-...@google.com, crost...@chromium.org, csharp...@chromium.org, csharrison+...@chromium.org, csharris...@chromium.org, danakj...@chromium.org, derat...@chromium.org, dewitt...@chromium.org, dfaden+v...@google.com, dfalcant...@chromium.org, dgrog...@chromium.org, dimich...@chromium.org, dkrahn...@chromium.org, dlkumar+au...@google.com, dmazzon...@chromium.org, dmikuru...@chromium.org, dominicc+...@chromium.org, dominickn+...@chromium.org, dominickn+...@chromium.org, dominickn+w...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+wat...@chromium.org, dominickn+w...@chromium.org, donnd...@chromium.org, dougarnett+w...@chromium.org, dougt...@chromium.org, droger+w...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, dtapuska+ch...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eae+bli...@chromium.org, einbinder+wat...@chromium.org, ejcarus...@chromium.org, elijahtayl...@chromium.org, eme-r...@chromium.org, emircan+watch+...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, estevens...@chromium.org, eugeni...@chromium.org, falken...@chromium.org, fdoray...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, fmalit...@chromium.org, freedj...@chromium.org, ftirelo+au...@chromium.org, fukino...@chromium.org, fuz...@chromium.org, gab+...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, gayane...@chromium.org, gbiv+...@chromium.org, gcasto+w...@chromium.org, geoffla...@chromium.org, gfhuan...@chromium.org, glebl+...@chromium.org, glider...@chromium.org, gogerald+pa...@chromium.org, groby+bl...@chromium.org, groby+sp...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hanxi...@chromium.org, hashimo...@chromium.org, hcarmon...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, hiroh...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, huangs...@chromium.org, ibir...@google.com, iclella...@chromium.org, ihf+...@chromium.org, imchen...@chromium.org, ios-revie...@chromium.org, ios-review...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, isherif...@chromium.org, jasonrobe...@google.com, jbauma...@chromium.org, jbrom...@chromium.org, jbroma...@chromium.org, jbudori...@chromium.org, jdonnel...@chromium.org, jdufaul...@chromium.org, jered...@chromium.org, jfweit...@chromium.org, jhawkins+watc...@chromium.org, jhawkins+wat...@chromium.org, jhawkins+w...@chromium.org, jkarli...@chromium.org, jlklein+watc...@chromium.org, jlklein+wat...@chromium.org, jlklein+wa...@chromium.org, jln+...@chromium.org, jmedle...@chromium.org, jochen...@chromium.org, joelhock...@chromium.org, joenotcha...@chromium.org, johnche...@chromium.org, johnmagu...@google.com, jordynass+wat...@chromium.org, jordynass+wa...@chromium.org, jordynass+w...@chromium.org, jsaul+aut...@google.com, jsbel...@chromium.org, jsbell+ser...@chromium.org, jshin...@chromium.org, juncai...@chromium.org, katie...@chromium.org, kenjibah...@chromium.org, khorimoto+wat...@chromium.org, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kmadhus...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, kozyatins...@chromium.org, lchoi+...@chromium.org, lcwu+...@chromium.org, lhchave...@chromium.org, lizeb+watch...@chromium.org, ljuste...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lushnik...@chromium.org, mac-r...@chromium.org, mahmadi+paym...@chromium.org, mahmadi+pa...@chromium.org, maniscalco+w...@chromium.org, marinacio...@chromium.org, marq+...@chromium.org, martijn...@martijnc.be, mathp+aut...@chromium.org, mattreyno...@chromium.org, maxmori...@chromium.org, mcasas+med...@chromium.org, mdjone...@chromium.org, media-wi...@chromium.org, melevi...@chromium.org, mfoltz...@chromium.org, mgiuca...@chromium.org, michaelpg+wa...@chromium.org, michaelpg+wat...@chromium.org, michaelpg+...@chromium.org, michaelpg+w...@chromium.org, miu+...@chromium.org, mlamouri+w...@chromium.org, mlamouri+wa...@chromium.org, mlamouri+watc...@chromium.org, mlamouri+wa...@chromium.org, mlamouri+w...@chromium.org, mlamouri+watc...@chromium.org, mlamouri+watch-s...@chromium.org, mlamouri+watc...@chromium.org, msrame...@chromium.org, mtomas...@chromium.org, nasko+c...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nohle+watch...@chromium.org, nohle+watc...@chromium.org, nohle+wat...@chromium.org, nona+...@chromium.org, noyau...@chromium.org, ntp-dev...@chromium.org, nya+...@chromium.org, nyquis...@chromium.org, nzolghadr+...@chromium.org, oilpan-...@chromium.org, olka+...@chromium.org, ortuno...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pam+...@chromium.org, panicke...@chromium.org, pastarmo...@chromium.org, pdr+graphi...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, petewi...@chromium.org, pfeldma...@chromium.org, phoglun...@chromium.org, piman...@chromium.org, pkotwic...@chromium.org, poromo...@chromium.org, poscia...@chromium.org, pthatch...@chromium.org, rayanka...@chromium.org, raymes...@chromium.org, rginda...@chromium.org, ricea...@chromium.org, rlp+...@chromium.org, roblia...@chromium.org, rogerm+aut...@chromium.org, romax...@chromium.org, rouslan+...@chromium.org, rousla...@chromium.org, rsesek...@chromium.org, rsleev...@chromium.org, ryanchu...@chromium.org, samart...@chromium.org, scheduler...@chromium.org, scheduler-...@chromium.org, sdefresne...@chromium.org, sebsg+aut...@chromium.org, security-...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, shiny...@chromium.org, shuche...@chromium.org, skanuj...@chromium.org, sophiechang+w...@chromium.org, speed-metr...@chromium.org, srahim...@chromium.org, steimel+watch...@chromium.org, stevenjb+watc...@chromium.org, stevenj...@chromium.org, subresource-f...@chromium.org, sync-r...@chromium.org, szager+la...@chromium.org, takumi...@chromium.org, tapted...@chromium.org, tbansal+...@chromium.org, tburkar...@chromium.org, tedcho...@chromium.org, telemetr...@chromium.org, teraves...@chromium.org, tiku...@chromium.org, timloh...@chromium.org, tmartino+au...@chromium.org, tommyw+w...@chromium.org, toyosh...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, twifka...@chromium.org, uka...@chromium.org, ukai+...@chromium.org, vaapi-...@chromium.org, vabr+watchl...@chromium.org, vabr+watc...@chromium.org, vabr+watchlist...@chromium.org, vakh+...@chromium.org, vasilii+watchlis...@chromium.org, victorhs...@chromium.org, vmpstr...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, wnwen...@chromium.org, xhwang...@chromium.org, xiaochen...@chromium.org, xjz+...@chromium.org, yamaguc...@chromium.org, yhanad...@chromium.org, yhanada...@chromium.org, yhiran...@chromium.org, yusufo...@chromium.org, yusuke...@chromium.org, yuzo+...@chromium.org, yyanagi...@chromium.org, zea+...@chromium.org, zhaobi...@chromium.org, zol...@webkit.org, zork+...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, Alice Boxhall, AJITH KUMAR V, AJITH KUMAR V, Alexander Shalamov, Alexis Menard, Avi Drissman, David Bokan, Christian Biesinger, chromotin...@chromium.org, Chris Mumford, Chung-yih Wang, Darin Fisher, David Black, Daniel Cheng, devtools...@chromium.org, Dominic Mazzoni, Dai Mikurube, Dongseong Hwang, Daniel Rubery, Dirk Schulze, dsinclair, Ehsan Karamad, Eran Messeri, Eric Willigers, Eric Roman, Eugene But, Frank Galligan, Fredrik Söderquist, Fernando Serboncini, Glenn Adams, Hans Wennborg, Kentaro Hara, Hayato Ito, Hongchan Choi, Nate Chapin, Jeongeun Kim, Javier Fernandez, Jerome Jiang, James Zern, Kalyan Kondapally, Kenneth Rohde Christiansen, Luna Lu, Majid Valipour, Markus Heintz, Marco Paniconi, Kevin McNee, Michael Moss, Morten Stenshorne, native-cli...@googlegroups.com, Mugdha Lakhani, Nektarios Paisios, Hiroki Nakagawa, Peter Collingbourne, Peter Beverloo, Pavel Feldman, Raphael Kubo da Costa, Rebekah Potter, Manuel Rego, Rijubrata Bhaumik, Robert Kroeger, Renée Wright, Reid Kleckner, Raymond Toy, Sadrul Chowdhury, Stephen Chenney, Sergey Ulanov, Shane Stephens, Silvia Pfeiffer, srirama chandra sekhar, Stepan Khapugin, James Su, Sergio Villar, Thiago Farina, Nico Weber, Lei Zhang, Tim Volodine, Tom Finegan, Tommy Li, Taiju Tsuiki, Ian Vollick, Vovo Yang, Wanming Lin, James MacLean, Xida Chen, Yi Gu, Yoav Weiss, Yunlian Jiang, Commit Bot, chromium...@chromium.org

Etienne Pierre-Doray abandoned this change.

View Change

Abandoned

I screwed up many CL with rebase, will run git cl split again to re-upload.

To view, visit change 1191792. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward