Nasko Oskov (Gerrit)

unread,

Jun 7, 2024, 4:10:32 PMJun 7

to danakj, AyeAye, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Victor Tan, James Maclean, cfredri...@chromium.org, fuzzin...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, hayato...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsbel...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from danakj

Nasko Oskov added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Nasko Oskov . resolved

Hey Dana,
Can you review this CL for me? It is just adding pragmas to all failing files in content when the unsafe buffers warning is enabled.
Thanks in advance!
Nasko

Open in Gerrit

Related details

Attention is currently required from:

danakj

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

danakj (Gerrit)

unread,

Jun 7, 2024, 4:15:23 PMJun 7

to AyeAye, Chromium LUCI CQ, Tricium, chromium...@chromium.org, Daniel Cheng, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Victor Tan, James Maclean, cfredri...@chromium.org, fuzzin...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, hayato...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsbel...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from Nasko Oskov

danakj voted and added 1 comment

Votes added by danakj

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

danakj . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Nasko Oskov

Submit Requirements:

Code-Coverage
Code-Review

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jun 8, 2024, 12:50:00 AMJun 8

to Daniel Cheng, danakj, AyeAye, Chromium LUCI CQ, Tricium, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Victor Tan, James Maclean, blundell+...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, antoniosarto...@chromium.org, cfredri...@chromium.org, fuzzin...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, hayato...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsbel...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from Nasko Oskov and danakj

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review

+1

1 comment

Commit Message

Line 10, Patchset 6:approximately 5850 .cc and .h files only rougly 160 files fail

Daniel Cheng . unresolved

"rougly" is a possible misspelling of "roughly".

Please fix.

Open in Gerrit

Related details

Attention is currently required from:

Nasko Oskov
danakj

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nasko Oskov (Gerrit)

unread,

Jun 8, 2024, 1:06:05 AMJun 8

to Daniel Cheng, danakj, AyeAye, Chromium LUCI CQ, Tricium, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Victor Tan, James Maclean, blundell+...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, antoniosarto...@chromium.org, cfredri...@chromium.org, fuzzin...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, hayato...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsbel...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from danakj

Nasko Oskov added 1 comment

Commit Message

Line 10, Patchset 9:approximately 5850 .cc and .h files only rougly 160 files fail

Nasko Oskov . unresolved

"rougly" is a possible misspelling of "roughly".

Fixed

Open in Gerrit

Related details

Attention is currently required from:

danakj

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nasko Oskov (Gerrit)

unread,

Jun 8, 2024, 1:07:00 AMJun 8

to Daniel Cheng, danakj, AyeAye, Chromium LUCI CQ, Tricium, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Victor Tan, James Maclean, blundell+...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, antoniosarto...@chromium.org, cfredri...@chromium.org, fuzzin...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, hayato...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsbel...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from danakj

Nasko Oskov voted and added 2 comments

Votes added by Nasko Oskov

Commit-Queue

+2

2 comments

Commit Message

Line 10, Patchset 6:approximately 5850 .cc and .h files only rougly 160 files fail

Daniel Cheng . resolved

"rougly" is a possible misspelling of "roughly".

Please fix.

Nasko Oskov

Done

Line 10, Patchset 9:approximately 5850 .cc and .h files only rougly 160 files fail

Nasko Oskov . resolved

"rougly" is a possible misspelling of "roughly".
Fixed

Nasko Oskov

Done

Open in Gerrit

Related details

Attention is currently required from:

danakj

Submit Requirements:

Code-Coverage
Code-Review

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jun 8, 2024, 1:09:25 AMJun 8

to Daniel Cheng, danakj, AyeAye, Chromium LUCI CQ, Tricium, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Victor Tan, James Maclean, blundell+...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, antoniosarto...@chromium.org, cfredri...@chromium.org, fuzzin...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, hayato...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsbel...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Attention needed from Nasko Oskov and danakj

Daniel Cheng voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Nasko Oskov
danakj

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 8, 2024, 1:13:25 AMJun 8

to Daniel Cheng, danakj, AyeAye, Tricium, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Kevin Babbitt, Mike Taylor, Hiroki Nakagawa, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Victor Tan, James Maclean, blundell+...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, antoniosarto...@chromium.org, cfredri...@chromium.org, fuzzin...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavin...@chromium.org, hayato...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, jsbel...@chromium.org, jsbell+ser...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, twifka...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Prepare to remove //content/ from unsafe_bufers_paths.txt

Suppress unsafe buffer usage on a file-by-file basis.  Out of
approximately 5850 .cc and .h files only roughly 160 files fail
compilation with the unsafe buffers warning.

Suppress only, by inserting boilerplate into affected files. Do not
re-write any code to work around the issues. Properly fixing each file
will be done in follow-up CLs.

//content/ is not removed from unsafe_bufers_paths.txt file and will be
also done as a follow-up, so it makes potential reverts simpler.

Bug: 342213636

Change-Id: I4a936e63dea95a78951f7bfae6d5487708ae3c0b

AX-Relnotes: n/a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5608913

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Nasko Oskov <na...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1312393}

Files:

M content/app/content_main_runner_impl.cc
M content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
M content/browser/accessibility/ax_platform_node_textprovider_win_browsertest.cc
M content/browser/accessibility/ax_platform_node_textrangeprovider_win_browsertest.cc
M content/browser/accessibility/browser_accessibility_com_win.cc
M content/browser/accessibility/browser_accessibility_state_impl_win.cc
M content/browser/accessibility/web_contents_accessibility_android.cc
M content/browser/android/java/java_type_unittest.cc
M content/browser/attribution_reporting/attribution_internals_ui.cc
M content/browser/back_forward_cache_basics_browsertest.cc
M content/browser/blob_storage/blob_url_unittest.cc
M content/browser/bluetooth/tools/bluetooth_metrics_hash.cc
M content/browser/browser_main_loop.cc
M content/browser/browser_thread_impl.cc
M content/browser/browser_url_handler_impl.cc
M content/browser/browsing_data/browsing_data_filter_builder_impl_unittest.cc
M content/browser/browsing_data/clear_site_data_handler_browsertest.cc
M content/browser/byte_stream_unittest.cc
M content/browser/cache_storage/cache_storage_cache.cc
M content/browser/cache_storage/cache_storage_cache_unittest.cc
M content/browser/child_process_host_impl.cc
M content/browser/client_hints/client_hints.cc
M content/browser/code_cache/generated_code_cache.cc
M content/browser/code_cache/generated_code_cache_unittest.cc
M content/browser/compositor/viz_process_transport_factory.cc
M content/browser/devtools/devtools_frontend_host_impl.cc
M content/browser/devtools/devtools_http_handler.cc
M content/browser/devtools/devtools_io_context.cc
M content/browser/devtools/devtools_pipe_handler.cc
M content/browser/devtools/devtools_url_loader_interceptor.cc
M content/browser/devtools/protocol/input_handler.cc
M content/browser/devtools/protocol/native_input_event_builder_mac.mm
M content/browser/devtools/protocol/tracing_handler.cc
M content/browser/devtools/protocol/webauthn_handler.cc
M content/browser/devtools/protocol_unittest.cc
M content/browser/devtools/render_frame_devtools_agent_host_browsertest.cc
M content/browser/devtools/request_body_collector.cc
M content/browser/devtools/site_per_process_devtools_browsertest.cc
M content/browser/direct_sockets/direct_sockets_tcp_browsertest.cc
M content/browser/download/save_package_unittest.cc
M content/browser/feature_observer.cc
M content/browser/file_system_access/file_system_access_file_delegate_host_impl.cc
M content/browser/find_request_manager_browsertest.cc
M content/browser/first_party_sets/test/first_party_set_parser_value_fuzzer.cc
M content/browser/font_access/font_enumeration_data_source_linux.cc
M content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc
M content/browser/gpu/compositor_util.cc
M content/browser/gpu/gpu_data_manager_impl_private.cc
M content/browser/gpu/gpu_data_manager_impl_private_unittest.cc
M content/browser/gpu/gpu_internals_ui.cc
M content/browser/gpu/gpu_process_host.cc
M content/browser/gpu/peak_gpu_memory_tracker_impl.cc
M content/browser/host_zoom_map_impl_unittest.cc
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc
M content/browser/indexed_db/indexed_db_internals_ui.cc
M content/browser/indexed_db/indexed_db_leveldb_coding.cc
M content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc
M content/browser/indexed_db/indexed_db_return_value.cc
M content/browser/indexed_db/indexed_db_unittest.cc
M content/browser/indexed_db/indexed_db_value.cc
M content/browser/interest_group/ad_auction_service_impl.cc
M content/browser/interest_group/additional_bids_util_unittest.cc
M content/browser/interest_group/auction_runner_unittest.cc
M content/browser/interest_group/auction_worklet_manager_unittest.cc
M content/browser/interest_group/interest_group_browsertest.cc
M content/browser/loader/merkle_integrity_source_stream.cc
M content/browser/loader/merkle_integrity_source_stream_unittest.cc
M content/browser/media/capture/desktop_capture_device_unittest.cc
M content/browser/media/capture/frame_sink_video_capture_device_unittest.cc
M content/browser/media/capture/frame_test_util.cc
M content/browser/media/cdm_registry_impl_unittest.cc
M content/browser/media/media_internals.cc
M content/browser/media/media_internals_ui.cc
M content/browser/media/media_license_manager_unittest.cc
M content/browser/media/stable_video_decoder_factory.cc
M content/browser/memory_pressure/user_level_memory_pressure_signal_generator.cc
M content/browser/metrics/histograms_internals_ui.cc
M content/browser/navigation_browsertest.cc
M content/browser/network/network_errors_listing_ui.cc
M content/browser/network_service_browsertest.cc
M content/browser/notifications/notification_database_conversions_unittest.cc
M content/browser/preloading/preloading_attempt_impl.cc
M content/browser/private_aggregation/private_aggregation_host_unittest.cc
M content/browser/private_aggregation/private_aggregation_internals_ui.cc
M content/browser/process_internals/process_internals_ui.cc
M content/browser/quota/quota_internals_ui.cc
M content/browser/reduce_accept_language/reduce_accept_language_utils_unittest.cc
M content/browser/screen_orientation/screen_orientation_browsertest.cc
M content/browser/screenlock_monitor/screenlock_monitor_unittest.cc
M content/browser/service_process_host_browsertest.cc
M content/browser/service_worker/service_worker_cache_writer.cc
M content/browser/service_worker/service_worker_installed_script_reader.cc
M content/browser/service_worker/service_worker_internals_ui.cc
M content/browser/service_worker/service_worker_test_utils.cc
M content/browser/service_worker/service_worker_updated_script_loader.cc
M content/browser/speech/network_speech_recognition_engine_impl_unittest.cc
M content/browser/speech/speech_recognizer_impl.cc
M content/browser/speech/tts_linux.cc
M content/browser/storage_partition_impl_unittest.cc
M content/browser/tracing/memory_instrumentation_browsertest.cc
M content/browser/tracing/trace_report/trace_report_internals_ui.cc
M content/browser/ukm_internals_ui.cc
M content/browser/web_package/signed_exchange_certificate_chain_fuzzer.cc
M content/browser/web_package/signed_exchange_envelope_unittest.cc
M content/browser/web_package/signed_exchange_handler.cc
M content/browser/web_package/signed_exchange_subresource_prefetch_browsertest.cc
M content/browser/webauth/authenticator_impl_unittest.cc
M content/browser/webauth/client_data_json.cc
M content/browser/webrtc/webrtc_internals_ui.cc
M content/browser/webrtc/webrtc_video_capture_service_browsertest.cc
M content/browser/webui/shared_resources_data_source.cc
M content/browser/webui/web_ui_mojo_browsertest.cc
M content/browser/xr/service/browser_xr_runtime_impl.cc
M content/browser/xr/webxr_internals/webxr_internals_ui.cc
M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
M content/common/android/gin_java_bridge_value.cc
M content/common/font_list_fontconfig.cc
M content/common/gpu_pre_sandbox_hook_linux.cc
M content/common/input/synthetic_gesture_controller_unittest.cc
M content/common/input/synthetic_pointer_action_unittest.cc
M content/common/input/touch_event_stream_validator_unittest.cc
M content/common/service_worker/race_network_request_read_buffer_manager.cc
M content/common/service_worker/race_network_request_write_buffer_manager.cc
M content/common/webplugininfo_unittest.cc
M content/public/browser/web_contents_media_capture_id.cc
M content/public/test/browser_test_utils.cc
M content/public/test/test_download_http_response.cc
M content/public/test/test_navigation_throttle.cc
M content/renderer/content_security_policy_util_fuzzer.cc
M content/renderer/java/gin_java_bridge_value_converter.cc
M content/renderer/java/gin_java_bridge_value_converter_unittest.cc
M content/renderer/media/audio_decoder.cc
M content/renderer/mhtml_handle_writer.cc
M content/renderer/pepper/event_conversion.cc
M content/renderer/pepper/pepper_graphics_2d_host_unittest.cc
M content/renderer/pepper/pepper_media_device_manager.cc
M content/renderer/pepper/pepper_media_stream_audio_track_host.cc
M content/renderer/pepper/pepper_media_stream_video_track_host.cc
M content/renderer/pepper/pepper_plugin_instance_impl.cc
M content/renderer/pepper/pepper_webplugin_impl_browsertest.cc
M content/renderer/pepper/pepper_websocket_host.cc
M content/renderer/pepper/plugin_module.cc
M content/renderer/pepper/plugin_object.cc
M content/renderer/pepper/ppapi_preferences_builder.cc
M content/renderer/pepper/ppb_graphics_3d_impl.cc
M content/renderer/pepper/ppb_var_deprecated_impl.cc
M content/renderer/pepper/video_encoder_shim.cc
M content/renderer/render_thread_impl.cc
M content/renderer/render_view_browsertest.cc
M content/renderer/renderer_blink_platform_impl.cc
M content/renderer/skia_benchmarking_extension.cc
M content/renderer/v8_value_converter_impl.cc
M content/services/auction_worklet/auction_v8_inspector_util.cc
M content/services/auction_worklet/bidder_worklet_unittest.cc
M content/services/auction_worklet/seller_worklet_unittest.cc
M content/services/isolated_xr_device/xr_test_hook_wrapper.cc
M content/shell/app/shell_content_main.cc
M content/shell/app/shell_main_delegate_mac.mm
M content/shell/browser/shell_platform_delegate_views.cc
M content/test/fuzzer/file_system_manager_mojolpm_fuzzer.cc
M content/test/fuzzer/signed_exchange_envelope_fuzzer.cc
M content/test/mock_clipboard_host.cc
M content/test/mock_keyboard_driver_win.cc
M content/web_test/browser/web_test_browser_main_platform_support_win.cc
M content/web_test/browser/web_test_push_messaging_service.cc
M content/web_test/renderer/event_sender.cc
M content/web_test/renderer/gamepad_controller.cc
M content/web_test/renderer/test_plugin.cc
M content/web_test/renderer/test_plugin.h
M content/web_test/renderer/test_runner.cc
M content/web_test/renderer/web_test_grammar_checker.cc
M content/web_test/renderer/web_test_spell_checker.cc
M content/zygote/zygote_linux.cc

Change size: L

Delta: 173 files changed, 865 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Prepare to remove //content/ from unsafe_bufers_paths.txt [chromium/src : main]

Nasko Oskov (Gerrit)

Nasko Oskov added 1 comment

Related details

danakj (Gerrit)

danakj voted and added 1 comment

Votes added by danakj

1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

1 comment

Related details

Nasko Oskov (Gerrit)

Nasko Oskov added 1 comment

Related details

Nasko Oskov (Gerrit)

Nasko Oskov voted and added 2 comments

Votes added by Nasko Oskov

2 comments

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information