[tracing] Normalize early track registry initialization [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Jul 27, 2026, 11:25:17 AM (10 days ago) Jul 27
to Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Jul 27, 2026, 11:52:14 AM (10 days ago) Jul 27
to Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mikhail Khokhlov
| Code-Review | +1 |
1 comment
File services/tracing/public/cpp/trace_startup.h
Line 8, Patchset 4 (Latest):
#include <optional>Mikhail Khokhlov . unresolved
nit: move to .cc, where it's used.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jul 27, 2026, 12:59:59 PM (10 days ago) Jul 27
to Dave Tapuska, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File services/tracing/public/cpp/trace_startup.h
nit: move to .cc, where it's used.
Attention is currently required from:
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jul 28, 2026, 10:15:26 AM (9 days ago) Jul 28
to Etienne Pierre-Doray, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jul 28, 2026, 10:20:50 AM (9 days ago) Jul 28
to Dave Tapuska, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 28, 2026, 11:40:09 AM (9 days ago) Jul 28
to Etienne Pierre-Doray, Dave Tapuska, Mikhail Khokhlov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Normalize early track registry initialization
Due to sandbox restrictions, tracing is initialized later on linux.
This causes TrackRegistration to silently fail and produce invalid
data later (even once tracing is initialized).
To reduce surprising behavior, this CL enables early track registry
initialization, so that even if tracing isn't initialized,
TrackRegistration works the same on all platforms.
Later tracing initialization will work the same if track registry
is already initialized.
Follow-up relies on this to register tracks in MainThreadSchedulerImpl.
Change-Id: I9d8a2648c3754e0fbead065185bd12462e6e6d5c
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1669526}
Files:
- M base/trace_event/trace_event.h
- M content/app/content_main_runner_impl.cc
- M services/tracing/public/cpp/trace_startup.cc
- M services/tracing/public/cpp/trace_startup.h
Change size: S
Delta: 4 files changed, 32 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dave Tapuska, +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chrome Crash (Prod) (Gerrit)
Aug 1, 2026, 3:10:28 AM (5 days ago) Aug 1
to Chromium LUCI CQ, Etienne Pierre-Doray, Dave Tapuska, Mikhail Khokhlov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chrome Crash (Prod) has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages