Clean includes in trace_log [chromium/src : main]
0 views
Skip to first unread message
Michael Cui (Gerrit)
Feb 22, 2026, 10:48:22 PM (5 days ago) Feb 22
to Michael Cui, AyeAye, Chromium LUCI CQ, Lei Zhang, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org
Attention needed from Lei Zhang
Michael Cui voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Cui (Gerrit)
Feb 22, 2026, 11:13:26 PM (5 days ago) Feb 22
to Michael Cui, AyeAye, Chromium LUCI CQ, Lei Zhang, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org
Attention needed from Lei Zhang
Michael Cui voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 23, 2026, 1:40:17 AM (5 days ago) Feb 23
to Michael Cui, AyeAye, Chromium LUCI CQ, Lei Zhang, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org
Attention needed from Michael Cui
Lei Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Lei Zhang . resolved
Please ask base/trace_event/OWNERS for a review.
Related details
Attention is currently required from:
- Michael Cui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Cui (Gerrit)
Feb 23, 2026, 1:48:56 AM (5 days ago) Feb 23
to Michael Cui, AyeAye, Chromium LUCI CQ, Lei Zhang, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org
Michael Cui added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Lei Zhang . resolved
Please ask base/trace_event/OWNERS for a review.
Michael Cui
Oops, sorry - I just took the Gerrit recommended reviewer.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Feb 23, 2026, 10:40:25 AM (5 days ago) Feb 23
to Michael Cui, AyeAye, Chromium LUCI CQ, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org
Attention needed from Michael Cui
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Michael Cui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Cui (Gerrit)
Feb 24, 2026, 9:53:29 PM (3 days ago) Feb 24
to Michael Cui, Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org
Michael Cui voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 24, 2026, 10:55:33 PM (3 days ago) Feb 24
to Michael Cui, Etienne Pierre-Doray, AyeAye, tracing...@chromium.org, wfh+...@chromium.org, spang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Clean includes in trace_log
There are many unused includes in the file. If
`USE_PERFETTO_TRACE_PROCESSOR` is false, even more includes are unused
including some trace_processor ones (which should not be included per
the build flag). This causes some downstream issues - see attached bug
for more details.
Clean up all includes and guard the relevant includes behind the build
flag.
Bug: b:486689401
Change-Id: I6a6a2100a3484da2e45cd0c9410f8aaae53e8b29
Commit-Queue: Michael Cui <ml...@google.com>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1589894}
Files:
- M base/BUILD.gn
- M base/test/test_trace_processor.cc
- M base/trace_event/trace_log.cc
- M base/trace_event/trace_log.h
- M services/tracing/public/cpp/trace_startup_shared_memory_unittest.cc
Change size: M
Delta: 5 files changed, 52 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages