[tracing] Add Tracing.getTrackEventDescriptor [chromium/src : main]
Etienne Pierre-Doray (Gerrit)
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Related details
- Andrey Kosyakov
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Andrey Kosyakov added 1 comment![]( "Open in Gerrit")
Plus front-end folks -- Jack, Danil, can we do protobufs these days? I'd prefer for this sort of things to be in JSON, as is is more digestable to most of the clients.
Related details
- Danil Somsikov
- Etienne Pierre-Doray
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Plus front-end folks -- Jack, Danil, can we do protobufs these days? I'd prefer for this sort of things to be in JSON, as is is more digestable to most of the clients.
in JSON, as is is more digestable to most of the clients.
This is primarily intended for perfetto extension, where protos is easiest (it already uses proto for config in start())
Related details
- Andrey Kosyakov
- Danil Somsikov
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Andrey Kosyakov added 1 comment![]( "Open in Gerrit")
Etienne Pierre-DorayPlus front-end folks -- Jack, Danil, can we do protobufs these days? I'd prefer for this sort of things to be in JSON, as is is more digestable to most of the clients.
in JSON, as is is more digestable to most of the clients.
This is primarily intended for perfetto extension, where protos is easiest (it already uses proto for config in start())
I understand, but we generally avoid features that would serve a single client, and front-end has tracing support as well, so it would make sense to let the front-end be able to use this as well. I assume JSON would be as easy for perfetto extension to digest?
Related details
- Danil Somsikov
- Etienne Pierre-Doray
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Etienne Pierre-DorayPlus front-end folks -- Jack, Danil, can we do protobufs these days? I'd prefer for this sort of things to be in JSON, as is is more digestable to most of the clients.
Andrey Kosyakovin JSON, as is is more digestable to most of the clients.
This is primarily intended for perfetto extension, where protos is easiest (it already uses proto for config in start())
I understand, but we generally avoid features that would serve a single client, and front-end has tracing support as well, so it would make sense to let the front-end be able to use this as well. I assume JSON would be as easy for perfetto extension to digest?
so it would make sense to let the front-end be able to use this as well
I think it's by design that devtool frontend doesn't allow configuring arbitrary categories, it only provides tracing to a fixed set of events; We already expose getCategories() as a string list, which devtool doesn't use.
I assume JSON would be as easy for perfetto extension to digest
JSON is relatively easy to digest, but we loose the benefit of protos: simplifies evolution and more formal definitions.
Related details
- Andrey Kosyakov
- Danil Somsikov
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Andrey Kosyakov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
Etienne Pierre-DorayPlus front-end folks -- Jack, Danil, can we do protobufs these days? I'd prefer for this sort of things to be in JSON, as is is more digestable to most of the clients.
Andrey Kosyakovin JSON, as is is more digestable to most of the clients.
This is primarily intended for perfetto extension, where protos is easiest (it already uses proto for config in start())
Etienne Pierre-DorayI understand, but we generally avoid features that would serve a single client, and front-end has tracing support as well, so it would make sense to let the front-end be able to use this as well. I assume JSON would be as easy for perfetto extension to digest?
so it would make sense to let the front-end be able to use this as well
I think it's by design that devtool frontend doesn't allow configuring arbitrary categories, it only provides tracing to a fixed set of events; We already expose getCategories() as a string list, which devtool doesn't use.
I assume JSON would be as easy for perfetto extension to digest
JSON is relatively easy to digest, but we loose the benefit of protos: simplifies evolution and more formal definitions.
I think it's by design that devtool frontend doesn't allow configuring arbitrary categories
Ah, that's a fair point.
lgtm based on fact we're not letting users pick categories in DevTools.
Related details
- Danil Somsikov
- Etienne Pierre-Doray
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
- Avi Drissman
- Danil Somsikov
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
- Danil Somsikov
- Etienne Pierre-Doray
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
- Danil Somsikov
- Jack Franklin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[tracing] Add Tracing.getTrackEventDescriptor
This will allow perfetto to display more complete information about
tracing categories.
- M content/browser/devtools/protocol/tracing_handler.cc
- M content/browser/devtools/protocol/tracing_handler.h
- M content/browser/tracing/tracing_controller_impl.cc
- M content/browser/tracing/tracing_controller_impl.h
- M content/public/browser/tracing_controller.h
- M third_party/blink/public/devtools_protocol/domains/Tracing.pdl
Code-Review: +1 by Avi Drissman, +1 by Andrey Kosyakov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
Jack Franklin added 1 comment![]( "Open in Gerrit")
Etienne Pierre-DorayPlus front-end folks -- Jack, Danil, can we do protobufs these days? I'd prefer for this sort of things to be in JSON, as is is more digestable to most of the clients.
Andrey Kosyakovin JSON, as is is more digestable to most of the clients.
This is primarily intended for perfetto extension, where protos is easiest (it already uses proto for config in start())
Etienne Pierre-DorayI understand, but we generally avoid features that would serve a single client, and front-end has tracing support as well, so it would make sense to let the front-end be able to use this as well. I assume JSON would be as easy for perfetto extension to digest?
Andrey Kosyakovso it would make sense to let the front-end be able to use this as well
I think it's by design that devtool frontend doesn't allow configuring arbitrary categories, it only provides tracing to a fixed set of events; We already expose getCategories() as a string list, which devtool doesn't use.
I assume JSON would be as easy for perfetto extension to digest
JSON is relatively easy to digest, but we loose the benefit of protos: simplifies evolution and more formal definitions.
I think it's by design that devtool frontend doesn't allow configuring arbitrary categories
Ah, that's a fair point.
Plus front-end folks -- Jack, Danil, can we do protobufs these days?
Just to answer the Q - moving DevTools to protobuf would be a large eng undertaking; we rely on the JSON format exclusively on the frontend.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |