etw-stackwalk: finalize packet before starting new [chromium/src : main]
2 views
Skip to first unread message
Jesse McKenna (Gerrit)
Jun 9, 2026, 7:58:39 PM (2 days ago) Jun 9
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 10, 2026, 11:16:38 AM (14 hours ago) Jun 10
to Jesse McKenna, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Jun 10, 2026, 7:21:12 PM (6 hours ago) Jun 10
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Jesse McKenna voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 10, 2026, 9:03:15 PM (5 hours ago) Jun 10
to Jesse McKenna, Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
etw-stackwalk: finalize packet before starting new
crrev.com/c/7794326 added `ResetEmittedState()`, but when testing a
follow-up change locally I hit failing `PERFETTO_CHECK`
`cur_packet_->is_finalized()`: "the caller is calling NewTracePacket()
without having finalized the previous packet".
This change fixes the above failure by finalizing the previous packet
before calling `NewTracePacket()`. It also moves the code to do so into
helper `FinalizePreviousData()` to make it a bit clearer what these
steps do.
Bug: 400769265
Change-Id: Ibbf57004d9b0b50151f6fc774c610b32e5170a72
Commit-Queue: Jesse McKenna <jessem...@google.com>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1645011}
Files:
- M components/tracing/common/etw_consumer_win.cc
- M components/tracing/common/etw_consumer_win.h
Change size: S
Delta: 2 files changed, 13 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages