Remove base/hash/md5.h [chromium/src : main]
0 views
Skip to first unread message
Giovanni Ortuno Urquidi (Gerrit)
Nov 3, 2025, 2:03:07 PM (7 days ago) Nov 3
to Giovanni Ortuno Urquidi, Elly FJ, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, spang...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Elly FJ
Giovanni Ortuno Urquidi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Elly FJ
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elly FJ (Gerrit)
Nov 3, 2025, 3:23:50 PM (7 days ago) Nov 3
to Giovanni Ortuno Urquidi, Elly FJ, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, spang...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Elly FJ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Elly FJ
| Code-Review | +1 |
1 comment
Patchset-level comments
Elly FJ . resolved
lgtm, thank you!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
Nov 4, 2025, 11:24:11 AM (6 days ago) Nov 4
to Giovanni Ortuno Urquidi, Nico Weber, Elly FJ, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, spang...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Nico Weber
Giovanni Ortuno Urquidi added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Giovanni Ortuno Urquidi . resolved
thakis: Mind taking a look at this CL to remove a file that's no longer used?
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Nov 4, 2025, 12:40:46 PM (6 days ago) Nov 4
to Giovanni Ortuno Urquidi, Nico Weber, Elly FJ, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, spang...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Giovanni Ortuno Urquidi
Nico Weber voted![]( "Open in Gerrit")
Attention is currently required from:
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
Nov 4, 2025, 12:41:09 PM (6 days ago) Nov 4
to Giovanni Ortuno Urquidi, Nico Weber, Elly FJ, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, spang...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Giovanni Ortuno Urquidi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Giovanni Ortuno Urquidi
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Giovanni Ortuno Urquidi . resolved
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 4, 2025, 12:44:33 PM (6 days ago) Nov 4
to Giovanni Ortuno Urquidi, Nico Weber, Elly FJ, chromium...@chromium.org, asvitki...@chromium.org, chromeos-gfx-...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org, media-cro...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, spang...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove base/hash/md5.h
All usages have been migrated to crypto/obsolete/md5.h or upgraded to
SHA-256.
Fixed: 406729261
Change-Id: Ie643451d670c0ab701cddf2b3e820d50debd571e
Reviewed-by: Elly FJ <elly...@chromium.org>
Commit-Queue: Giovanni Ortuno Urquidi <ort...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Owners-Override: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540135}
Files:
- M base/BUILD.gn
- D base/hash/md5.cc
- D base/hash/md5.h
- D base/hash/md5_unittest.cc
- M chrome/browser/ash/login/reporting/login_logout_reporter.cc
- M chrome/browser/metrics/chromeos_metrics_provider.cc
- M content/browser/tracing/tracing_scenario.cc
- M media/gpu/chromeos/image_processor_test.cc
- M net/http/http_auth_handler_digest.cc
- M net/tools/cachetool/cachetool.cc
Change size: M
Delta: 10 files changed, 0 insertions(+), 202 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Weber, +1 by Elly FJ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages