[ax] Add native_event to NotifyWinEvent trace event args [chromium/src : main]

0 views
Skip to first unread message

Greg Thompson (Gerrit)

unread,
Mar 25, 2026, 1:09:21 PM (8 days ago) Mar 25
to Sean Maher, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, abigailbk...@google.com, ddrone...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Sean Maher

Greg Thompson added 1 comment

File ui/accessibility/platform/ax_platform_node_win.cc
Line 755, Patchset 5 (Latest): ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
Greg Thompson . unresolved

could you do the same for the other places where we call NWE? there are a few other callers.

Open in Gerrit

Related details

Attention is currently required from:
  • Sean Maher
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34c5a4105a053eda9294e71ee82fa52b49b18f04
Gerrit-Change-Number: 7696336
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Maher <sp...@chromium.org>
Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
Gerrit-Reviewer: Sean Maher <sp...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Attention: Sean Maher <sp...@chromium.org>
Gerrit-Comment-Date: Wed, 25 Mar 2026 17:09:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sean Maher (Gerrit)

unread,
Mar 31, 2026, 12:47:37 PM (2 days ago) Mar 31
to AyeAye, Greg Thompson, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, abigailbk...@google.com, ddrone...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Greg Thompson

Sean Maher added 1 comment

File ui/accessibility/platform/ax_platform_node_win.cc
Line 755, Patchset 5: ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
Greg Thompson . resolved

could you do the same for the other places where we call NWE? there are a few other callers.

Sean Maher

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Greg Thompson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I34c5a4105a053eda9294e71ee82fa52b49b18f04
    Gerrit-Change-Number: 7696336
    Gerrit-PatchSet: 6
    Gerrit-Owner: Sean Maher <sp...@chromium.org>
    Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
    Gerrit-Reviewer: Sean Maher <sp...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Attention: Greg Thompson <g...@chromium.org>
    Gerrit-Comment-Date: Tue, 31 Mar 2026 16:47:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Greg Thompson <g...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Greg Thompson (Gerrit)

    unread,
    Apr 1, 2026, 4:17:40 AM (yesterday) Apr 1
    to Sean Maher, Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, abigailbk...@google.com, ddrone...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Etienne Pierre-Doray and Sean Maher

    Greg Thompson added 2 comments

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Greg Thompson . resolved

    could you also do the calls in:

    • content/browser/renderer_host/legacy_render_widget_host_win.cc
    • ui/accessibility/platform/ax_system_caret_win.cc
    • ?
    File base/tracing/protos/chrome_track_event.proto
    Line 2920, Patchset 7 (Latest): reserved 1045, 1080;
    Greg Thompson . unresolved

    should this and the line below be removed in this CL?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    • Sean Maher
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I34c5a4105a053eda9294e71ee82fa52b49b18f04
      Gerrit-Change-Number: 7696336
      Gerrit-PatchSet: 7
      Gerrit-Owner: Sean Maher <sp...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
      Gerrit-Reviewer: Sean Maher <sp...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Attention: Sean Maher <sp...@chromium.org>
      Gerrit-Comment-Date: Wed, 01 Apr 2026 08:17:23 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Etienne Pierre-Doray (Gerrit)

      unread,
      Apr 1, 2026, 10:13:06 AM (yesterday) Apr 1
      to Sean Maher, AyeAye, Greg Thompson, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, abigailbk...@google.com, ddrone...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
      Attention needed from Sean Maher

      Etienne Pierre-Doray voted and added 2 comments

      Votes added by Etienne Pierre-Doray

      Code-Review+1

      2 comments

      Patchset-level comments
      Etienne Pierre-Doray . resolved

      LGTM

      File base/tracing/protos/chrome_track_event.proto
      Line 2920, Patchset 7 (Latest): reserved 1045, 1080;
      Greg Thompson . unresolved

      should this and the line below be removed in this CL?

      Etienne Pierre-Doray

      +1

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sean Maher
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I34c5a4105a053eda9294e71ee82fa52b49b18f04
        Gerrit-Change-Number: 7696336
        Gerrit-PatchSet: 7
        Gerrit-Owner: Sean Maher <sp...@chromium.org>
        Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
        Gerrit-Reviewer: Greg Thompson <g...@chromium.org>
        Gerrit-Reviewer: Sean Maher <sp...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-Attention: Sean Maher <sp...@chromium.org>
        Gerrit-Comment-Date: Wed, 01 Apr 2026 14:12:54 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Greg Thompson <g...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages