ios: Add chrome://tracing WebUI [chromium/src : main]

0 views

Skip to first unread message

Justin Novosad (Gerrit)

unread,

Apr 15, 2026, 2:55:13 PM (11 days ago) Apr 15

to Justin Cohen, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Justin Cohen

Justin Novosad added 1 comment

File ios/chrome/browser/webui/ui_bundled/tracing/tracing_ui_egtest.mm

Line 31, Patchset 7 (Latest): // Wait for the button state to revert.

Justin Novosad . unresolved

Doesn't this test need more steps to deal with file selection window?

Open in Gerrit

Related details

Attention is currently required from:

Justin Cohen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Cohen (Gerrit)

unread,

Apr 15, 2026, 3:50:01 PM (11 days ago) Apr 15

to Justin Novosad, chromiu...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Justin Novosad

Justin Cohen added 1 comment

File ios/chrome/browser/webui/ui_bundled/tracing/tracing_ui_egtest.mm

Line 31, Patchset 7: // Wait for the button state to revert.

Justin Novosad . resolved

Doesn't this test need more steps to deal with file selection window?

Justin Cohen

Probably not, but it can't hurt.