iwa: Introduce the enable-chromeos-isolated-web-app-set-shape flag [chromium/src : main]

2 views
Skip to first unread message

Edman Anjos (Gerrit)

unread,
Mar 19, 2026, 12:26:21 PMMar 19
to Edman Anjos, Simon Hangl, Hidehiko Abe, devtools...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, prerendering-reviews, Rijubrata Bhaumik, James Su, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, abigailbk...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, chfreme...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, roblia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, titoua...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Hidehiko Abe and Simon Hangl

Edman Anjos added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Edman Anjos . resolved

hi Simon, Hidehiko, PTAL

The CQ is failing on presubmit bots, where the "License doesn't list the current year" error comes from a previous CLs in the chain.

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Simon Hangl
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib086bea70a1a783cd5f490c8415704d7a3752401
Gerrit-Change-Number: 7609644
Gerrit-PatchSet: 9
Gerrit-Owner: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Simon Hangl <sim...@google.com>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Mar 2026 16:26:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Mar 22, 2026, 10:42:58 PM (11 days ago) Mar 22
to Edman Anjos, Simon Hangl, devtools...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, prerendering-reviews, Rijubrata Bhaumik, James Su, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, abigailbk...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, chfreme...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, roblia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, titoua...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Edman Anjos and Simon Hangl

Hidehiko Abe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Edman Anjos
  • Simon Hangl
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib086bea70a1a783cd5f490c8415704d7a3752401
Gerrit-Change-Number: 7609644
Gerrit-PatchSet: 10
Gerrit-Owner: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Simon Hangl <sim...@google.com>
Gerrit-Attention: Edman Anjos <ed...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 02:42:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Simon Hangl (Gerrit)

unread,
Mar 23, 2026, 5:23:46 AM (11 days ago) Mar 23
to Edman Anjos, Hidehiko Abe, devtools...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, prerendering-reviews, Rijubrata Bhaumik, James Su, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, abigailbk...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, chfreme...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, roblia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, titoua...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Edman Anjos

Simon Hangl voted and added 3 comments

Votes added by Simon Hangl

Code-Review+1

3 comments

Patchset-level comments
File chrome/browser/ash/isolated_web_app/DEPS
Line 9, Patchset 10 (Latest):
Simon Hangl . unresolved

nit: remove newline

File chrome/browser/ash/isolated_web_app/blink_extensions_browsertest.cc
Line 121, Patchset 10 (Latest): EXPECT_EQ(false, content::EvalJs(web_contents, "'chromeos' in window"));
Simon Hangl . unresolved

nit: `EXPECT_FALSE`

Open in Gerrit

Related details

Attention is currently required from:
  • Edman Anjos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Edman Anjos <ed...@chromium.org>
    Gerrit-Comment-Date: Mon, 23 Mar 2026 09:23:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Edman Anjos (Gerrit)

    unread,
    Mar 23, 2026, 6:36:47 AM (11 days ago) Mar 23
    to Edman Anjos, Simon Hangl, Hidehiko Abe, devtools...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, prerendering-reviews, Rijubrata Bhaumik, James Su, Chromium Metrics Reviews, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, abigailbk...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, chfreme...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, roblia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, titoua...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org

    Edman Anjos voted and added 3 comments

    Votes added by Edman Anjos

    Commit-Queue+2

    3 comments

    Patchset-level comments
    Edman Anjos . resolved

    Thank you!

    File chrome/browser/ash/isolated_web_app/DEPS
    Simon Hangl . resolved

    nit: remove newline

    Edman Anjos

    Acknowledged, the newline separates this from the `+chrome/` block above. this makes sense IMO and it's common in the codebase

    File chrome/browser/ash/isolated_web_app/blink_extensions_browsertest.cc
    Line 121, Patchset 10 (Latest): EXPECT_EQ(false, content::EvalJs(web_contents, "'chromeos' in window"));
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Gerrit-Comment-Date: Mon, 23 Mar 2026 10:36:31 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Simon Hangl <sim...@google.com>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Mar 23, 2026, 7:49:10 AM (11 days ago) Mar 23
      to Edman Anjos, Simon Hangl, Hidehiko Abe, Akihiro Ota, devtools...@chromium.org, (Julie)Jeongeun Kim, Hiroki Nakagawa, prerendering-reviews, Rijubrata Bhaumik, James Su, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, abigailbk...@google.com, ajwong...@chromium.org, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, chfreme...@chromium.org, creis...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gavin...@chromium.org, horo+...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, ortuno...@chromium.org, roblia...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, titoua...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, asvitkine...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      iwa: Introduce the enable-chromeos-isolated-web-app-set-shape flag

      This is a user visible flag in chrome://flags. When set this enables the
      `chromeos.isolatedWebApp.setShape` API for IWAs in ChromeOS.

      Enable the API locally with this line in /etc/chrome_dev.conf:
      --enable-features=CrosIsolatedWebAppSetShape
      Fixed: 487369849
      Test: fd test chromeos/ash/experiences/isolated_web_app | xargs testing/xvfb.py tools/autotest.py -C out_/Default
      Test: testing/xvfb.py tools/autotest.py -C out_/Default --run-all chrome/browser/ash/isolated_web_app/blink_extensions_browsertest.cc chrome/browser/about_flags_unittest.cc
      Change-Id: Ib086bea70a1a783cd5f490c8415704d7a3752401
      Reviewed-by: Hidehiko Abe <hide...@chromium.org>
      Reviewed-by: Simon Hangl <sim...@google.com>
      Commit-Queue: Edman Anjos <ed...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1603387}
      Files:
      • M chrome/browser/about_flags.cc
      • M chrome/browser/ash/isolated_web_app/DEPS
      • M chrome/browser/ash/isolated_web_app/blink_extensions_browsertest.cc
      • M chrome/browser/flag-metadata.json
      • M chrome/browser/flag_descriptions.h
      • M chrome/browser/ui/BUILD.gn
      • M chrome/browser/ui/tab_helpers.cc
      • M chromeos/ash/experiences/isolated_web_app/BUILD.gn
      • M chromeos/ash/experiences/isolated_web_app/DEPS
      • A chromeos/ash/experiences/isolated_web_app/cros_isolated_web_app_enabler.cc
      • A chromeos/ash/experiences/isolated_web_app/cros_isolated_web_app_enabler.h
      • M chromeos/ash/experiences/isolated_web_app/isolated_web_app_api_bridge_impl.cc
      • M chromeos/constants/chromeos_features.cc
      • M chromeos/constants/chromeos_features.h
      • M tools/metrics/histograms/enums.xml
      Change size: M
      Delta: 15 files changed, 146 insertions(+), 25 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Hidehiko Abe, +1 by Simon Hangl
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib086bea70a1a783cd5f490c8415704d7a3752401
      Gerrit-Change-Number: 7609644
      Gerrit-PatchSet: 11
      Gerrit-Owner: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Simon Hangl <sim...@google.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages