base: Convert RAW_PTR_EXCLUSION to raw_ptr<T, kUnprotectedInRelease> [chromium/src : main]

0 views

Skip to first unread message

Keishi Hattori (Gerrit)

unread,

Jun 10, 2026, 1:50:55 AM (yesterday) Jun 10

to Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Stephen Nusko

Keishi Hattori added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Keishi Hattori . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Stephen Nusko

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stephen Nusko (Gerrit)

unread,

Jun 10, 2026, 3:28:36 AM (24 hours ago) Jun 10

to Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Keishi Hattori

Stephen Nusko voted and added 2 comments

Votes added by Stephen Nusko

Code-Review

2 comments

File base/task/common/task_annotator.h

Line 221, Patchset 5 (Latest): [[maybe_unused]] RAW_PTR_EXCLUSION PendingTask& pending_task_;

Stephen Nusko . unresolved

Should this be a `raw_ref<PendingTask, kUnprotectedInRelease>`?

Perhaps update the comment as well?

File base/task/sequence_manager/work_queue.h

Line 178, Patchset 5 (Latest):

  // RAW_PTR_EXCLUSION: TaskQueueImpl is in the raw_ptr-unsupported types list
  // (perf-sensitive; see raw_ptr.h). Performance reasons (speedometer3).
  RAW_PTR_EXCLUSION TaskQueueImpl* const task_queue_ = nullptr;  // NOT OWNED.

Stephen Nusko . unresolved

This is not switched because it is perf-sensitive? Even in debug? Might want to make the comment even clearer that this was excluded. Or should this also be kUnprotectedInRelease?