[tracing] Prune unused tracing categories [chromium/src : main]
3 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Jun 28, 2026, 8:51:39 PM (5 days ago) Jun 28
to Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Jun 29, 2026, 7:21:03 AM (4 days ago) Jun 29
to Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mikhail Khokhlov
| Code-Review | +1 |
2 comments
Patchset-level comments
Mikhail Khokhlov . resolved
LGTM w/suggestion
File base/trace_event/builtin_categories.h
Line 427, Patchset 5 (Latest):
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.compile"))Mikhail Khokhlov . unresolved
Should we remove all categories defined in v8/src/tracing/trace-categories.h from here, so that there's no overlap?
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 29, 2026, 7:22:48 AM (4 days ago) Jun 29
to Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +2 |
1 comment
File base/trace_event/builtin_categories.h
Line 427, Patchset 5 (Latest):
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.compile"))Mikhail Khokhlov . resolved
Should we remove all categories defined in v8/src/tracing/trace-categories.h from here, so that there's no overlap?
Etienne Pierre-Doray
I already did that some time ago, and the remaining are v8 categories here are ones that are referred in blink.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Jun 29, 2026, 7:30:58 AM (4 days ago) Jun 29
to Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov added 1 comment![]( "Open in Gerrit")
File base/trace_event/builtin_categories.h
Line 427, Patchset 5 (Latest):
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.compile"))Mikhail Khokhlov . unresolved
Etienne Pierre-DorayShould we remove all categories defined in v8/src/tracing/trace-categories.h from here, so that there's no overlap?
I already did that some time ago, and the remaining are v8 categories here are ones that are referred in blink.
Mikhail Khokhlov
v8.runtime is not used in blink for example: https://source.chromium.org/search?q=v8.runtime%5C%22%20-f:gen%2F%20-f:crossbench%2F%20-f:pinpoint%2F&sq=
There may be others as well.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 29, 2026, 8:31:40 AM (4 days ago) Jun 29
to Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +2 |
1 comment
File base/trace_event/builtin_categories.h
Line 427, Patchset 5:
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.compile"))Mikhail Khokhlov . resolved
Etienne Pierre-DorayShould we remove all categories defined in v8/src/tracing/trace-categories.h from here, so that there's no overlap?
Mikhail KhokhlovI already did that some time ago, and the remaining are v8 categories here are ones that are referred in blink.
v8.runtime is not used in blink for example: https://source.chromium.org/search?q=v8.runtime%5C%22%20-f:gen%2F%20-f:crossbench%2F%20-f:pinpoint%2F&sq=
There may be others as well.
Etienne Pierre-Doray
Ah "v8.runtime" was aliased with "v8.runtime_stats".
Fixed and remove a few more categories.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 29, 2026, 9:43:40 AM (4 days ago) Jun 29
to Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+0![]( "Open in Gerrit")
| Commit-Queue | +0 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 29, 2026, 10:53:38 AM (4 days ago) Jun 29
to Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 29, 2026, 12:31:44 PM (4 days ago) Jun 29
to Etienne Pierre-Doray, Mikhail Khokhlov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: base/trace_event/builtin_categories.h
Insertions: 0, Deletions: 12.
@@ -99,7 +99,6 @@
perfetto::Category("Calculators"),
perfetto::Category("CameraStream"),
perfetto::Category("camera"),
- perfetto::Category("cast_app"),
perfetto::Category("cast.stream"),
perfetto::Category("cc").SetTags("rendering"),
perfetto::Category("cc.debug").SetTags("debug"),
@@ -137,7 +136,6 @@
perfetto::Category("extensions.content_verifier.debug").SetDescription(
"Traces for the extension file (content) verification process at "
"//extensions/browser/content_verifier.").SetTags("debug"),
- perfetto::Category("explore_sites"),
perfetto::Category("FileSystem"),
perfetto::Category("file_system_provider"),
perfetto::Category("fledge"),
@@ -221,7 +219,6 @@
"processes, etc. and their properties.").SetTags("toplevel"),
perfetto::Category("persistent_cache"),
perfetto::Category("ppapi"),
- perfetto::Category("ppapi_proxy"),
perfetto::Category("print"),
perfetto::Category("raf_investigation"),
perfetto::Category("rail"),
@@ -257,8 +254,6 @@
perfetto::Category("update_client").SetDescription(
"Events from component updater."),
perfetto::Category("v8"),
- perfetto::Category("v8.execute"),
- perfetto::Category("v8.wasm"),
perfetto::Category("ValueStoreFrontend::Backend"),
perfetto::Category("views").SetTags("rendering"),
perfetto::Category("views.frame"),
@@ -277,7 +272,6 @@
"Events that track usage of WebKit APIs on iOS."),
perfetto::Category("webnn"),
perfetto::Category("webrtc").SetTags("audio", "video"),
- perfetto::Category("webrtc_stats"),
perfetto::Category("xr"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("android_view_hierarchy"))
.SetTags("slow"),
@@ -366,8 +360,6 @@
.SetTags("slow"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("java-heap-profiler"))
.SetTags("slow"),
- perfetto::Category(TRACE_DISABLED_BY_DEFAULT("layer-element"))
- .SetTags("slow"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("layout_shift.debug"))
.SetTags("debug"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("lifecycles"))
@@ -426,12 +418,8 @@
.SetTags("slow"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.compile"))
.SetTags("slow"),
- perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.runtime"))
- .SetTags("slow"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.runtime_stats"))
.SetTags("slow"),
- perfetto::Category(TRACE_DISABLED_BY_DEFAULT("v8.runtime_stats_sampling"))
- .SetTags("slow"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("video_and_image_capture"))
.SetTags("video", "slow"),
perfetto::Category(TRACE_DISABLED_BY_DEFAULT("display.framedisplayed"))
```
Change information
Commit message:
[tracing] Prune unused tracing categories
Change-Id: Ib97033dca989977d098db2fb06d46990dde8bec4
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1654137}
Files:
- M base/trace_event/builtin_categories.h
Change size: M
Delta: 1 file changed, 3 insertions(+), 60 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages