Bartek Nowierski (Gerrit)

unread,

Jun 2, 2024, 1:40:09 AMJun 2

to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Daniel Cheng

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jun 4, 2024, 4:42:18 PMJun 4

to Bartek Nowierski, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Bartek Nowierski

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Daniel Cheng . resolved

LGTM!

Open in Gerrit

Related details

Attention is currently required from:

Bartek Nowierski

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Bartek Nowierski (Gerrit)

unread,

Jun 4, 2024, 9:07:23 PMJun 4

to Etienne Pierre-Doray, Reilly Grant, Vasiliy Telezhnikov, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Christoph Schwering, Etienne Pierre-Doray, Reilly Grant and Vasiliy Telezhnikov

Bartek Nowierski voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering
Etienne Pierre-Doray
Reilly Grant
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Christoph Schwering (Gerrit)

unread,

Jun 4, 2024, 10:49:56 PMJun 4

to Bartek Nowierski, Etienne Pierre-Doray, Reilly Grant, Vasiliy Telezhnikov, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Bartek Nowierski, Etienne Pierre-Doray, Reilly Grant and Vasiliy Telezhnikov

Christoph Schwering voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bartek Nowierski

Etienne Pierre-Doray
Reilly Grant
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Vasiliy Telezhnikov (Gerrit)

unread,

Jun 5, 2024, 9:31:48 AMJun 5

to Bartek Nowierski, Etienne Pierre-Doray, Reilly Grant, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Bartek Nowierski, Etienne Pierre-Doray and Reilly Grant

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Vasiliy Telezhnikov . resolved

components/viz lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:

Bartek Nowierski
Etienne Pierre-Doray
Reilly Grant

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reilly Grant (Gerrit)

unread,

Jun 5, 2024, 6:32:42 PMJun 5

to Bartek Nowierski, Reilly Grant, Stephen Nusko, Vasiliy Telezhnikov, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Bartek Nowierski and Stephen Nusko

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Reilly Grant . resolved

//extensions LGTM

Open in Gerrit

Related details

Attention is currently required from:

Bartek Nowierski
Stephen Nusko

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Jun 5, 2024, 6:37:06 PMJun 5

to Bartek Nowierski, Daniel Cheng, Reilly Grant, Stephen Nusko, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Bartek Nowierski and Stephen Nusko

Daniel Cheng voted

Code-Review	+1
Owners-Override	+1

satisfied_requirement

open

diffy

Bartek Nowierski (Gerrit)

unread,

Jun 5, 2024, 8:12:40 PMJun 5

to Daniel Cheng, Reilly Grant, Stephen Nusko, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Attention needed from Stephen Nusko

Bartek Nowierski voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Stephen Nusko

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 5, 2024, 8:15:09 PMJun 5

to Bartek Nowierski, Daniel Cheng, Reilly Grant, Stephen Nusko, Vasiliy Telezhnikov, chromium...@chromium.org, blundell+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, rouslan+au...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, wittma...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Mark BasicAutoLock STACK_ALLOCATED

STACK_ALLOCATED is viral so the embedding classes need the same annotation. While at it, un-rewrite raw_ptr in these classes, as we have a rule to avoid rewriting these. No RAW_PTR_EXCLUSION needed for
STACK_ALLOCATED classes.

Change-Id: I7def63e4debd7e0fca01ad1e547e338d92971006

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5588482

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Owners-Override: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Bartek Nowierski <bar...@chromium.org>

Reviewed-by: Reilly Grant <rei...@chromium.org>

Reviewed-by: Christoph Schwering <schw...@google.com>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1310999}

Files:

M base/profiler/metadata_recorder.h
M base/profiler/stack_sampler.cc
M base/synchronization/lock_impl.h
M components/autofill/core/browser/data_model/borrowed_transliterator.h
M components/viz/common/gpu/context_provider.h
M components/viz/common/gpu/raster_context_provider.h
M extensions/common/permissions/permissions_data.cc
M services/tracing/public/cpp/perfetto/trace_event_data_source.cc

Change size: S

Delta: 8 files changed, 30 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Christoph Schwering, +1 by Reilly Grant, +1 by Daniel Cheng, +1 by Vasiliy Telezhnikov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Mark BasicAutoLock STACK_ALLOCATED [chromium/src : main]

Bartek Nowierski (Gerrit)

New activity on the change

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

1 comment

Related details

Bartek Nowierski (Gerrit)

Bartek Nowierski voted Commit-Queue+1

Related details

Christoph Schwering (Gerrit)

Christoph Schwering voted Code-Review+1

Related details

Vasiliy Telezhnikov (Gerrit)

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

1 comment

Related details

Reilly Grant (Gerrit)

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

1 comment

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted

Bartek Nowierski (Gerrit)

Bartek Nowierski voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information