[tracing] Guard legacy system tracing data sources behind a disabled feature [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Apr 21, 2026, 4:45:29 PM (5 days ago) Apr 21
to Chinglin Yu, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
Attention needed from Chinglin Yu

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Chinglin Yu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I68326afea0e667c0e0261c34171d65fb818cd4e9
Gerrit-Change-Number: 7780902
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Chinglin Yu <ching...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Chinglin Yu <ching...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 20:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Chinglin Yu (Gerrit)

unread,
Apr 21, 2026, 9:17:29 PM (5 days ago) Apr 21
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
Attention needed from Etienne Pierre-Doray

Chinglin Yu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68326afea0e667c0e0261c34171d65fb818cd4e9
    Gerrit-Change-Number: 7780902
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chinglin Yu <ching...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Apr 2026 01:16:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Apr 22, 2026, 2:22:39 PM (4 days ago) Apr 22
    to Yury Khmel, Chinglin Yu, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
    Attention needed from Chinglin Yu and Yury Khmel

    Etienne Pierre-Doray added 1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Etienne Pierre-Doray . resolved

    +khmel@ for chrome/browser/ash/arc/

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chinglin Yu
    • Yury Khmel
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I68326afea0e667c0e0261c34171d65fb818cd4e9
      Gerrit-Change-Number: 7780902
      Gerrit-PatchSet: 4
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Chinglin Yu <ching...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Yury Khmel <kh...@chromium.org>
      Gerrit-Attention: Chinglin Yu <ching...@chromium.org>
      Gerrit-Attention: Yury Khmel <kh...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Apr 2026 18:22:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Chinglin Yu (Gerrit)

      unread,
      Apr 22, 2026, 11:47:08 PM (4 days ago) Apr 22
      to Etienne Pierre-Doray, Yury Khmel, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, hidehik...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yhanada+...@chromium.org
      Attention needed from Etienne Pierre-Doray and Yury Khmel

      Chinglin Yu voted and added 1 comment

      Votes added by Chinglin Yu

      Code-Review+1

      1 comment

      Patchset-level comments
      Chinglin Yu . resolved

      Looks good for CrOS tracing.

      IIUC ARC tracing works only for ARC++ container and doesn't work for ARCVM. So it's probably dead code now.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Etienne Pierre-Doray
      • Yury Khmel
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I68326afea0e667c0e0261c34171d65fb818cd4e9
        Gerrit-Change-Number: 7780902
        Gerrit-PatchSet: 4
        Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
        Gerrit-Reviewer: Chinglin Yu <ching...@chromium.org>
        Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
        Gerrit-Reviewer: Yury Khmel <kh...@chromium.org>
        Gerrit-Attention: Yury Khmel <kh...@chromium.org>
        Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
        Gerrit-Comment-Date: Thu, 23 Apr 2026 03:46:42 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages