Migrate various base::Contains() to contains() in base [chromium/src : main]
0 views
Skip to first unread message
Victor Vianna (Gerrit)
Jan 6, 2026, 2:36:41 AM (6 days ago) Jan 6
to Francois Pierre Doray, chromium...@chromium.org, Chromium LUCI CQ, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray
Victor Vianna voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Jan 7, 2026, 9:58:14 AM (5 days ago) Jan 7
to Victor Vianna, chromium...@chromium.org, Chromium LUCI CQ, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Victor Vianna
Francois Pierre Doray voted![]( "Open in Gerrit")
Attention is currently required from:
- Victor Vianna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Jan 7, 2026, 11:12:55 AM (5 days ago) Jan 7
to Francois Pierre Doray, chromium...@chromium.org, Chromium LUCI CQ, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Victor Vianna voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Vianna
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File base/cpu_unittest.cc
Line 20, Patchset 3 (Latest):
// "undefined instruction" exceptions. That is, this test succeeds when itVictor Vianna . resolved
fdoray@: The change in base/cpu_unittest.cc landed as part of crrev.com/c/7367723, which would change the list of files in this CL and reset the +1. To avoid that, I slightly rephrased this comment.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 7, 2026, 12:26:24 PM (5 days ago) Jan 7
to Victor Vianna, Francois Pierre Doray, chromium...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: base/cpu_unittest.cc
Insertions: 4, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Migrate various base::Contains() to contains() in base
Bug: 470391351
Change-Id: I42b4614603d38064545465d278ec072476c2bbd1
Auto-Submit: Victor Vianna <victor...@google.com>
Commit-Queue: Victor Vianna <victor...@google.com>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1565725}
Files:
- M base/command_line.cc
- M base/containers/variant_map_unittest.cc
- M base/cpu_unittest.cc
- M base/debug/stack_trace_unittest.cc
- M base/feature_list.cc
- M base/files/file_path_watcher_inotify.cc
- M base/files/file_util_posix.cc
- M base/metrics/field_trial_param_associator.cc
- M base/metrics/histogram_snapshot_manager_unittest.cc
- M base/metrics/histogram_threadsafe_unittest.cc
- M base/metrics/persistent_sample_map.cc
- M base/metrics/statistics_recorder.cc
- M base/sampling_heap_profiler/lock_free_address_hash_set.cc
- M base/scoped_generic_unittest.cc
- M base/substring_set_matcher/substring_set_matcher.cc
- M base/substring_set_matcher/substring_set_matcher_perftest.cc
- M base/task/thread_pool/worker_thread_set.cc
- M base/test/launcher/test_launcher.cc
- M base/test/launcher/test_launcher_unittest.cc
- M base/test/metrics/action_variants_reader_unittest.cc
- M base/trace_event/trace_log.cc
- M base/tracing/perfetto_task_runner.cc
- M base/types/expected_unittest.cc
Change size: M
Delta: 23 files changed, 61 insertions(+), 83 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Francois Pierre Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages