Convert to UNSAFE_TODO in base 8/9- base/trace_event [chromium/src : main]
0 views
Skip to first unread message
Arthur Sonzogni (Gerrit)
Dec 12, 2025, 5:48:44 AM (9 days ago) Dec 12
to chromium...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
Convert to UNSAFE_TODO in base 8/9- base/trace_event
This is an automated #cleanup patch using the [Script] below.
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-chrome
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: Ied4ff159d6b68647659a65b419a96d526d76c8ac
Change diff
Change information
Files:
- M base/trace_event/malloc_dump_provider.cc
- M base/trace_event/memory_usage_estimator.h
- M base/trace_event/process_memory_dump.cc
- M base/trace_event/process_memory_dump_unittest.cc
- M base/trace_event/trace_arguments.cc
- M base/trace_event/trace_arguments.h
- M base/trace_event/trace_event_impl.h
- M base/trace_event/trace_event_unittest.cc
- M base/trace_event/trace_log.cc
- M base/trace_event/trace_logging_minimal_win.cc
- M base/trace_event/trace_logging_minimal_win.h
Change size: M
Delta: 11 files changed, 74 insertions(+), 107 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Dec 12, 2025, 8:19:26 AM (9 days ago) Dec 12
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng
Arthur Sonzogni added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Arthur Sonzogni . resolved
Hi Daniel,
Could you please take a look?
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Dec 12, 2025, 11:01:02 AM (8 days ago) Dec 12
to Arthur Sonzogni, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Arthur Sonzogni
Daniel Cheng voted![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 12, 2025, 11:03:55 AM (8 days ago) Dec 12
to Arthur Sonzogni, Daniel Cheng, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Convert to UNSAFE_TODO in base 8/9- base/trace_event
This is an automated #cleanup patch using the [Script] below.
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
This CL was uploaded by an experimental version of git cl split
(https://crbug.com/389069356).
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-chrome
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: Ied4ff159d6b68647659a65b419a96d526d76c8ac
Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1558054}
Files:
- M base/trace_event/malloc_dump_provider.cc
- M base/trace_event/memory_usage_estimator.h
- M base/trace_event/process_memory_dump.cc
- M base/trace_event/process_memory_dump_unittest.cc
- M base/trace_event/trace_arguments.cc
- M base/trace_event/trace_arguments.h
- M base/trace_event/trace_event_impl.h
- M base/trace_event/trace_event_unittest.cc
- M base/trace_event/trace_log.cc
- M base/trace_event/trace_logging_minimal_win.cc
- M base/trace_event/trace_logging_minimal_win.h
Change size: M
Delta: 11 files changed, 74 insertions(+), 107 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages