[gtest] Clean up single-arg `testing::Invoke()`s in most `//services/` [chromium/src : main]

0 views
Skip to first unread message

Jonathan Lee (Gerrit)

unread,
Aug 22, 2025, 12:10:23 AMAug 22
to Daniel Cheng, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, Chromium LUCI CQ, chfreme...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng

Jonathan Lee voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4501e134a2878822cdf159816c703945d2073bed
Gerrit-Change-Number: 6872650
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 22 Aug 2025 04:10:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Aug 22, 2025, 12:14:14 AMAug 22
to Jonathan Lee, Daniel Cheng, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, Chromium LUCI CQ, chfreme...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jonathan Lee

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Lee
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4501e134a2878822cdf159816c703945d2073bed
Gerrit-Change-Number: 6872650
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Jonathan Lee <jonath...@google.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 04:14:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 22, 2025, 12:17:12 AMAug 22
to Jonathan Lee, Daniel Cheng, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, chfreme...@chromium.org, chrome-gr...@chromium.org, feature-me...@chromium.org, marinacio...@chromium.org, network-ser...@chromium.org, olka+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[gtest] Clean up single-arg `testing::Invoke()`s in most `//services/`

Not needed and deprecated [0]. This CL should be a no-op.

https://crrev.com/c/6871207 handles `//services/device/` separately to
keep the CL sizes reasonable.

[0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046
Bug: 439838457
Change-Id: I4501e134a2878822cdf159816c703945d2073bed
Auto-Submit: Jonathan Lee <jonath...@google.com>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1504845}
Files:
  • M services/audio/output_controller_unittest.cc
  • M services/audio/public/cpp/output_device_unittest.cc
  • M services/network/mdns_responder_unittest.cc
  • M services/network/prefetch_url_loader_client_unittest.cc
  • M services/network/trust_tokens/trust_token_request_issuance_helper_unittest.cc
  • M services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
  • M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler_unittest.cc
  • M services/video_capture/device_media_to_mojo_adapter_unittest.cc
  • M services/video_capture/test/fake_device_descriptor_test.cc
  • M services/video_capture/test/fake_video_capture_device_test.cc
  • M services/video_capture/test/fake_video_capture_device_unittest.cc
  • M services/video_capture/test/mock_video_capture_device_shared_access_unittest.cc
  • M services/video_capture/test/mock_video_capture_device_test.cc
  • M services/video_capture/test/mock_video_capture_device_unittest.cc
  • M services/video_capture/test/service_lifecycle_unittest.cc
  • M services/video_capture/test/video_capture_service_unittest.cc
  • M services/video_capture/test/virtual_device_unittest.cc
Change size: L
Delta: 18 files changed, 331 insertions(+), 373 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4501e134a2878822cdf159816c703945d2073bed
Gerrit-Change-Number: 6872650
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Lee <jonath...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Jonathan Lee <jonath...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages