etw-stackwalk: add stack walk event tests [chromium/src : main]

0 views

Skip to first unread message

Jesse McKenna (Gerrit)

unread,

Jun 8, 2026, 1:09:15 PM (3 days ago) Jun 8

to Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray

Jesse McKenna added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Jesse McKenna . resolved

PTAL, thank you : )

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Jun 10, 2026, 11:36:47 AM (15 hours ago) Jun 10

to Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Jesse McKenna

Etienne Pierre-Doray added 1 comment

File components/tracing/common/etw_consumer_win_unittest.cc

Line 1118, Patchset 3 (Latest):

TEST_F(EtwConsumerTest, StackWalkFiltering) {
  // Stack thread ID is masked if it doesn't belong to Chrome.
  ProcessStackWalkEvent(EncodeStackWalk(123456u, kOtherPid, kOtherTid, {}));
  ASSERT_EQ(decoders().size(), 1u);

  std::optional<perfetto::protos::pbzero::EtwTraceEvent::Decoder> event;
  std::optional<perfetto::protos::pbzero::StackWalkEtwEvent::Decoder>
      stack_walk;
  ASSERT_NO_FATAL_FAILURE(
      ValidateAndDecodeStackWalk(*decoders().back(), event, stack_walk));

  EXPECT_FALSE(event->has_thread_id());
}

Etienne Pierre-Doray . unresolved

Come to think of it, we should exclude the entire stack walk events if the thread id is not chrome (we wouldn't be able to symbolize anyways), so the impl should follow the same pattern as ShouldRecordFileIoEvents.