Update classes to match chrome style requirements [chromium/src : main]

0 views
Skip to first unread message

Devon Loehr (Gerrit)

unread,
Aug 18, 2025, 5:26:32 PMAug 18
to Kartar Singh, chromium...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Kartar Singh

Devon Loehr has uploaded the change for review

Devon Loehr would like Kartar Singh to review this change.

Commit message

Update classes to match chrome style requirements

Recent changes to llvm have caused our style plugin to flag
additional parts of the code that it missed before. Fix
the warnings by adding variosu constructors/destructors,
and/or moving their definitions to .cc files, as needed.

This change applies to the following directories:
services

This CL was uploaded by git cl split.

R=karta...@google.com
Bug: 437910658
Change-Id: I62838ac710586f9ad360702222b9b26e1525584c

Change diff

diff --git a/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc b/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
index c5d1f22d..1b942f8b 100644
--- a/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
+++ b/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
@@ -284,6 +284,8 @@
 
 }  // namespace
 
+TracingSamplerProfiler::DataSource::DataSource() = default;
+
 TracingSamplerProfiler::DataSource::~DataSource() = default;
 
 void TracingSamplerProfiler::DataSource::OnSetup(const SetupArgs& args) {
diff --git a/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h b/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
index b8f18e4..962740ef 100644
--- a/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
+++ b/services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
@@ -66,7 +66,7 @@
 
     using TraceContext = perfetto::DataSource<DataSource>::TraceContext;
 
-    DataSource() = default;
+    DataSource();
     ~DataSource() override;
 
     void OnSetup(const SetupArgs& args) override;

Change information

Files:
  • M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
  • M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
Change size: XS
Delta: 2 files changed, 3 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Kartar Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62838ac710586f9ad360702222b9b26e1525584c
Gerrit-Change-Number: 6860002
Gerrit-PatchSet: 1
Gerrit-Owner: Devon Loehr <dlo...@google.com>
Gerrit-Reviewer: Devon Loehr <dlo...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-Attention: Kartar Singh <karta...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kartar Singh (Gerrit)

unread,
Aug 21, 2025, 10:58:26 AMAug 21
to Devon Loehr, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Devon Loehr

Kartar Singh voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Devon Loehr
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62838ac710586f9ad360702222b9b26e1525584c
Gerrit-Change-Number: 6860002
Gerrit-PatchSet: 2
Gerrit-Owner: Devon Loehr <dlo...@google.com>
Gerrit-Reviewer: Devon Loehr <dlo...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Devon Loehr <dlo...@google.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 14:58:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devon Loehr (Gerrit)

unread,
Aug 21, 2025, 12:43:49 PMAug 21
to Kartar Singh, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Kartar Singh

Devon Loehr voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kartar Singh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62838ac710586f9ad360702222b9b26e1525584c
Gerrit-Change-Number: 6860002
Gerrit-PatchSet: 2
Gerrit-Owner: Devon Loehr <dlo...@google.com>
Gerrit-Reviewer: Devon Loehr <dlo...@google.com>
Gerrit-Reviewer: Kartar Singh <karta...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-Attention: Kartar Singh <karta...@google.com>
Gerrit-Comment-Date: Thu, 21 Aug 2025 16:43:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 21, 2025, 1:20:36 PMAug 21
to Devon Loehr, Kartar Singh, Code Review Nudger, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Update classes to match chrome style requirements

Recent changes to llvm have caused our style plugin to flag
additional parts of the code that it missed before. Fix
the warnings by adding various constructors/destructors,

and/or moving their definitions to .cc files, as needed.

This change applies to the following directories:
services

This CL was uploaded by git cl split.

R=karta...@google.com
Bug: 437910658
Change-Id: I62838ac710586f9ad360702222b9b26e1525584c
Reviewed-by: Kartar Singh <karta...@google.com>
Commit-Queue: Devon Loehr <dlo...@google.com>
Auto-Submit: Devon Loehr <dlo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1504611}
Files:
  • M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
  • M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
Change size: XS
Delta: 2 files changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kartar Singh
 Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit



 Gerrit-MessageType: merged 


 Gerrit-Project: chromium/src 


 Gerrit-Branch: main 


 Gerrit-Change-Id: I62838ac710586f9ad360702222b9b26e1525584c 


 Gerrit-Change-Number: 6860002 


 Gerrit-PatchSet: 3 


 Gerrit-Owner: Devon Loehr <dlo...@google.com> 


 Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 


 Gerrit-Reviewer: Devon Loehr <dlo...@google.com> 


 Gerrit-Reviewer: Kartar Singh <karta...@google.com> 


open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages