Use ntdll.lib to link LdrLockLoaderLock in tracing sampler [chromium/src : main]
0 views
Skip to first unread message
Alex Gough (Gerrit)
Jan 28, 2026, 1:20:08 AM (10 days ago) Jan 28
to Alex Gough, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Stephen Nusko
Alex Gough added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Stephen Nusko
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Nusko (Gerrit)
Jan 28, 2026, 3:38:52 AM (10 days ago) Jan 28
to Alex Gough, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Stephen Nusko added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Stephen Nusko . resolved
This looks reasonable to me, but I'm actually going to delegate this to Etienne, I never really touched Windows tracing and I know there was a lot of loader lock investigations on the catan team so I suspect you'll have more context if there is any issue. Otherwise this would LGTM.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jan 28, 2026, 1:15:44 PM (10 days ago) Jan 28
to Alex Gough, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Alex Gough and Joe Mason
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Etienne Pierre-Doray . resolved
+joenotcharles@ I'm not familiar with this code
Related details
Attention is currently required from:
- Alex Gough
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Jan 28, 2026, 2:20:15 PM (10 days ago) Jan 28
to Alex Gough, Etienne Pierre-Doray, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Alex Gough and Etienne Pierre-Doray
Joe Mason voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joe Mason
| Code-Review | +1 |
1 comment
Patchset-level comments
Etienne Pierre-Doray . resolved
+joenotcharles@ I'm not familiar with this code
Joe Mason
Checked with etienneb. As far as we recall, the only reason these are loaded at runtime is we didn't think they were visible when directly linked. If this builds ok now, LGTM.
Related details
Attention is currently required from:
- Alex Gough
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jan 28, 2026, 2:25:24 PM (10 days ago) Jan 28
to Alex Gough, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Alex Gough
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Etienne Pierre-Doray . resolved
LGTM
Related details
Attention is currently required from:
- Alex Gough
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Gough (Gerrit)
Jan 28, 2026, 4:09:37 PM (10 days ago) Jan 28
to Alex Gough, Etienne Pierre-Doray, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Alex Gough voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Gough
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 28, 2026, 4:12:35 PM (10 days ago) Jan 28
to Alex Gough, Etienne Pierre-Doray, Stephen Nusko, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use ntdll.lib to link LdrLockLoaderLock in tracing sampler
These functions can be directly linked, allowing us to remove
some custom initialization code that can happen at load time.
Bug: 40209447
Change-Id: Ic8ad6a542696ac1d7c4a4c69490de9d7a481c500
Reviewed-by: Joe Mason <joenot...@google.com>
Commit-Queue: Alex Gough <aj...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1576161}
Files:
- M services/tracing/public/cpp/BUILD.gn
- M services/tracing/public/cpp/stack_sampling/loader_lock_sampler_win.cc
Change size: M
Delta: 2 files changed, 12 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray, +1 by Joe Mason
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages