Update Perfetto privacy filter [chromium/src : main]

0 views
Skip to first unread message

Joe Mason (Gerrit)

unread,
Feb 20, 2026, 3:51:46 PM (7 days ago) Feb 20
to Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Joe Mason voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4c21b25d87e0e65aec42184aaa3b8053ad31d747
Gerrit-Change-Number: 7595783
Gerrit-PatchSet: 1
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 20:51:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Feb 23, 2026, 12:31:59 PM (4 days ago) Feb 23
to Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Etienne Pierre-Doray . resolved

LGTM

Commit Message
Line 8, Patchset 1 (Latest):
Etienne Pierre-Doray . unresolved

Nit: link the CL that added the MemoryDumpProvider proto

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4c21b25d87e0e65aec42184aaa3b8053ad31d747
Gerrit-Change-Number: 7595783
Gerrit-PatchSet: 1
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Mon, 23 Feb 2026 17:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Mason (Gerrit)

unread,
Feb 23, 2026, 3:46:32 PM (4 days ago) Feb 23
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Joe Mason voted

Auto-Submit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4c21b25d87e0e65aec42184aaa3b8053ad31d747
Gerrit-Change-Number: 7595783
Gerrit-PatchSet: 4
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Mon, 23 Feb 2026 20:46:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Mason (Gerrit)

unread,
Feb 23, 2026, 3:46:43 PM (4 days ago) Feb 23
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Joe Mason added 1 comment

Commit Message
Line 8, Patchset 1:
Etienne Pierre-Doray . resolved

Nit: link the CL that added the MemoryDumpProvider proto

Joe Mason

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4c21b25d87e0e65aec42184aaa3b8053ad31d747
    Gerrit-Change-Number: 7595783
    Gerrit-PatchSet: 4
    Gerrit-Owner: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Comment-Date: Mon, 23 Feb 2026 20:46:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
    satisfied_requirement
    open
    diffy

    Joe Mason (Gerrit)

    unread,
    Feb 23, 2026, 5:30:12 PM (4 days ago) Feb 23
    to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Joe Mason voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4c21b25d87e0e65aec42184aaa3b8053ad31d747
    Gerrit-Change-Number: 7595783
    Gerrit-PatchSet: 4
    Gerrit-Owner: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Comment-Date: Mon, 23 Feb 2026 22:30:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 23, 2026, 8:02:37 PM (4 days ago) Feb 23
    to Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Update Perfetto privacy filter

    MemoryDumpProvider was added in https://crrev.com/c/7595714.
    Bug: 450929521
    Change-Id: I4c21b25d87e0e65aec42184aaa3b8053ad31d747
    Commit-Queue: Joe Mason <joenot...@google.com>
    Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
    Auto-Submit: Joe Mason <joenot...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1589049}
    Files:
    • M services/tracing/perfetto/privacy_filtered_fields-inl.h
    Change size: S
    Delta: 1 file changed, 9 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4c21b25d87e0e65aec42184aaa3b8053ad31d747
    Gerrit-Change-Number: 7595783
    Gerrit-PatchSet: 5
    Gerrit-Owner: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages