[base] Pass base::Time{,Delta,Ticks} by value instead of reference [chromium/src : main]
1 view
Skip to first unread message
Sylvain Defresne (Gerrit)
Jul 29, 2026, 10:57:50 AM (8 days ago) Jul 29
to Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Nico Weber
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sylvain Defresne . resolved
As suggested, a single CL with all changes in //base.
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Jul 29, 2026, 11:13:39 AM (8 days ago) Jul 29
to Sylvain Defresne, Nico Weber, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Sylvain Defresne
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 29, 2026, 12:41:34 PM (8 days ago) Jul 29
to Sylvain Defresne, Nico Weber, chromium...@chromium.org, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[base] Pass base::Time{,Delta,Ticks} by value instead of reference
The types are copyable, moveable and have the same size as a 64-bit
integer. The documentation recommends passing them by value instead
of const reference.
Update code all remaining code in //base.Bug: none
Change-Id: Ic27c0997d6f15ca1cb582b8ebb75daf02ada92cc
Commit-Queue: Nico Weber <tha...@chromium.org>
Commit-Queue: Sylvain Defresne <sdef...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1670330}
Files:
- M base/android/pre_freeze_background_memory_trimmer_unittest.cc
- M base/android/self_compaction_manager.cc
- M base/android/self_compaction_manager.h
- M base/files/file_locking_unittest.cc
- M base/i18n/icubridge/date_time_formatter.cc
- M base/i18n/icubridge/date_time_formatter.h
- M base/i18n/message_formatter.cc
- M base/i18n/message_formatter.h
- M base/i18n/message_formatter_unittest.cc
- M base/i18n/time_formatting.cc
- M base/i18n/time_formatting.h
- M base/i18n/time_formatting_unittest.cc
- M base/metrics/histogram_base.cc
- M base/metrics/histogram_base.h
- M base/moving_window.h
- M base/one_shot_event.cc
- M base/one_shot_event.h
- M base/synchronization/condition_variable.h
- M base/synchronization/condition_variable_posix.cc
- M base/synchronization/condition_variable_win.cc
- M base/synchronization/lock_metrics_recorder.cc
- M base/synchronization/lock_metrics_recorder.h
- M base/task/sequence_manager/thread_controller_with_message_pump_impl_unittest.cc
- M base/task/thread_pool/delayed_priority_queue.cc
- M base/timer/timer_unittest.cc
- M base/trace_event/common/trace_event_common.h
- M base/trace_event/trace_event.h
- M base/trace_event/trace_event_impl.cc
- M base/trace_event/trace_log.cc
- M base/trace_event/tracing_agent.h
Change size: M
Delta: 30 files changed, 86 insertions(+), 90 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages