iwa: Implement chromeos.isolatedWebApp.setShape [chromium/src : main]

[Edman Anjos (Gerrit)]

Attention needed from Rakina Zata Amni

Edman Anjos added 1 comment

File chromeos/ash/experiences/isolated_web_app/DEPS

Line 16, Patchset 15: "+content/test",

Rakina Zata Amni . resolved

You can't include the non-public version, can you move what you need to `content/public/test` instead?

Edman Anjos

Done in https://crrev.com/c/7679900, thanks

Open in Gerrit

Related details

Attention is currently required from:

• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie290a6f3b2e5585ab3149da798925033a7c39ffd

Gerrit-Change-Number: 7566876

Gerrit-PatchSet: 18

Gerrit-Owner: Edman Anjos <ed...@chromium.org>

Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Simon Hangl <sim...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: James Su <su...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Paulina Gacek <paulin...@google.com>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Mar 2026 16:26:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rakina Zata Amni <rak...@chromium.org>

[Rakina Zata Amni (Gerrit)]

Attention needed from Edman Anjos

Rakina Zata Amni voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Edman Anjos

Gerrit-Attention: Edman Anjos <ed...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Mar 2026 01:58:46 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Rakina Zata Amni (Gerrit)]

Attention needed from Edman Anjos

Rakina Zata Amni voted

Code-Review	+1
Commit-Queue	+1

Gerrit-Comment-Date: Fri, 20 Mar 2026 01:58:58 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Edman Anjos (Gerrit)]

Edman Anjos voted and added 1 comment

Votes added by Edman Anjos

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 18 (Latest):

Edman Anjos . resolved

Thank you Rakina!

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Fri, 20 Mar 2026 09:44:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

iwa: Implement chromeos.isolatedWebApp.setShape

This implements the setShape blink extension for IWAs in CrOS. Currently
the API is disabled by default, future CLs will introduce an allowlist
of IWAs for which the API is enabled in CrOS.

Enable the API locally with this line in /etc/chrome_dev.conf:
--enable-blink-features=BlinkExtensionChromeOS,BlinkExtensionChromeOSIsolatedWebAppSetShape

Fixed: 480146201

Test: fd test chromeos/ash/experiences/isolated_web_app | xargs testing/xvfb.py tools/autotest.py -C out_/Default

Test: testing/xvfb.py tools/autotest.py -C out_/Default chrome/browser/ash/isolated_web_app/blink_extensions_browsertest.cc

Change-Id: Ie290a6f3b2e5585ab3149da798925033a7c39ffd

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7566876

Commit-Queue: Edman Anjos <ed...@chromium.org>

Reviewed-by: Hidehiko Abe <hide...@chromium.org>

Reviewed-by: Rakina Zata Amni <rak...@chromium.org>

Reviewed-by: Simon Hangl <sim...@google.com>

Cr-Commit-Position: refs/heads/main@{#1602512}

Files:

• M chrome/browser/ash/isolated_web_app/blink_extensions_browsertest.cc
• M chrome/test/BUILD.gn
• M chromeos/ash/experiences/isolated_web_app/BUILD.gn
• M chromeos/ash/experiences/isolated_web_app/DEPS
• M chromeos/ash/experiences/isolated_web_app/isolated_web_app_api_bridge_impl.cc
• M chromeos/ash/experiences/isolated_web_app/isolated_web_app_api_bridge_impl.h
• A chromeos/ash/experiences/isolated_web_app/isolated_web_app_api_bridge_impl_unittest.cc
• A chromeos/ash/experiences/isolated_web_app/shaped_window_targeter.cc
• A chromeos/ash/experiences/isolated_web_app/shaped_window_targeter.h
• A chromeos/ash/experiences/isolated_web_app/shaped_window_targeter_unittest.cc

Change size: L

Delta: 10 files changed, 552 insertions(+), 10 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Rakina Zata Amni, +1 by Hidehiko Abe, +1 by Simon Hangl

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ie290a6f3b2e5585ab3149da798925033a7c39ffd

Gerrit-Change-Number: 7566876

Gerrit-PatchSet: 19

Gerrit-Owner: Edman Anjos <ed...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Edman Anjos <ed...@chromium.org>

Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Simon Hangl <sim...@google.com>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>