[tracing] Fill typed fields in chrome metadata [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Apr 13, 2026, 5:08:44 PM (13 days ago) Apr 13
to Mikhail Khokhlov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Apr 14, 2026, 6:52:48 AM (12 days ago) Apr 14
to Etienne Pierre-Doray, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mikhail Khokhlov
| Code-Review | +1 |
1 comment
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 232, Patchset 7 (Latest):
packet->set_os_name(base::SysInfo::OperatingSystemName());Mikhail Khokhlov . unresolved
Should we use `components::metrics::GetOperatingSystemName` now?
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 14, 2026, 1:20:00 PM (12 days ago) Apr 14
to Chromium Metrics Reviews, Mikhail Khokhlov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Etienne Pierre-Doray . resolved
+chromium-metrics-reviews@ for components/metrics/
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 232, Patchset 7 (Latest):
packet->set_os_name(base::SysInfo::OperatingSystemName());Mikhail Khokhlov . resolved
Should we use `components::metrics::GetOperatingSystemName` now?
Etienne Pierre-Doray
No because we can't access components/metrics from here (hence the injection though TracingDelegate)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Apr 14, 2026, 1:20:55 PM (12 days ago) Apr 14
to Etienne Pierre-Doray, Chromium Metrics Reviews, Robert Kaplow, Mikhail Khokhlov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Robert Kaplow
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
rka...@chromium.org is from context(analysis/uma/chrome-metrics.gwsq)
Related details
Attention is currently required from:
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Apr 15, 2026, 5:08:53 AM (11 days ago) Apr 15
to Etienne Pierre-Doray, Chromium Metrics Reviews, Robert Kaplow, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Robert Kaplow
Mikhail Khokhlov added 1 comment![]( "Open in Gerrit")
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 232, Patchset 7 (Latest):
packet->set_os_name(base::SysInfo::OperatingSystemName());Mikhail Khokhlov . unresolved
Etienne Pierre-DorayShould we use `components::metrics::GetOperatingSystemName` now?
No because we can't access components/metrics from here (hence the injection though TracingDelegate)
Mikhail Khokhlov
Then we should retain the `#if BUILDFLAG(IS_CHROMEOS)`? IIUC, `base::SysInfo::OperatingSystemName()` returns 'Linux' on Chrome OS, hence the need for a special case.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 15, 2026, 7:15:27 AM (11 days ago) Apr 15
to Chromium Metrics Reviews, Robert Kaplow, Mikhail Khokhlov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov and Robert Kaplow
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 232, Patchset 7 (Latest):
packet->set_os_name(base::SysInfo::OperatingSystemName());Mikhail Khokhlov . unresolved
Etienne Pierre-DorayShould we use `components::metrics::GetOperatingSystemName` now?
Mikhail KhokhlovNo because we can't access components/metrics from here (hence the injection though TracingDelegate)
Then we should retain the `#if BUILDFLAG(IS_CHROMEOS)`? IIUC, `base::SysInfo::OperatingSystemName()` returns 'Linux' on Chrome OS, hence the need for a special case.
Etienne Pierre-Doray
This is only for content (e.g. when tracing unittests), while a chrome trace will get its values in components/tracing/common/system_profile_metadata_recorder.cc.
For simplicity I figured it doesn't really matter here (and we could also remove this entirely really).
There is a unittest in content that checks this, but it still relies on ChromeEventBundle, because the os-name from ChromeMetadataPacket doesn't get translated in json.
Related details
Attention is currently required from:
- Mikhail Khokhlov
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Apr 15, 2026, 7:43:56 AM (11 days ago) Apr 15
to Etienne Pierre-Doray, Chromium Metrics Reviews, Robert Kaplow, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Robert Kaplow
Mikhail Khokhlov added 1 comment![]( "Open in Gerrit")
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 232, Patchset 7 (Latest):
packet->set_os_name(base::SysInfo::OperatingSystemName());Mikhail Khokhlov . unresolved
Etienne Pierre-DorayShould we use `components::metrics::GetOperatingSystemName` now?
Mikhail KhokhlovNo because we can't access components/metrics from here (hence the injection though TracingDelegate)
Etienne Pierre-DorayThen we should retain the `#if BUILDFLAG(IS_CHROMEOS)`? IIUC, `base::SysInfo::OperatingSystemName()` returns 'Linux' on Chrome OS, hence the need for a special case.
This is only for content (e.g. when tracing unittests), while a chrome trace will get its values in components/tracing/common/system_profile_metadata_recorder.cc.
For simplicity I figured it doesn't really matter here (and we could also remove this entirely really).There is a unittest in content that checks this, but it still relies on ChromeEventBundle, because the os-name from ChromeMetadataPacket doesn't get translated in json.
Mikhail Khokhlov
Ah I see. Then I'd vote for removing this, to reduce potential confusion when reading code.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Kaplow (Gerrit)
Apr 15, 2026, 9:19:51 AM (11 days ago) Apr 15
to Etienne Pierre-Doray, Chromium Metrics Reviews, Mikhail Khokhlov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Robert Kaplow voted and added 1 comment![]( "Open in Gerrit")
Votes added by Robert Kaplow
| Code-Review | +1 |
1 comment
Patchset-level comments
Robert Kaplow . resolved
metrics changes lg
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 15, 2026, 3:20:40 PM (11 days ago) Apr 15
to Dave Tapuska, Nate Fischer, Robert Kaplow, Chromium Metrics Reviews, Mikhail Khokhlov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska and Nate Fischer
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Etienne Pierre-Doray . resolved
+dtapuska@ for content/public
+ntfschr@ for a_w/browser
File services/tracing/public/cpp/perfetto/metadata_data_source.cc
Line 232, Patchset 7:
packet->set_os_name(base::SysInfo::OperatingSystemName());Mikhail Khokhlov . resolved
Etienne Pierre-DorayShould we use `components::metrics::GetOperatingSystemName` now?
Mikhail KhokhlovNo because we can't access components/metrics from here (hence the injection though TracingDelegate)
Etienne Pierre-DorayThen we should retain the `#if BUILDFLAG(IS_CHROMEOS)`? IIUC, `base::SysInfo::OperatingSystemName()` returns 'Linux' on Chrome OS, hence the need for a special case.
Mikhail KhokhlovThis is only for content (e.g. when tracing unittests), while a chrome trace will get its values in components/tracing/common/system_profile_metadata_recorder.cc.
For simplicity I figured it doesn't really matter here (and we could also remove this entirely really).There is a unittest in content that checks this, but it still relies on ChromeEventBundle, because the os-name from ChromeMetadataPacket doesn't get translated in json.
Ah I see. Then I'd vote for removing this, to reduce potential confusion when reading code.
Attention is currently required from:
- Dave Tapuska
- Nate Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Apr 15, 2026, 3:30:50 PM (11 days ago) Apr 15
to Etienne Pierre-Doray, Nate Fischer, Robert Kaplow, Chromium Metrics Reviews, Mikhail Khokhlov, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Nate Fischer
Dave Tapuska voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Nate Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Fischer (Gerrit)
Apr 15, 2026, 7:17:26 PM (11 days ago) Apr 15
to Etienne Pierre-Doray, Dave Tapuska, Robert Kaplow, Chromium Metrics Reviews, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Nate Fischer voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Apr 16, 2026, 1:26:58 PM (10 days ago) Apr 16
to Nate Fischer, Dave Tapuska, Robert Kaplow, Chromium Metrics Reviews, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 16, 2026, 1:32:46 PM (10 days ago) Apr 16
to Etienne Pierre-Doray, Nate Fischer, Dave Tapuska, Robert Kaplow, Chromium Metrics Reviews, Mikhail Khokhlov, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Fill typed fields in chrome metadata
This CL fills a few typed fields in ChromeMetadataPack that we added in
https://github.com/google/perfetto/commit/fe9b2f932a1cf9d104e6b49ee3acbf173997062c
Bug: b/432275929
Change-Id: I5ab8251de147d6126d2b2e2ea869d17496ae9beb
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Reviewed-by: Nate Fischer <ntf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1615992}
Files:
- M android_webview/browser/tracing/aw_tracing_delegate.cc
- M android_webview/browser/tracing/aw_tracing_delegate.h
- M chrome/browser/tracing/chrome_tracing_delegate.cc
- M chrome/browser/tracing/chrome_tracing_delegate.h
- M components/metrics/metrics_log.cc
- M components/metrics/version_utils.cc
- M components/metrics/version_utils.h
- M components/tracing/common/system_profile_metadata_recorder.cc
- M components/tracing/common/system_profile_metadata_recorder.h
- M content/browser/tracing/tracing_controller_impl.cc
- M content/public/browser/tracing_delegate.cc
- M content/public/browser/tracing_delegate.h
- M services/tracing/public/cpp/perfetto/metadata_data_source.cc
- M services/tracing/public/cpp/perfetto/metadata_data_source.h
Change size: M
Delta: 14 files changed, 113 insertions(+), 61 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dave Tapuska, +1 by Robert Kaplow, +1 by Mikhail Khokhlov, +1 by Nate Fischer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fuhsin Liao (Gerrit)
Apr 17, 2026, 12:28:10 AM (10 days ago) Apr 17
to Chromium LUCI CQ, Etienne Pierre-Doray, Nate Fischer, Dave Tapuska, Robert Kaplow, Chromium Metrics Reviews, Mikhail Khokhlov, chromium...@chromium.org, android-web...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Fuhsin Liao has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages