Deduplicate mojom includes (non-blink) [chromium/src : main]

0 views
Skip to first unread message

Alex Gough (Gerrit)

unread,
Jan 2, 2026, 9:16:31 PM (9 days ago) Jan 2
to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Alex Gough added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Alex Gough . resolved

ptal - this mainly removes duplicate includes and tidies some data-view includes which should be less likely to come back with the include-what-you-use changes - canhaz oo+1

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e73bd05da18cf8cb18d3ea07d587ba7c06a3a5d
Gerrit-Change-Number: 7382324
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Gough <aj...@chromium.org>
Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Sat, 03 Jan 2026 02:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Gough (Gerrit)

unread,
Jan 2, 2026, 9:18:02 PM (9 days ago) Jan 2
to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Daniel Cheng

Alex Gough added 2 comments

File content/browser/renderer_host/render_process_host_impl.h
File device/vr/openxr/openxr_hand_utils.h
Line 8, Patchset 5 (Latest):#include "device/vr/public/mojom/xr_hand_tracking_data.mojom.h"
Alex Gough . resolved

this needs the complete types.

Gerrit-Comment-Date: Sat, 03 Jan 2026 02:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 5, 2026, 3:08:56 PM (6 days ago) Jan 5
to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Alex Gough

Daniel Cheng voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Gerrit-Attention: Alex Gough <aj...@chromium.org>
Gerrit-Comment-Date: Mon, 05 Jan 2026 20:08:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 5, 2026, 3:09:07 PM (6 days ago) Jan 5
to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Alex Gough

Daniel Cheng voted Code-Review+0

Code-Review+0
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Gerrit-Comment-Date: Mon, 05 Jan 2026 20:08:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Jan 5, 2026, 3:09:22 PM (6 days ago) Jan 5
    to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Alex Gough

    Daniel Cheng voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Gough
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Gerrit-Comment-Date: Mon, 05 Jan 2026 20:09:12 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Alex Gough (Gerrit)

      unread,
      Jan 6, 2026, 12:12:18 AM (6 days ago) Jan 6
      to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Daniel Cheng

      Alex Gough added 1 comment

      Patchset-level comments
      File-level comment, Patchset 8 (Latest):
      Alex Gough . resolved

      I am bad at rebasing but I think I got it right by ps8

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4e73bd05da18cf8cb18d3ea07d587ba7c06a3a5d
      Gerrit-Change-Number: 7382324
      Gerrit-PatchSet: 8
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Tue, 06 Jan 2026 05:12:08 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jan 6, 2026, 1:38:37 AM (6 days ago) Jan 6
      to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Alex Gough

      Daniel Cheng voted

      Code-Review+1
      Commit-Queue+2
      Owners-Override+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex Gough
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Gerrit-Attention: Alex Gough <aj...@chromium.org>
      Gerrit-Comment-Date: Tue, 06 Jan 2026 06:38:27 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Yoshisato Yanagisawa (Gerrit)

      unread,
      Jan 6, 2026, 2:09:24 AM (6 days ago) Jan 6
      to Alex Gough, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Alex Gough and Daniel Cheng

      Yoshisato Yanagisawa voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex Gough
      • Daniel Cheng
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4e73bd05da18cf8cb18d3ea07d587ba7c06a3a5d
        Gerrit-Change-Number: 7382324
        Gerrit-PatchSet: 8
        Gerrit-Owner: Alex Gough <aj...@chromium.org>
        Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
        Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
        Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
        Gerrit-CC: James Maclean <wjma...@chromium.org>
        Gerrit-CC: Jiewei Qian <q...@chromium.org>
        Gerrit-CC: Kaan Icer <ic...@chromium.org>
        Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Kevin McNee <mc...@chromium.org>
        Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
        Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
        Gerrit-CC: Simon Hangl <sim...@google.com>
        Gerrit-CC: Wang, Wei4 <wei4...@intel.com>
        Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Attention: Alex Gough <aj...@chromium.org>
        Gerrit-Comment-Date: Tue, 06 Jan 2026 07:08:53 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Daniel Cheng (Gerrit)

        unread,
        Jan 6, 2026, 2:14:18 AM (6 days ago) Jan 6
        to Alex Gough, Yoshisato Yanagisawa, Daniel Cheng, Chromium LUCI CQ, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org
        Attention needed from Alex Gough

        Daniel Cheng voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex Gough
        Gerrit-Attention: Alex Gough <aj...@chromium.org>
        Gerrit-Comment-Date: Tue, 06 Jan 2026 07:14:05 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jan 6, 2026, 3:19:05 AM (6 days ago) Jan 6
        to Alex Gough, Yoshisato Yanagisawa, Daniel Cheng, Akihiro Ota, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Kevin McNee, Hiroki Nakagawa, Nikhil Nayunigari, Hu, Ningxin, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, Wang, Wei4, James Maclean, aashna...@google.com, abigailbk...@google.com, ajayramamurt...@google.com, ajayramamurthy+w...@google.com, ajayramamurth...@google.com, ajayramamurthy...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, arc-review...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, boujan...@google.com, browser-comp...@chromium.org, byronle...@chromium.org, cambickel+watc...@google.com, cambickel+watch-shor...@google.com, cambickel...@google.com, cc-...@chromium.org, cfredri...@chromium.org, chadduffin+wa...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, chrome-gr...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-regionalc...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, chungshe...@google.com, creis...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, crostin...@chromium.org, csharris...@chromium.org, dclasson+w...@google.com, dennyh...@google.com, derinel+wat...@google.com, dewitt...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wat...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watch...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, fenced-fra...@chromium.org, ffred...@chromium.org, fgorsk...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gavin...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+wa...@chromium.org, hansberry+wat...@chromium.org, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hidehik...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, hsuregan+wat...@chromium.org, hsuregan+wa...@chromium.org, jackshira+wa...@google.com, jackshira+...@google.com, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jatapiaro+wat...@google.com, jiajunz+wat...@google.com, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jimmyxgong+w...@chromium.org, jimmyxgong+watch-shor...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, joeantonetti+...@google.com, jonmann+w...@chromium.org, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kenok...@google.com, khorimoto+wa...@chromium.org, khorimoto+w...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kmg+...@google.com, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lens-chrome...@google.com, loading-rev...@chromium.org, longbowei+watc...@google.com, longbowei+watch-shor...@google.com, loyso...@chromium.org, lucasrada...@google.com, lwinston+watc...@google.com, mac-r...@chromium.org, marimatthew+watc...@google.com, menghua...@google.com, mercer...@google.com, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, michaelcheco+wa...@google.com, michaelcheco+watch-i...@google.com, michaelcheco+...@google.com, michaelchec...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nikhilcn+wat...@google.com, npm+...@chromium.org, nwoked...@chromium.org, oshima...@chromium.org, pdf-r...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, pushi+watc...@google.com, rginda...@chromium.org, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, servicewor...@chromium.org, shimazu+se...@chromium.org, sky+...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, stanfie...@google.com, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, tluk+...@chromium.org, tracing...@chromium.org, trewin...@google.com, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, wangdanny+watch-in...@google.com, webap...@microsoft.com, webauthn...@chromium.org, weiluanw...@google.com, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yhanada+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, yyhyyh+watch-inpu...@google.com, zackha...@chromium.org, zelin+watch-we...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Deduplicate mojom includes (non-blink)

        Deduplicates multiple mojom includes and rewrite some -data-view.h
        includes to -shared.h includes as this is the preferred import.

        Skips blink & any files with a DataView class in them, and all /traits/
        files as these are likely to be including data-view.h correctly.

        Dedupes:

        (data-view & mojom) -> mojom
        (data-view & shared) -> shared
        (data-view) -> shared
        (forward & mojom) -> mojom
        (forward & shared) -> shared
        (shared & mojom) -> mojom

        See ps1 for initial script generated changes[0], and ps2+ for fixups.

        [0] https://user.git.corp.google.com/ajgo/bin/+/refs/heads/main/mass-mojom.py --root . --force
        Bug: 469801419
        X-Relnotes: n/a
        Change-Id: I4e73bd05da18cf8cb18d3ea07d587ba7c06a3a5d
        Cq-Do-Not-Cancel-Tryjobs: true
        Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
        Commit-Queue: Daniel Cheng <dch...@chromium.org>
        Reviewed-by: Daniel Cheng <dch...@chromium.org>
        Owners-Override: Daniel Cheng <dch...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1564830}
        Files:
        • M android_webview/browser/permission/media_access_permission_request.cc
        • M android_webview/browser/permission/media_access_permission_request_unittest.cc
        • M ash/accelerators/ash_accelerator_configuration.cc
        • M ash/accelerators/ash_accelerator_configuration.h
        • M ash/events/peripheral_customization_event_rewriter_unittest.cc
        • M ash/public/cpp/capture_mode/capture_mode_delegate.h
        • M ash/system/bluetooth/bluetooth_detailed_view_impl_pixeltest.cc
        • M ash/system/diagnostics/diagnostics_log_controller_unittest.cc
        • M ash/system/eche/eche_tray.cc
        • M ash/system/eche/eche_tray.h
        • M ash/system/input_device_settings/input_device_notifier.cc
        • M ash/system/input_device_settings/input_device_settings_controller_impl.cc
        • M ash/system/input_device_settings/input_device_settings_controller_impl.h
        • M ash/system/input_device_settings/input_device_settings_controller_unittest.cc
        • M ash/system/input_device_settings/input_device_settings_metadata.cc
        • M ash/system/input_device_settings/input_device_settings_metadata.h
        • M ash/system/input_device_settings/input_device_settings_metrics_manager_unittest.cc
        • M ash/system/input_device_settings/input_device_settings_notification_controller_unittest.cc
        • M ash/system/input_device_settings/input_device_settings_utils.cc
        • M ash/system/input_device_settings/pref_handlers/graphics_tablet_pref_handler_unittest.cc
        • M ash/system/input_device_settings/pref_handlers/keyboard_pref_handler_impl.cc
        • M ash/system/input_device_settings/pref_handlers/keyboard_pref_handler_unittest.cc
        • M ash/system/input_device_settings/pref_handlers/mouse_pref_handler_impl.cc
        • M ash/system/input_device_settings/pref_handlers/pointing_stick_pref_handler_impl.cc
        • M ash/system/input_device_settings/pref_handlers/pointing_stick_pref_handler_unittest.cc
        • M ash/system/input_device_settings/pref_handlers/touchpad_pref_handler_impl.cc
        • M ash/system/input_device_settings/pref_handlers/touchpad_pref_handler_unittest.cc
        • M ash/system/network/network_list_view_controller_unittest.cc
        • M ash/system/video_conference/bubble/bubble_view_pixeltest.cc
        • M ash/system/video_conference/bubble/bubble_view_unittest.cc
        • M ash/system/video_conference/fake_video_conference_tray_controller.cc
        • M ash/system/video_conference/video_conference_tray_unittest.cc
        • M ash/webui/boca_receiver_app_ui/boca_receiver_untrusted_page_handler.cc
        • M ash/webui/boca_receiver_app_ui/boca_receiver_untrusted_page_handler_unittest.cc
        • M ash/webui/boca_ui/boca_app_page_handler.cc
        • M ash/webui/boca_ui/boca_app_page_handler.h
        • M ash/webui/boca_ui/boca_app_page_handler_unittest.cc
        • M ash/webui/diagnostics_ui/backend/input/input_data_provider_keyboard_unittest.cc
        • M ash/webui/diagnostics_ui/backend/system/system_data_provider_unittest.cc
        • M ash/webui/eche_app_ui/apps_launch_info_provider.h
        • M ash/webui/eche_app_ui/eche_tray_stream_status_observer.h
        • M ash/webui/graduation/graduation_ui_handler.cc
        • M ash/webui/graduation/graduation_ui_handler_unittest.cc
        • M ash/webui/personalization_app/search/search_handler_unittest.cc
        • M ash/webui/personalization_app/search/search_tag_registry.cc
        • M ash/webui/projector_app/projector_xhr_sender.cc
        • M ash/webui/projector_app/test/projector_xhr_sender_unittest.cc
        • M ash/webui/projector_app/untrusted_projector_page_handler_impl.cc
        • M ash/webui/shimless_rma/backend/shimless_rma_service_3p_diag_unittest.cc
        • M ash/webui/shimless_rma/backend/shimless_rma_service_unittest.cc
        • M ash/webui/shortcut_customization_ui/backend/accelerator_configuration_provider.cc
        • M ash/webui/shortcut_customization_ui/backend/accelerator_configuration_provider_unittest.cc
        • M ash/webui/shortcut_customization_ui/backend/accelerator_layout_table.cc
        • M ash/webui/shortcut_customization_ui/backend/search/fake_search_data.cc
        • M ash/webui/shortcut_customization_ui/backend/search/fake_search_data.h
        • M ash/webui/shortcut_customization_ui/backend/search/search_concept.cc
        • M ash/webui/shortcut_customization_ui/backend/search/search_concept_registry_unittest.cc
        • M ash/webui/shortcut_customization_ui/backend/search/search_handler.cc
        • M ash/webui/shortcut_customization_ui/shortcuts_app_manager_unittest.cc
        • M chrome/browser/accessibility/media_app/ax_media_app_untrusted_service_browsertest.cc
        • M chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc
        • M chrome/browser/ai/ai_language_model.cc
        • M chrome/browser/ai/ai_manager_unittest.cc
        • M chrome/browser/apps/app_service/intent_util.cc
        • M chrome/browser/ash/accessibility/live_caption/system_live_caption_service.cc
        • M chrome/browser/ash/accessibility/live_caption/system_live_caption_service.h
        • M chrome/browser/ash/app_list/search/keyboard_shortcut_result.cc
        • M chrome/browser/ash/app_list/search/ranking/filtering_ranker_unittest.cc
        • M chrome/browser/ash/app_list/search/system_info/system_info_card_provider.cc
        • M chrome/browser/ash/app_mode/kiosk_chrome_app_manager_browsertest.cc
        • M chrome/browser/ash/app_mode/test/kiosk_chrome_app_browsertest.cc
        • M chrome/browser/ash/app_mode/test/kiosk_iwa_permissions_browsertest.cc
        • M chrome/browser/ash/app_mode/web_app/kiosk_web_app_data.cc
        • M chrome/browser/ash/chromebox_for_meetings/artemis/data_aggregator_service.h
        • M chrome/browser/ash/chromebox_for_meetings/external_display_brightness/external_display_brightness_service.h
        • M chrome/browser/ash/chromebox_for_meetings/logger/cfm_logger_service.h
        • M chrome/browser/ash/chromebox_for_meetings/logger/cfm_logger_service_unittest.cc
        • M chrome/browser/ash/crosapi/document_scan_ash_unittest.cc
        • M chrome/browser/ash/crosapi/keystore_service_ash.h
        • M chrome/browser/ash/crosapi/local_printer_ash_unittest.cc
        • M chrome/browser/ash/drive/drive_integration_service.cc
        • M chrome/browser/ash/events/event_rewriter_unittest.cc
        • M chrome/browser/ash/extensions/file_manager/drivefs_event_router_unittest.cc
        • M chrome/browser/ash/file_manager/file_manager_browsertest_base.cc
        • M chrome/browser/ash/input_device_settings/peripherals_app_delegate_impl.h
        • M chrome/browser/ash/login/app_mode/network_ui_controller.cc
        • M chrome/browser/ash/login/oobe_quick_start/connectivity/connection.h
        • M chrome/browser/ash/login/oobe_quick_start/connectivity/connection_unittest.cc
        • M chrome/browser/ash/login/oobe_quick_start/connectivity/target_device_connection_broker.h
        • M chrome/browser/ash/login/screens/network_screen.cc
        • M chrome/browser/ash/login/screens/network_screen.h
        • M chrome/browser/ash/login/screens/osauth/apply_online_password_screen.cc
        • M chrome/browser/ash/login/screens/osauth/local_password_setup_screen.cc
        • M chrome/browser/ash/mahi/mahi_manager_impl_unittest.cc
        • M chrome/browser/ash/policy/dlp/dlp_content_manager_ash_browsertest.cc
        • M chrome/browser/ash/policy/reporting/metrics_reporting/metric_reporting_manager.cc
        • M chrome/browser/ash/preferences/preferences.cc
        • M chrome/browser/ash/secure_channel/nearby_connection_broker.h
        • M chrome/browser/ash/secure_channel/nearby_connection_broker_impl.h
        • M chrome/browser/ash/secure_channel/nearby_connection_broker_impl_unittest.cc
        • M chrome/browser/ash/secure_channel/nearby_connector_impl.h
        • M chrome/browser/ash/secure_channel/nearby_connector_impl_unittest.cc
        • M chrome/browser/ash/system_logs/connected_input_devices_log_source.cc
        • M chrome/browser/ash/system_logs/reven_log_source.cc
        • M chrome/browser/ash/system_logs/reven_log_source_unittest.cc
        • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_sea_pen_provider_base.cc
        • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_sea_pen_provider_impl_unittest.cc
        • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_theme_metrics_provider.cc
        • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_user_provider_impl.cc
        • M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_wallpaper_provider_impl_unittest.cc
        • M chrome/browser/ash/video_conference/video_conference_client_wrapper.cc
        • M chrome/browser/ash/wallpaper_handlers/sea_pen_fetcher.cc
        • M chrome/browser/chromeos/app_mode/kiosk_app_level_logs_manager.cc
        • M chrome/browser/chromeos/app_mode/kiosk_app_level_logs_saver.cc
        • M chrome/browser/chromeos/app_mode/kiosk_app_level_logs_saver.h
        • M chrome/browser/chromeos/app_mode/kiosk_app_level_logs_saver_unittest.cc
        • M chrome/browser/chromeos/app_mode/kiosk_app_windows_logs_collector_unittest.cc
        • M chrome/browser/chromeos/app_mode/kiosk_browser_logs_collector_unittest.cc
        • M chrome/browser/chromeos/app_mode/kiosk_service_workers_logs_collector.cc
        • M chrome/browser/chromeos/app_mode/kiosk_service_workers_logs_collector_unittest.cc
        • M chrome/browser/chromeos/app_mode/kiosk_web_contents_observer.h
        • M chrome/browser/chromeos/app_mode/kiosk_web_contents_observer_unittest.cc
        • M chrome/browser/chromeos/extensions/telemetry/api/diagnostics/fake_diagnostics_service.cc
        • M chrome/browser/chromeos/platform_keys/extension_platform_keys_service.cc
        • M chrome/browser/chromeos/printing/print_preview/print_settings_converter_unittest.cc
        • M chrome/browser/chromeos/video_conference/video_conference_web_app.cc
        • M chrome/browser/chromeos/video_conference/video_conference_web_app.h
        • M chrome/browser/controlled_frame/controlled_frame_media_access_handler.cc
        • M chrome/browser/download/chrome_download_manager_delegate.cc
        • M chrome/browser/enterprise/platform_auth/url_session_url_loader.mm
        • M chrome/browser/extensions/api/web_authentication_proxy/web_authentication_proxy_service.cc
        • M chrome/browser/glic/host/context/glic_sharing_manager_impl.cc
        • M chrome/browser/media/webrtc/desktop_capture_access_handler.cc
        • M chrome/browser/media/webrtc/desktop_capture_access_handler_unittest.cc
        • M chrome/browser/media/webrtc/display_media_access_handler.cc
        • M chrome/browser/media/webrtc/display_media_access_handler_unittest.cc
        • M chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
        • M chrome/browser/media/webrtc/media_stream_capture_indicator_unittest.cc
        • M chrome/browser/media/webrtc/permission_bubble_media_access_handler.h
        • M chrome/browser/media/webrtc/tab_capture_access_handler.cc
        • M chrome/browser/media/webrtc/tab_capture_access_handler_unittest.cc
        • M chrome/browser/memory_details.h
        • M chrome/browser/metrics/process_memory_metrics_emitter.h
        • M chrome/browser/nearby_sharing/contacts/nearby_share_contact_manager_impl.cc
        • M chrome/browser/nearby_sharing/nearby_share_metrics.h
        • M chrome/browser/nearby_sharing/nearby_sharing_service_impl.h
        • M chrome/browser/nearby_sharing/nearby_sharing_service_impl_unittest.cc
        • M chrome/browser/nearby_sharing/webrtc_request_builder_unittest.cc
        • M chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
        • M chrome/browser/safe_browsing/client_side_detection_intelligent_scan_delegate_desktop.cc
        • M chrome/browser/safe_browsing/client_side_detection_intelligent_scan_delegate_desktop.h
        • M chrome/browser/safe_browsing/client_side_detection_intelligent_scan_delegate_desktop_unittest.cc
        • M chrome/browser/speech/cros_speech_recognition_service.cc
        • M chrome/browser/storage_access_api/api_browsertest.cc
        • M chrome/browser/ui/android/webid/account_selection_view_android.cc
        • M chrome/browser/ui/ash/system/system_tray_client_impl.cc
        • M chrome/browser/ui/lens/lens_overlay_controller_browsertest.cc
        • M chrome/browser/ui/lens/lens_overlay_gen204_controller_unittest.cc
        • M chrome/browser/ui/lens/lens_overlay_proto_converter.cc
        • M chrome/browser/ui/lens/lens_overlay_proto_converter_unittest.cc
        • M chrome/browser/ui/lens/lens_overlay_query_controller.cc
        • M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
        • M chrome/browser/ui/views/bookmarks/saved_tab_groups/saved_tab_group_bar.cc
        • M chrome/browser/ui/views/bookmarks/saved_tab_groups/saved_tab_group_button.cc
        • M chrome/browser/ui/views/extensions/extensions_toolbar_container.cc
        • M chrome/browser/ui/views/frame/browser_frame_view_mac.mm
        • M chrome/browser/ui/views/supervised_user/parent_permission_dialog_view.cc
        • M chrome/browser/ui/views/tabs/tab_group_header.cc
        • M chrome/browser/ui/views/toolbar/pinned_toolbar_actions_container.cc
        • M chrome/browser/ui/views/toolbar/pinned_toolbar_actions_container_unittest.cc
        • M chrome/browser/ui/views/webid/fedcm_account_selection_view_desktop.cc
        • M chrome/browser/ui/webui/app_service_internals/app_service_internals_page_handler_impl.cc
        • M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_page_handler.h
        • M chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_ui.h
        • M chrome/browser/ui/webui/ash/office_fallback/office_fallback_page_handler.h
        • M chrome/browser/ui/webui/ash/office_fallback/office_fallback_ui.h
        • M chrome/browser/ui/webui/ash/settings/pages/device/input_device_settings/input_device_settings_provider_unittest.cc
        • M chrome/browser/ui/webui/ash/skyvault/local_files_migration_page_handler.cc
        • M chrome/browser/ui/webui/ash/skyvault/local_files_migration_ui.h
        • M chrome/browser/ui/webui/certificate_manager/client_cert_sources.cc
        • M chrome/browser/ui/webui/new_tab_page/ntp_promo/ntp_promo_handler_unittest.cc
        • M chrome/browser/ui/webui/password_manager/password_manager_ui_handler.cc
        • M chrome/browser/ui/webui/password_manager/password_manager_ui_handler.h
        • M chrome/browser/ui/webui/search_engine_choice/search_engine_choice_handler.h
        • M chrome/browser/ui/webui/side_panel/read_anything/read_anything_untrusted_page_handler.cc
        • M chrome/browser/web_applications/commands/fetch_manifest_and_install_command_unittest.cc
        • M chrome/browser/web_applications/commands/install_from_sync_command_unittest.cc
        • M chrome/browser/web_applications/commands/manifest_silent_update_command_unittest.cc
        • M chrome/browser/web_applications/externally_managed_app_manager_unittest.cc
        • M chrome/browser/web_applications/isolated_web_apps/borderless_browsertest.cc
        • M chrome/browser/web_applications/isolated_web_apps/test/isolated_web_app_builder.cc
        • M chrome/browser/web_applications/isolated_web_apps/test/isolated_web_app_builder.h
        • M chrome/browser/web_applications/jobs/manifest_to_web_app_install_info_job.cc
        • M chrome/browser/web_applications/jobs/manifest_to_web_app_install_info_job_unittest.cc
        • M chrome/browser/web_applications/test/fake_web_contents_manager.cc
        • M chrome/browser/web_applications/test/web_app_test_utils.cc
        • M chrome/browser/web_applications/web_app.cc
        • M chrome/browser/web_applications/web_app_database_unittest.cc
        • M chrome/browser/web_applications/web_app_install_finalizer_unittest.cc
        • M chrome/browser/web_applications/web_app_install_info.h
        • M chrome/browser/web_applications/web_app_registrar.cc
        • M chrome/browser/web_applications/web_app_sync_bridge_unittest.cc
        • M chrome/browser/web_applications/web_app_utils.cc
        • M chrome/browser/web_applications/web_contents/web_app_data_retriever.cc
        • M chrome/browser/webid/federated_identity_identity_provider_signin_status_context.cc
        • M chrome/renderer/accessibility/read_anything/read_anything_app_controller_browsertest.cc
        • M chrome/services/sharing/nearby/quick_start_decoder/quick_start_decoder_unittest.cc
        • M chromecast/browser/cast_web_view_default.cc
        • M chromeos/ash/components/boca/babelorca/tachyon_streaming_client.cc
        • M chromeos/ash/components/boca/babelorca/tachyon_streaming_client.h
        • M chromeos/ash/components/boca/babelorca/tachyon_streaming_client_unittest.cc
        • M chromeos/ash/components/boca/boca_session_manager.cc
        • M chromeos/ash/components/drivefs/drivefs_http_client_unittest.cc
        • M chromeos/ash/components/drivefs/fake_drivefs.cc
        • M chromeos/ash/components/memory/userspace_swap/userspace_swap.cc
        • M chromeos/ash/components/phonehub/phone_hub_structured_metrics_logger.h
        • M chromeos/ash/components/quick_start/fake_quick_start_decoder.cc
        • M chromeos/ash/components/telemetry_extension/events/telemetry_event_service_ash.cc
        • M chromeos/ash/components/telemetry_extension/telemetry/probe_service_converters.h
        • M chromeos/ash/experiences/arc/net/arc_net_utils.cc
        • M chromeos/ash/experiences/arc/system_ui/arc_system_ui_bridge.h
        • M chromeos/ash/experiences/arc/test/fake_memory_instance.cc
        • M chromeos/ash/experiences/arc/test/fake_system_ui_instance.h
        • M chromeos/ash/services/boca/babelorca/cpp/tachyon_parsing_service.cc
        • M chromeos/ash/services/boca/babelorca/cpp/tachyon_parsing_service.h
        • M chromeos/ash/services/boca/babelorca/cpp/tachyon_parsing_service_unittest.cc
        • M chromeos/ash/services/cellular_setup/esim_profile.cc
        • M chromeos/ash/services/network_config/cros_network_config.cc
        • M chromeos/ash/services/network_config/cros_network_config_unittest.cc
        • M chromeos/ash/services/quick_pair/quick_pair_process_manager.h
        • M chromeos/ash/services/secure_channel/client_connection_parameters.h
        • M chromeos/ash/services/secure_channel/client_connection_parameters_impl.h
        • M chromeos/ash/services/secure_channel/fake_client_connection_parameters.h
        • M chromeos/ash/services/secure_channel/fake_nearby_connection_state_listener.h
        • M chromeos/ash/services/secure_channel/nearby_connection.h
        • M chromeos/ash/services/secure_channel/nearby_connection_manager.h
        • M chromeos/ash/services/secure_channel/nearby_connection_manager_impl.cc
        • M chromeos/ash/services/secure_channel/pending_connection_request_base.h
        • M chromeos/ash/services/secure_channel/pending_nearby_initiator_connection_request.cc
        • M chromeos/ash/services/secure_channel/public/cpp/client/client_channel_impl_unittest.cc
        • M chromeos/ash/services/secure_channel/public/cpp/client/connection_manager_impl.cc
        • M components/autofill/content/renderer/form_tracker.cc
        • M components/autofill/content/renderer/form_tracker.h
        • M components/autofill/content/renderer/password_autofill_agent.cc
        • M components/autofill/content/renderer/password_autofill_agent.h
        • M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_manager.cc
        • M components/autofill/core/browser/filling/autofill_ai/field_filling_entity_util_unittest.cc
        • M components/autofill/core/browser/filling/form_filler_unittest.cc
        • M components/autofill/core/browser/form_structure_unittest.cc
        • M components/autofill/core/browser/foundations/autofill_manager.h
        • M components/browsing_topics/browsing_topics_service.h
        • M components/content_settings/core/common/cookie_settings_base.cc
        • M components/exo/wm_helper_unittest.cc
        • M components/heap_profiling/multi_process/supervisor.cc
        • M components/history_embeddings/ml_answerer.cc
        • M components/history_embeddings/ml_intent_classifier.cc
        • M components/js_injection/renderer/js_communication.cc
        • M components/media_effects/test/fake_video_source.cc
        • M components/offline_pages/content/background_loader/background_loader_contents.cc
        • M components/offline_pages/content/background_loader/background_loader_contents_unittest.cc
        • M components/optimization_guide/core/model_execution/model_broker_client.cc
        • M components/optimization_guide/core/model_execution/model_broker_client.h
        • M components/optimization_guide/core/model_execution/on_device_capability.h
        • M components/optimization_guide/core/model_execution/on_device_model_adaptation_controller.cc
        • M components/optimization_guide/core/model_execution/on_device_model_service_controller_unittest.cc
        • M components/optimization_guide/core/optimization_guide_proto_util.cc
        • M components/page_image_service/image_service_impl_unittest.cc
        • M components/page_load_metrics/browser/observers/ad_metrics/ads_page_load_metrics_observer.cc
        • M components/paint_preview/browser/paint_preview_client_unittest.cc
        • M components/paint_preview/renderer/paint_preview_recorder_browsertest.cc
        • M components/pdf/renderer/pdf_accessibility_tree.cc
        • M components/pdf/renderer/pdf_accessibility_tree_builder_structure.h
        • M components/plus_addresses/core/browser/plus_address_service_impl_unittest.cc
        • M components/remote_cocoa/app_shim/native_widget_ns_window_bridge.h
        • M components/safe_browsing/content/browser/client_side_detection_host.cc
        • M components/safe_browsing/content/browser/client_side_detection_host.h
        • M components/safe_browsing/content/renderer/phishing_classifier/phishing_classifier_delegate.cc
        • M components/unexportable_keys/mojom/unexportable_key_service_proxy_impl.cc
        • M components/user_education/webui/help_bubble_handler.cc
        • M components/viz/service/frame_sinks/frame_sink_bundle_impl_unittest.cc
        • M components/webapps/browser/installable/ml_installability_promoter.cc
        • M content/browser/accessibility/browser_accessibility_android_unittest.cc
        • M content/browser/ai/echo_ai_manager_impl.cc
        • M content/browser/browser_interface_binders.cc
        • M content/browser/devtools/devtools_url_loader_interceptor.cc
        • M content/browser/devtools/protocol/emulation_handler.cc
        • M content/browser/devtools/protocol/emulation_handler.h
        • M content/browser/devtools/protocol/tracing_handler.cc
        • M content/browser/file_system_access/file_system_access_manager_impl_unittest.cc
        • M content/browser/indexed_db/indexed_db_context_impl.cc
        • M content/browser/indexed_db/indexed_db_internals_ui.cc
        • M content/browser/indexed_db/instance/bucket_context_unittest.cc
        • M content/browser/indexed_db/instance/connection.cc
        • M content/browser/indexed_db/instance/sqlite/database_connection_unittest.cc
        • M content/browser/interest_group/auction_downloader_delegate.cc
        • M content/browser/interest_group/auction_worklet_manager.cc
        • M content/browser/interest_group/interest_group_auction.cc
        • M content/browser/interest_group/interest_group_auction_reporter_unittest.cc
        • M content/browser/interest_group/mock_auction_process_manager.cc
        • M content/browser/manifest/manifest_manager_host.cc
        • M content/browser/navigation_browsertest.cc
        • M content/browser/permissions/permission_overrides_unittest.cc
        • M content/browser/permissions/permission_service_impl.cc
        • M content/browser/preloading/anchor_element_interaction_host_impl.cc
        • M content/browser/preloading/anchor_element_interaction_host_impl_unittest.cc
        • M content/browser/preloading/preloading_decider.cc
        • M content/browser/preloading/preloading_decider_unittest.cc
        • M content/browser/renderer_host/ancestor_throttle.cc
        • M content/browser/renderer_host/code_cache_host_impl.cc
        • M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
        • M content/browser/renderer_host/navigation_request.cc
        • M content/browser/renderer_host/render_frame_host_delegate.cc
        • M content/browser/renderer_host/render_frame_host_impl_browsertest.cc
        • M content/browser/service_worker/service_worker_main_resource_loader.cc
        • M content/browser/sms/webotp_service_unittest.cc
        • M content/browser/tracing/memory_tracing_browsertest.cc
        • M content/browser/web_contents/web_contents_impl.cc
        • M content/browser/webid/accounts_fetcher.cc
        • M content/browser/xr/webxr_internals/webxr_logger_manager.h
        • M content/public/browser/webauthn_security_utils.h
        • M content/renderer/service_worker/service_worker_context_client.h
        • M content/renderer/service_worker/service_worker_provider_context.h
        • M content/renderer/service_worker/service_worker_subresource_loader.cc
        • M content/services/auction_worklet/public/cpp/auction_downloader.cc
        • M content/services/auction_worklet/public/cpp/auction_downloader_unittest.cc
        • M device/fido/ctap_get_assertion_request.h
        • M device/fido/ctap_make_credential_request.h
        • M device/fido/win/type_conversions.h
        • M device/vr/openxr/openxr_hand_utils.h
        • M device/vr/openxr/openxr_visibility_mask_handler.h
        • M extensions/browser/browser_frame_context_data.cc
        • M extensions/browser/guest_view/web_view/web_view_permission_helper.cc
        • M extensions/browser/media_capture_util.cc
        • M ipc/ipc_channel.h
        • M media/capture/video/video_capture_device_client.cc
        • M mojo/public/cpp/bindings/tests/enum_default_unittest.cc
        • M mojo/public/cpp/bindings/tests/feature_unittest.cc
        • M mojo/public/cpp/bindings/tests/nullable_value_types_unittest.cc
        • M pdf/DEPS
        • M pdf/pdf_accessibility_constants_helper.h
        • M remoting/host/desktop_session_agent.cc
        • M services/accessibility/android/accessibility_node_info_data_wrapper.cc
        • M services/accessibility/android/accessibility_node_info_data_wrapper_unittest.cc
        • M services/device/compute_pressure/pressure_manager_impl_unittest.cc
        • M services/media_session/media_controller.cc
        • M services/metrics/public/cpp/mojo_ukm_recorder.cc
        • M services/network/first_party_sets/first_party_sets_access_delegate.h
        • M services/network/host_resolver.cc
        • M services/network/network_context.h
        • M services/network/private_network_access_checker.cc
        • M services/network/private_network_access_checker.h
        • M services/network/private_network_access_checker_unittest.cc
        • M services/network/public/cpp/devtools_observer_unittest.cc
        • M services/network/shared_dictionary/shared_dictionary_storage.cc
        • M services/network/trust_tokens/trust_token_key_filtering_unittest.cc
        • M services/network/url_loader.cc
        • M services/network/url_loader.h
        • M services/network/url_loader_unittest.cc
        • M services/network/web_transport.cc
        • M services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
        • M services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
        • M services/resource_coordinator/memory_instrumentation/queued_request.h
        • M services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
        • M services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
        • M services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
        • M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
        • M services/webnn/tflite/graph_builder_tflite.h
        • M services/webnn/webnn_graph_impl_unittest.cc
        • M storage/browser/file_system/file_system_context.cc
        • M storage/browser/quota/quota_manager_impl.cc
        • M storage/browser/quota/quota_manager_impl.h
        • M ui/accessibility/ax_action_data.h
        • M ui/accessibility/ax_enum_util.cc
        • M ui/accessibility/ax_node.cc
        • M ui/accessibility/ax_node_data.cc
        • M ui/accessibility/ax_node_unittest.cc
        • M ui/accessibility/ax_table_info.cc
        • M ui/accessibility/platform/ax_platform_node_base.cc
        • M ui/events/ash/keyboard_capability_unittest.cc
        • M ui/events/ash/keyboard_modifier_event_rewriter.h
        • M ui/views/controls/menu/menu_controller_unittest.cc
        • M ui/views/widget/desktop_aura/desktop_drag_drop_client_ozone.cc
        Change size: L
        Delta: 382 files changed, 71 insertions(+), 435 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Yoshisato Yanagisawa, +1 by Daniel Cheng
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4e73bd05da18cf8cb18d3ea07d587ba7c06a3a5d
        Gerrit-Change-Number: 7382324
        Gerrit-PatchSet: 9
        Gerrit-Owner: Alex Gough <aj...@chromium.org>
        Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Andrew Rayskiy <green...@google.com>
        Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
        Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages