Use modern names for base::DictValue and base::ListValue [chromium/src : main]

0 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
Jan 23, 2026, 12:20:22 PMJan 23
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, bartek...@chromium.org, chromiumme...@microsoft.com, fuzzin...@chromium.org, lizeb...@chromium.org, scheduler...@chromium.org, security-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Avi Drissman . resolved

dcheng: please review; this is strictly mechanical except where noted, so OO-ing is appropriate.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I77b4468667b668db3ffc05aaea67bb44c8f65c5b
Gerrit-Change-Number: 7511733
Gerrit-PatchSet: 3
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Jan 2026 17:20:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 23, 2026, 1:21:51 PMJan 23
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, bartek...@chromium.org, chromiumme...@microsoft.com, fuzzin...@chromium.org, lizeb...@chromium.org, scheduler...@chromium.org, security-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1
Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
Daniel Cheng . resolved

Patched this in and ran it through my diffreducer. Stamped based on that!

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I77b4468667b668db3ffc05aaea67bb44c8f65c5b
Gerrit-Change-Number: 7511733
Gerrit-PatchSet: 3
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Jan 2026 18:21:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 23, 2026, 1:28:59 PMJan 23
to Avi Drissman, Daniel Cheng, chromium...@chromium.org, asvitki...@chromium.org, bartek...@chromium.org, chromiumme...@microsoft.com, fuzzin...@chromium.org, lizeb...@chromium.org, scheduler...@chromium.org, security-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Use modern names for base::DictValue and base::ListValue

These classes were hoisted and renamed; switch all usage of these
classes to use the new names.

This is a strictly mechanical change, except for the comments in
base/values.h.
Bug: 478100525
Change-Id: I77b4468667b668db3ffc05aaea67bb44c8f65c5b
Auto-Submit: Avi Drissman <a...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1573795}
Files:
  • M base/allocator/scheduler_loop_quarantine_config.cc
  • M base/containers/to_value_list.h
  • M base/containers/to_value_list_nocompile.nc
  • M base/containers/to_value_list_unittest.cc
  • M base/json/json_perftest.cc
  • M base/json/json_reader.cc
  • M base/json/json_reader.h
  • M base/json/json_reader_unittest.cc
  • M base/json/json_value_converter.h
  • M base/json/json_value_converter_unittest.cc
  • M base/json/json_value_serializer_unittest.cc
  • M base/json/json_writer.cc
  • M base/json/json_writer.h
  • M base/json/json_writer_unittest.cc
  • M base/metrics/dummy_histogram.cc
  • M base/metrics/dummy_histogram.h
  • M base/metrics/field_trial_list_including_low_anonymity.h
  • M base/metrics/histogram.cc
  • M base/metrics/histogram.h
  • M base/metrics/histogram_base.cc
  • M base/metrics/histogram_base.h
  • M base/metrics/histogram_samples.cc
  • M base/metrics/histogram_samples.h
  • M base/metrics/histogram_unittest.cc
  • M base/metrics/sparse_histogram.cc
  • M base/metrics/sparse_histogram.h
  • M base/metrics/sparse_histogram_unittest.cc
  • M base/metrics/statistics_recorder_unittest.cc
  • M base/power_monitor/cpu_frequency_utils.cc
  • M base/power_monitor/cpu_frequency_utils.h
  • M base/task/sequence_manager/sequence_manager_impl.cc
  • M base/task/sequence_manager/sequence_manager_impl.h
  • M base/task/sequence_manager/task_queue_impl.cc
  • M base/task/sequence_manager/task_queue_impl.h
  • M base/task/sequence_manager/task_queue_selector.cc
  • M base/task/sequence_manager/task_queue_selector.h
  • M base/task/sequence_manager/time_domain.cc
  • M base/task/sequence_manager/time_domain.h
  • M base/task/sequence_manager/wake_up_queue.cc
  • M base/task/sequence_manager/wake_up_queue.h
  • M base/task/sequence_manager/work_queue.cc
  • M base/task/sequence_manager/work_queue.h
  • M base/test/fuzztest_support.h
  • M base/test/gtest_util.cc
  • M base/test/launcher/test_launcher_test_utils.cc
  • M base/test/launcher/test_launcher_test_utils.h
  • M base/test/launcher/test_launcher_tracer.cc
  • M base/test/launcher/test_launcher_unittest.cc
  • M base/test/launcher/test_results_tracker.cc
  • M base/test/metrics/histogram_tester.cc
  • M base/test/trace_event_analyzer.cc
  • M base/test/trace_event_analyzer.h
  • M base/test/trace_event_analyzer_unittest.cc
  • M base/test/values_test_util.cc
  • M base/test/values_test_util.h
  • M base/test/values_test_util_unittest.cc
  • M base/trace_event/trace_config.cc
  • M base/trace_event/trace_config.h
  • M base/trace_event/trace_config_category_filter.cc
  • M base/trace_event/trace_config_category_filter.h
  • M base/trace_event/trace_config_unittest.cc
  • M base/trace_event/trace_event_unittest.cc
  • M base/trace_event/traced_value.cc
  • M base/value_iterators.h
  • M base/values.h
  • M base/values_nocompile.nc
  • M base/values_unittest.cc
Change size: XL
Delta: 67 files changed, 770 insertions(+), 780 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I77b4468667b668db3ffc05aaea67bb44c8f65c5b
Gerrit-Change-Number: 7511733
Gerrit-PatchSet: 4
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
open
diffy
satisfied_requirement

Avi Drissman (Gerrit)

unread,
Jan 23, 2026, 1:52:27 PMJan 23
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, Zijie He, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, cros-print...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, language...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, petewi...@chromium.org, print-rev...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
Attention needed from Daniel Cheng

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Auto-Submit+1

1 comment

Patchset-level comments
Avi Drissman . resolved

dcheng: please review; this is strictly mechanical except where noted, so OO-ing is appropriate.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I85d10880ee9bd3fbbbeb7ed95e28836d9d0b1066
Gerrit-Change-Number: 7510416
Gerrit-PatchSet: 1
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Jan 2026 18:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Avi Drissman (Gerrit)

unread,
Jan 23, 2026, 1:57:53 PMJan 23
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, James Su, Zijie He, abigailbk...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, cfredri...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, derinel+wat...@google.com, dmurph+wa...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org
Attention needed from Daniel Cheng

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Avi Drissman . resolved

dcheng: please review; this is strictly mechanical except where noted, so OO-ing is appropriate.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I16cba43537d5e4afff923648bf0039e35bd43a0b
Gerrit-Change-Number: 7511734
Gerrit-PatchSet: 1
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Jan 2026 18:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jan 23, 2026, 1:58:38 PMJan 23
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, Zijie He, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, cros-print...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, language...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, petewi...@chromium.org, print-rev...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
Attention needed from Avi Drissman

Daniel Cheng added 1 comment

File components/autofill/core/browser/payments/payments_requests/get_details_for_create_bnpl_payment_instrument_request_unittest.cc
Line 91, Patchset 1 (Parent): base::Value::Dict response =
Daniel Cheng . unresolved

The CL description mentions both LIst and Dict, but these aren't changed. Is that intentional?

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I85d10880ee9bd3fbbbeb7ed95e28836d9d0b1066
    Gerrit-Change-Number: 7510416
    Gerrit-PatchSet: 1
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
    Gerrit-CC: Mike Taylor <mike...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Victor Tan <vict...@chromium.org>
    Gerrit-CC: Zijie He <zij...@google.com>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Comment-Date: Fri, 23 Jan 2026 18:58:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Jan 23, 2026, 2:01:13 PMJan 23
    to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, Zijie He, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, cros-print...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, language...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, petewi...@chromium.org, print-rev...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
    Attention needed from Daniel Cheng

    Avi Drissman added 1 comment

    File components/autofill/core/browser/payments/payments_requests/get_details_for_create_bnpl_payment_instrument_request_unittest.cc
    Line 91, Patchset 1 (Parent): base::Value::Dict response =
    Daniel Cheng . unresolved

    The CL description mentions both LIst and Dict, but these aren't changed. Is that intentional?

    Avi Drissman

    I’m going to withdraw this CL for now. I think my find/replace missed a few.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 23 Jan 2026 19:01:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    Jan 23, 2026, 2:02:12 PMJan 23
    to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, Zijie He, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, cros-print...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, language...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, petewi...@chromium.org, print-rev...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org
    Attention needed from Daniel Cheng

    Avi Drissman added 1 comment

    File components/autofill/core/browser/payments/payments_requests/get_details_for_create_bnpl_payment_instrument_request_unittest.cc
    Line 91, Patchset 1 (Parent): base::Value::Dict response =
    Daniel Cheng . resolved

    The CL description mentions both LIst and Dict, but these aren't changed. Is that intentional?

    Avi Drissman

    I’m going to withdraw this CL for now. I think my find/replace missed a few.

    Avi Drissman

    OK, so I missed the Dicts, but that’s 1100 files, so I’m going to withdraw this CL and do it in parts.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I85d10880ee9bd3fbbbeb7ed95e28836d9d0b1066
      Gerrit-Change-Number: 7510416
      Gerrit-PatchSet: 1
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
      Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
      Gerrit-CC: Mike Taylor <mike...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-CC: Victor Tan <vict...@chromium.org>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Fri, 23 Jan 2026 19:02:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Avi Drissman <a...@chromium.org>
      Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Avi Drissman (Gerrit)

      unread,
      Jan 23, 2026, 2:02:16 PMJan 23
      to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Javier Fernandez, Mike Taylor, Permissions Reviews, Peter Beverloo, Victor Tan, Zijie He, andysjl...@chromium.org, apaselti...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cc-...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, cros-print...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, donnd...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, gangwu...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, iclella...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jasonrobe...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, language...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, performance-m...@chromium.org, petewi...@chromium.org, print-rev...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, storage...@chromium.org, tmartino+tran...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org

      Avi Drissman abandoned this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: abandon
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jan 23, 2026, 2:41:52 PMJan 23
      to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, James Su, Zijie He, abigailbk...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, cfredri...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, derinel+wat...@google.com, dmurph+wa...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org
      Attention needed from Avi Drissman

      Daniel Cheng voted and added 1 comment

      Votes added by Daniel Cheng

      Code-Review+1
      Commit-Queue+2
      Owners-Override+1

      1 comment

      Patchset-level comments
      Daniel Cheng . resolved

      LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Avi Drissman
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I16cba43537d5e4afff923648bf0039e35bd43a0b
      Gerrit-Change-Number: 7511734
      Gerrit-PatchSet: 1
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: James Su <su...@chromium.org>
      Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
      Gerrit-CC: Peter Beverloo <pe...@chromium.org>
      Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Avi Drissman <a...@chromium.org>
      Gerrit-Comment-Date: Fri, 23 Jan 2026 19:41:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 23, 2026, 2:47:03 PMJan 23
      to Avi Drissman, Daniel Cheng, Akihiro Ota, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, (Julie)Jeongeun Kim, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, James Su, Zijie He, abigailbk...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, blink-work...@chromium.org, cambickel...@google.com, cfredri...@chromium.org, chfreme...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, derinel+wat...@google.com, dmurph+wa...@chromium.org, dtapuska+ch...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, navigation...@chromium.org, nektar...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, tburkar...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, webauthn...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Use modern names for base::DictValue and base::ListValue

      These classes were hoisted and renamed; switch all usage of these
      classes to use the new names.

      This is a strictly mechanical change, except for the
      forward-declarations in:
      - content/browser/first_party_sets/test/scoped_mock_first_party_sets_handler.h
      - content/browser/renderer_host/media/peer_connection_tracker_host.h
      - content/browser/webid/network_request_manager.h
      Bug: 478100525
      Change-Id: I16cba43537d5e4afff923648bf0039e35bd43a0b
      Owners-Override: Daniel Cheng <dch...@chromium.org>
      Commit-Queue: Daniel Cheng <dch...@chromium.org>
      Reviewed-by: Daniel Cheng <dch...@chromium.org>
      Auto-Submit: Avi Drissman <a...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1573854}
      Files:
      • M content/browser/accessibility/accessibility_tree_formatter_android.cc
      • M content/browser/accessibility/accessibility_tree_formatter_android.h
      • M content/browser/accessibility/accessibility_tree_formatter_android_external.cc
      • M content/browser/accessibility/accessibility_tree_formatter_android_external.h
      • M content/browser/accessibility/accessibility_tree_formatter_blink.cc
      • M content/browser/accessibility/accessibility_tree_formatter_blink.h
      • M content/browser/accessibility/accessibility_tree_formatter_fuchsia.cc
      • M content/browser/accessibility/accessibility_tree_formatter_fuchsia.h
      • M content/browser/aggregation_service/aggregatable_report.cc
      • M content/browser/aggregation_service/aggregatable_report.h
      • M content/browser/aggregation_service/aggregatable_report_sender_unittest.cc
      • M content/browser/aggregation_service/aggregatable_report_unittest.cc
      • M content/browser/aggregation_service/aggregation_service_test_utils.cc
      • M content/browser/aggregation_service/public_key_parsing_utils.cc
      • M content/browser/android/java/gin_java_bridge_dispatcher_host.cc
      • M content/browser/android/java/gin_java_bridge_dispatcher_host.h
      • M content/browser/android/java/gin_java_method_invocation_helper.cc
      • M content/browser/android/java/gin_java_method_invocation_helper.h
      • M content/browser/android/java/gin_java_method_invocation_helper_unittest.cc
      • M content/browser/android/java/gin_java_script_to_java_types_coercion.cc
      • M content/browser/android/tracing_controller_android.cc
      • M content/browser/attribution_reporting/aggregatable_attribution_utils.cc
      • M content/browser/attribution_reporting/aggregatable_attribution_utils_unittest.cc
      • M content/browser/attribution_reporting/aggregatable_debug_report.cc
      • M content/browser/attribution_reporting/aggregatable_debug_report_unittest.cc
      • M content/browser/attribution_reporting/attribution_aggregatable_report_golden_unittest.cc
      • M content/browser/attribution_reporting/attribution_data_host_manager_impl.cc
      • M content/browser/attribution_reporting/attribution_debug_report.cc
      • M content/browser/attribution_reporting/attribution_debug_report.h
      • M content/browser/attribution_reporting/attribution_internals_browsertest.cc
      • M content/browser/attribution_reporting/attribution_internals_handler_impl.cc
      • M content/browser/attribution_reporting/attribution_manager_impl.cc
      • M content/browser/attribution_reporting/attribution_manager_impl_unittest.cc
      • M content/browser/attribution_reporting/attribution_report.cc
      • M content/browser/attribution_reporting/attribution_report_network_sender.cc
      • M content/browser/attribution_reporting/attribution_report_network_sender_unittest.cc
      • M content/browser/attribution_reporting/attribution_report_unittest.cc
      • M content/browser/attribution_reporting/attributions_browsertest.cc
      • M content/browser/attribution_reporting/interop/interop_main.cc
      • M content/browser/attribution_reporting/interop/interop_unittest.cc
      • M content/browser/attribution_reporting/interop/parser.cc
      • M content/browser/attribution_reporting/interop/parser.h
      • M content/browser/attribution_reporting/interop/parser_unittest.cc
      • M content/browser/attribution_reporting/interop/runner.cc
      • M content/browser/blob_storage/blob_url_browsertest.cc
      • M content/browser/bluetooth/bluetooth_device_chooser_controller.cc
      • M content/browser/cache_storage/cache_storage_blob_browsertest.cc
      • M content/browser/device_posture/device_posture_registry_watcher_win.cc
      • M content/browser/device_posture/device_posture_registry_watcher_win.h
      • M content/browser/device_posture/device_posture_registry_watcher_win_unittest.cc
      • M content/browser/devtools/devtools_frontend_host_impl.cc
      • M content/browser/devtools/devtools_frontend_host_impl.h
      • M content/browser/devtools/devtools_frontend_host_impl_unittest.cc
      • M content/browser/devtools/devtools_http_handler.cc
      • M content/browser/devtools/devtools_http_handler.h
      • M content/browser/devtools/devtools_http_handler_unittest.cc
      • M content/browser/devtools/devtools_instrumentation.cc
      • M content/browser/devtools/devtools_instrumentation.h
      • M content/browser/devtools/devtools_issue_storage_browsertest.cc
      • M content/browser/devtools/devtools_trust_token_browsertest.cc
      • M content/browser/devtools/protocol/devtools_protocol_browsertest.cc
      • M content/browser/devtools/protocol/network_handler.cc
      • M content/browser/devtools/protocol/storage_handler.cc
      • M content/browser/devtools/protocol/storage_handler.h
      • M content/browser/devtools/protocol/system_info_handler.cc
      • M content/browser/devtools/protocol/target_handler.cc
      • M content/browser/devtools/protocol/tracing_handler.cc
      • M content/browser/devtools/protocol/visual_debugger_handler.cc
      • M content/browser/devtools/protocol/visual_debugger_handler.h
      • M content/browser/devtools/protocol/visual_debugger_handler_browsertest.cc
      • M content/browser/devtools/shared_worker_devtools_agent_host.cc
      • M content/browser/digital_credentials/cross_device_request_dispatcher.cc
      • M content/browser/digital_credentials/cross_device_request_dispatcher_unittest.cc
      • M content/browser/digital_credentials/cross_device_transaction_impl_unittest.cc
      • M content/browser/digital_credentials/digital_identity_request_impl.cc
      • M content/browser/digital_credentials/digital_identity_request_impl_unittest.cc
      • M content/browser/direct_sockets/direct_sockets_open_browsertest.cc
      • M content/browser/fenced_frame/fenced_frame_browsertest.cc
      • M content/browser/first_party_sets/first_party_set_parser.cc
      • M content/browser/first_party_sets/first_party_set_parser.h
      • M content/browser/first_party_sets/first_party_set_parser_unittest.cc
      • M content/browser/first_party_sets/first_party_sets_handler_impl_instance.cc
      • M content/browser/first_party_sets/first_party_sets_handler_impl_instance.h
      • M content/browser/first_party_sets/first_party_sets_handler_impl_instance_unittest.cc
      • M content/browser/first_party_sets/test/first_party_set_parser_value_fuzzer.cc
      • M content/browser/first_party_sets/test/scoped_mock_first_party_sets_handler.cc
      • M content/browser/first_party_sets/test/scoped_mock_first_party_sets_handler.h
      • M content/browser/font_list_async.cc
      • M content/browser/font_preferences_browsertest.cc
      • M content/browser/font_unique_name_lookup/font_unique_name_browsertest.cc
      • M content/browser/gpu/compositor_util.cc
      • M content/browser/gpu/gpu_data_manager_impl.cc
      • M content/browser/gpu/gpu_data_manager_impl.h
      • M content/browser/gpu/gpu_data_manager_impl_private.cc
      • M content/browser/gpu/gpu_data_manager_impl_private.h
      • M content/browser/gpu/gpu_internals_ui.cc
      • M content/browser/in_memory_federated_permission_context.cc
      • M content/browser/in_memory_federated_permission_context.h
      • M content/browser/indexed_db/instance/leveldb/indexed_db_leveldb_operations.cc
      • M content/browser/interest_group/ad_auction_service_impl_unittest.cc
      • M content/browser/interest_group/additional_bids_test_util.cc
      • M content/browser/interest_group/additional_bids_util.cc
      • M content/browser/interest_group/additional_bids_util_unittest.cc
      • M content/browser/interest_group/auction_runner_unittest.cc
      • M content/browser/interest_group/bidding_and_auction_response.cc
      • M content/browser/interest_group/bidding_and_auction_response.h
      • M content/browser/interest_group/bidding_and_auction_response_unittest.cc
      • M content/browser/interest_group/bidding_and_auction_serializer.cc
      • M content/browser/interest_group/bidding_and_auction_server_key_fetcher.cc
      • M content/browser/interest_group/header_direct_from_seller_signals.cc
      • M content/browser/interest_group/interest_group_auction.cc
      • M content/browser/interest_group/interest_group_browsertest.cc
      • M content/browser/interest_group/interest_group_storage.cc
      • M content/browser/interest_group/interest_group_update_manager.cc
      • M content/browser/interest_group/tools/adjustable_auction.cc
      • M content/browser/interest_group/trusted_signals_cache_impl.cc
      • M content/browser/interest_group/trusted_signals_cache_impl.h
      • M content/browser/interest_group/trusted_signals_cache_impl_unittest.cc
      • M content/browser/interest_group/trusted_signals_fetcher.cc
      • M content/browser/interest_group/trusted_signals_fetcher.h
      • M content/browser/interest_group/trusted_signals_fetcher_unittest.cc
      • M content/browser/loader/navigation_early_hints_browsertest.cc
      • M content/browser/media/media_internals.cc
      • M content/browser/media/media_internals.h
      • M content/browser/media/media_internals_audio_focus_helper.cc
      • M content/browser/media/media_internals_audio_focus_helper.h
      • M content/browser/media/media_internals_cdm_helper.cc
      • M content/browser/media/media_internals_handler.cc
      • M content/browser/media/media_internals_handler.h
      • M content/browser/media/media_internals_unittest.cc
      • M content/browser/metrics/histograms_internals_ui.cc
      • M content/browser/metrics/histograms_monitor.cc
      • M content/browser/metrics/histograms_monitor.h
      • M content/browser/metrics/histograms_monitor_unittest.cc
      • M content/browser/navigation_browsertest.cc
      • M content/browser/network/cross_origin_embedder_policy_reporter.cc
      • M content/browser/network/cross_origin_embedder_policy_reporter_unittest.cc
      • M content/browser/network/http_cookie_browsertest.cc
      • M content/browser/network/network_errors_listing_ui.cc
      • M content/browser/network/reporting_service_proxy.cc
      • M content/browser/network/sandboxed_network_list_browsertest.cc
      • M content/browser/performance_timeline_browsertest.cc
      • M content/browser/preloading/preloading_config.cc
      • M content/browser/preloading/preloading_config.h
      • M content/browser/preloading/prerender/prerender_browsertest.cc
      • M content/browser/private_aggregation/private_aggregation_host.cc
      • M content/browser/private_aggregation/private_aggregation_host_unittest.cc
      • M content/browser/private_aggregation/private_aggregation_internals_handler_impl.cc
      • M content/browser/private_aggregation/private_aggregation_internals_handler_impl_unittest.cc
      • M content/browser/private_aggregation/private_aggregation_report_golden_unittest.cc
      • M content/browser/renderer_host/cookie_browsertest.cc
      • M content/browser/renderer_host/input/mouse_latency_browsertest.cc
      • M content/browser/renderer_host/input/stylus_handwriting_controller_win_browsertest.cc
      • M content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
      • M content/browser/renderer_host/jit_policy_browsertest.cc
      • M content/browser/renderer_host/media/peer_connection_tracker_host.cc
      • M content/browser/renderer_host/media/peer_connection_tracker_host.h
      • M content/browser/renderer_host/media/peer_connection_tracker_host_unittest.cc
      • M content/browser/renderer_host/render_frame_host_impl.cc
      • M content/browser/renderer_host/render_frame_host_impl.h
      • M content/browser/renderer_host/render_frame_host_impl_browsertest.cc
      • M content/browser/renderer_host/render_process_host_sandbox_policy_win_browsertest.cc
      • M content/browser/renderer_host/render_widget_host_view_aura_browsertest.cc
      • M content/browser/renderer_host/scroll_into_view_browsertest.cc
      • M content/browser/screen_details/screen_details_test_utils.cc
      • M content/browser/screen_details/screen_details_test_utils.h
      • M content/browser/security/coop/cross_origin_opener_policy_reporter.cc
      • M content/browser/security/coop/cross_origin_opener_policy_reporter.h
      • M content/browser/security/coop/cross_origin_opener_policy_reporter_unittest.cc
      • M content/browser/security/coop/cross_origin_opener_policy_reporting_browsertest.cc
      • M content/browser/security/dip/document_isolation_policy_reporter.cc
      • M content/browser/security/dip/document_isolation_policy_reporter_unittest.cc
      • M content/browser/service_worker/service_worker_browsertest.cc
      • M content/browser/service_worker/service_worker_file_upload_browsertest.cc
      • M content/browser/service_worker/service_worker_internals_ui.cc
      • M content/browser/service_worker/service_worker_internals_ui.h
      • M content/browser/shared_storage/shared_storage_browsertest.cc
      • M content/browser/shared_storage/shared_storage_worklet_host.cc
      • M content/browser/shared_storage/shared_storage_worklet_host.h
      • M content/browser/site_per_process_browsertest.cc
      • M content/browser/site_per_process_hit_test_browsertest.cc
      • M content/browser/site_per_process_layout_browsertest.cc
      • M content/browser/smart_card/smart_card_browsertest.cc
      • M content/browser/speech/tts_controller_impl.cc
      • M content/browser/speech/tts_utterance_impl.cc
      • M content/browser/speech/tts_utterance_impl.h
      • M content/browser/tracing/background_tracing_manager_browsertest.cc
      • M content/browser/tracing/tracing_ui.cc
      • M content/browser/tracing/tracing_ui_unittest.cc
      • M content/browser/ukm_internals_ui.cc
      • M content/browser/webauth/authenticator_impl_unittest.cc
      • M content/browser/webid/delegation/dns_request.cc
      • M content/browser/webid/delegation/email_verifier_network_request_manager.cc
      • M content/browser/webid/delegation/sd_jwt.cc
      • M content/browser/webid/delegation/sd_jwt.h
      • M content/browser/webid/idp_network_request_manager.cc
      • M content/browser/webid/idp_network_request_manager_unittest.cc
      • M content/browser/webid/navigation_interceptor_unittest.cc
      • M content/browser/webid/network_request_manager.cc
      • M content/browser/webid/network_request_manager.h
      • M content/browser/webid/test/mock_permission_delegate.h
      • M content/browser/webid/webid_browsertest.cc
      • M content/browser/webrtc/webrtc_getusermedia_browsertest.cc
      • M content/browser/webrtc/webrtc_internals.cc
      • M content/browser/webrtc/webrtc_internals.h
      • M content/browser/webrtc/webrtc_internals_browsertest.cc
      • M content/browser/webrtc/webrtc_internals_message_handler.cc
      • M content/browser/webrtc/webrtc_internals_message_handler.h
      • M content/browser/webrtc/webrtc_internals_unittest.cc
      • M content/browser/webui/url_data_manager.cc
      • M content/browser/webui/url_data_manager.h
      • M content/browser/webui/url_data_manager_backend.cc
      • M content/browser/webui/url_data_manager_backend.h
      • M content/browser/webui/web_ui_browsertest.cc
      • M content/browser/webui/web_ui_data_source_impl.cc
      • M content/browser/webui/web_ui_data_source_impl.h
      • M content/browser/webui/web_ui_impl.cc
      • M content/browser/webui/web_ui_impl.h
      • M content/browser/webui/web_ui_unittest.cc
      • M content/common/common_param_traits_unittest.cc
      • M content/common/font_list.h
      • M content/common/font_list_android.cc
      • M content/common/font_list_fontconfig.cc
      • M content/common/font_list_fuchsia.cc
      • M content/common/font_list_mac.mm
      • M content/common/font_list_unittest.cc
      • M content/common/font_list_win.cc
      • M content/common/gin_java_bridge.mojom
      • M content/common/input/actions_parser.cc
      • M content/common/input/actions_parser.h
      • M content/common/service_worker/service_worker_router_evaluator.cc
      • M content/common/service_worker/service_worker_router_evaluator_unittest.cc
      • M content/public/browser/content_browser_client.cc
      • M content/public/browser/content_browser_client.h
      • M content/public/browser/devtools_frontend_host.h
      • M content/public/browser/first_party_sets_handler.h
      • M content/public/browser/font_list_async.h
      • M content/public/browser/peer_connection_tracker_host_observer.h
      • M content/public/browser/render_frame_host.h
      • M content/public/browser/tts_utterance.h
      • M content/public/browser/web_ui.h
      • M content/public/browser/web_ui_controller.cc
      • M content/public/browser/web_ui_controller.h
      • M content/public/browser/web_ui_data_source.h
      • M content/public/browser/webid/federated_identity_permission_context_delegate.h
      • M content/public/test/browser_test_utils.cc
      • M content/public/test/browser_test_utils.h
      • M content/public/test/fake_local_frame.cc
      • M content/public/test/fake_local_frame.h
      • M content/public/test/privacy_sandbox_coordinator_test_util.cc
      • M content/public/test/scoped_page_focus_override.cc
      • M content/public/test/test_aggregation_service.cc
      • M content/public/test/test_aggregation_service.h
      • M content/public/test/test_devtools_protocol_client.cc
      • M content/public/test/test_devtools_protocol_client.h
      • M content/public/test/test_web_ui.cc
      • M content/public/test/test_web_ui.h
      • M content/public/test/test_web_ui_data_source.cc
      • M content/public/test/test_web_ui_data_source.h
      • M content/public/test/test_web_ui_listener_observer.h
      • M content/renderer/gpu_benchmarking_extension.cc
      • M content/renderer/java/gin_java_bridge_value_converter.cc
      • M content/renderer/java/gin_java_function_invocation_helper.cc
      • M content/renderer/media/inspector_media_event_handler.cc
      • M content/renderer/render_frame_impl.cc
      • M content/renderer/skia_benchmarking_extension.cc
      • M content/renderer/skia_benchmarking_extension_unittest.cc
      • M content/renderer/v8_value_converter_impl.cc
      • M content/renderer/v8_value_converter_impl.h
      • M content/renderer/v8_value_converter_impl_unittest.cc
      • M content/renderer/web_ui_extension.cc
      • M content/renderer/web_ui_extension_data.cc
      • M content/renderer/web_ui_extension_data.h
      • M content/services/auction_worklet/auction_v8_helper_unittest.cc
      • M content/services/auction_worklet/bidder_worklet_unittest.cc
      • M content/services/auction_worklet/seller_worklet_unittest.cc
      • M content/services/auction_worklet/trusted_signals_kvv2_helper.h
      • M content/services/auction_worklet/worklet_v8_debug_test_util.cc
      • M content/shell/browser/shell_content_browser_client.cc
      • M content/shell/browser/shell_content_browser_client.h
      • M content/shell/browser/shell_devtools_bindings.cc
      • M content/shell/browser/shell_devtools_bindings.h
      • M content/test/content_browser_test_test.cc
      • M content/test/fuzzer/renderer_tree_fuzzer.cc
      • M content/test/test_aggregation_service_impl.cc
      • M content/test/test_aggregation_service_impl.h
      • M content/web_test/browser/devtools_protocol_test_bindings.cc
      • M content/web_test/browser/devtools_protocol_test_bindings.h
      • M content/web_test/browser/leak_detector.cc
      • M content/web_test/browser/web_test_control_host.cc
      • M content/web_test/browser/web_test_control_host.h
      • M content/web_test/common/tracked_dictionary.cc
      • M content/web_test/common/tracked_dictionary.h
      • M content/web_test/renderer/test_runner.cc
      • M content/web_test/renderer/test_runner.h
      • M content/web_test/renderer/web_frame_test_proxy.cc
      • M content/web_test/renderer/web_frame_test_proxy.h
      Change size: XL
      Delta: 297 files changed, 2229 insertions(+), 2261 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Daniel Cheng
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I16cba43537d5e4afff923648bf0039e35bd43a0b
      Gerrit-Change-Number: 7511734
      Gerrit-PatchSet: 2
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      open
      diffy
      satisfied_requirement

      Avi Drissman (Gerrit)

      unread,
      Jan 24, 2026, 5:05:44 PM (14 days ago) Jan 24
      to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, fenced-fra...@chromium.org, ipc-securi...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rhalava...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
      Attention needed from Daniel Cheng

      Avi Drissman voted and added 1 comment

      Votes added by Avi Drissman

      Auto-Submit+1

      1 comment

      Patchset-level comments
      Avi Drissman . resolved

      dcheng: please review; this is strictly mechanical except where noted, so OO-ing is appropriate.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If79ef960f6ee7499b7337ad0ad826f89fbd1e188
      Gerrit-Change-Number: 7511807
      Gerrit-PatchSet: 1
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
      Gerrit-CC: Jiewei Qian <q...@chromium.org>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Sat, 24 Jan 2026 22:05:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Avi Drissman (Gerrit)

      unread,
      Jan 24, 2026, 6:02:09 PM (14 days ago) Jan 24
      to Avi Drissman, Daniel Cheng, chromium...@chromium.org, Sarah Krakowiak, Zijie He, Chromium LUCI CQ, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, cc-...@chromium.org, christia...@chromium.org, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, estali...@chromium.org, fuchsia...@chromium.org, gangwu...@chromium.org, ios-r...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Daniel Cheng

      Avi Drissman voted and added 1 comment

      Votes added by Avi Drissman

      Auto-Submit+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 1 (Latest):
      Avi Drissman . resolved

      dcheng: please review; this is strictly mechanical except where noted, so OO-ing is appropriate.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I203f7d91a5c8d3dc1bd5f3bc22d8144754122a66
      Gerrit-Change-Number: 7509893
      Gerrit-PatchSet: 1
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Sat, 24 Jan 2026 23:02:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jan 25, 2026, 2:57:06 PM (13 days ago) Jan 25
      to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, fenced-fra...@chromium.org, ipc-securi...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rhalava...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
      Attention needed from Avi Drissman

      Daniel Cheng voted

      Code-Review+1
      Commit-Queue+2
      Owners-Override+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Avi Drissman
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If79ef960f6ee7499b7337ad0ad826f89fbd1e188
      Gerrit-Change-Number: 7511807
      Gerrit-PatchSet: 1
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
      Gerrit-CC: Jiewei Qian <q...@chromium.org>
      Gerrit-Attention: Avi Drissman <a...@chromium.org>
      Gerrit-Comment-Date: Sun, 25 Jan 2026 19:56:57 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jan 25, 2026, 2:58:08 PM (13 days ago) Jan 25
      to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, fenced-fra...@chromium.org, ipc-securi...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rhalava...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
      Attention needed from Avi Drissman

      Daniel Cheng voted Owners-Override+0

      Owners-Override+0
      Gerrit-Comment-Date: Sun, 25 Jan 2026 19:57:59 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jan 25, 2026, 3:02:44 PM (13 days ago) Jan 25
      to Avi Drissman, Daniel Cheng, chromium...@chromium.org, Sarah Krakowiak, Zijie He, Chromium LUCI CQ, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, cc-...@chromium.org, christia...@chromium.org, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, estali...@chromium.org, fuchsia...@chromium.org, gangwu...@chromium.org, ios-r...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Avi Drissman

      Daniel Cheng voted

      Code-Review+1
      Commit-Queue+2
      Owners-Override+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Avi Drissman
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I203f7d91a5c8d3dc1bd5f3bc22d8144754122a66
      Gerrit-Change-Number: 7509893
      Gerrit-PatchSet: 2
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Avi Drissman <a...@chromium.org>
      Gerrit-Comment-Date: Sun, 25 Jan 2026 20:02:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 25, 2026, 3:47:48 PM (13 days ago) Jan 25
      to Avi Drissman, Daniel Cheng, chromium...@chromium.org, Hu, Ningxin, Jiewei Qian, fenced-fra...@chromium.org, ipc-securi...@chromium.org, jdeblas...@chromium.org, martijn...@martijnc.be, mbarowsky+watc...@chromium.org, network-ser...@chromium.org, rhalava...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Use modern names for base::DictValue and base::ListValue

      These classes were hoisted and renamed; switch all usage of these
      classes to use the new names.

      This is a strictly mechanical change.
      Bug: 478100525
      Change-Id: If79ef960f6ee7499b7337ad0ad826f89fbd1e188
      Auto-Submit: Avi Drissman <a...@chromium.org>
      Commit-Queue: Daniel Cheng <dch...@chromium.org>
      Reviewed-by: Daniel Cheng <dch...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1574263}
      Files:
      • M services/data_decoder/cbor_parser_impl.cc
      • M services/data_decoder/cbor_parser_unittest.cc
      • M services/data_decoder/public/cpp/data_decoder_unittest.cc
      • M services/data_decoder/public/cpp/safe_xml_parser.cc
      • M services/data_decoder/public/cpp/safe_xml_parser.h
      • M services/data_decoder/xml_parser.cc
      • M services/device/geolocation/network_location_provider_unittest.cc
      • M services/device/geolocation/network_location_request.cc
      • M services/device/geolocation/network_location_request.h
      • M services/device/geolocation/wifi_data_provider_chromeos_unittest.cc
      • M services/image_annotation/annotator.cc
      • M services/image_annotation/annotator.h
      • M services/image_annotation/annotator_unittest.cc
      • M services/network/cors/cors_url_loader.cc
      • M services/network/cors/preflight_cache.cc
      • M services/network/cors/preflight_result.cc
      • M services/network/cors/preflight_result.h
      • M services/network/cors/preflight_result_unittest.cc
      • M services/network/http_server_properties_pref_delegate.cc
      • M services/network/http_server_properties_pref_delegate.h
      • M services/network/known_legacy_scope_domains_delegate.cc
      • M services/network/known_legacy_scope_domains_delegate.h
      • M services/network/known_legacy_scope_domains_delegate_unittest.cc
      • M services/network/net_log_exporter.cc
      • M services/network/net_log_exporter.h
      • M services/network/net_log_proxy_sink.cc
      • M services/network/net_log_proxy_sink.h
      • M services/network/net_log_proxy_sink_unittest.cc
      • M services/network/network_context.cc
      • M services/network/network_context.h
      • M services/network/network_context_unittest.cc
      • M services/network/network_qualities_pref_delegate.cc
      • M services/network/network_service.cc
      • M services/network/network_service.h
      • M services/network/network_service_unittest.cc
      • M services/network/oblivious_http_request_handler.cc
      • M services/network/private_network_access_url_loader_interceptor.cc
      • M services/network/proxy_resolver_factory_mojo.cc
      • M services/network/public/cpp/reporting_api_report_mojom_traits.h
      • M services/network/sct_auditing/sct_auditing_handler.cc
      • M services/network/sct_auditing/sct_auditing_reporter.cc
      • M services/network/sct_auditing/sct_auditing_reporter_unittest.cc
      • M services/network/session_cleanup_cookie_store.cc
      • M services/network/test/test_network_context.h
      • M services/network/test/trust_token_request_handler.cc
      • M services/network/test/trust_token_test_util.cc
      • M services/network/trust_tokens/trust_token_key_commitment_parser.cc
      • M services/network/trust_tokens/trust_token_request_helper_factory.cc
      • M services/network/trust_tokens/trust_token_request_issuance_helper.cc
      • M services/network/trust_tokens/trust_token_request_redemption_helper.cc
      • M services/network/trust_tokens/trust_token_request_signing_helper.cc
      • M services/network/url_loader.cc
      • M services/network/url_loader_unittest.cc
      • M services/network/web_transport.cc
      • M services/network/web_transport_unittest.cc
      • M services/network/websocket.cc
      • M services/preferences/public/cpp/dictionary_value_update.cc
      • M services/preferences/public/cpp/dictionary_value_update.h
      • M services/preferences/public/cpp/scoped_pref_update.cc
      • M services/preferences/tracked/dictionary_hash_store_contents.cc
      • M services/preferences/tracked/dictionary_hash_store_contents.h
      • M services/preferences/tracked/hash_store_contents.h
      • M services/preferences/tracked/interceptable_pref_filter.cc
      • M services/preferences/tracked/interceptable_pref_filter.h
      • M services/preferences/tracked/interceptable_pref_filter_unittest.cc
      • M services/preferences/tracked/pref_hash_calculator.cc
      • M services/preferences/tracked/pref_hash_calculator.h
      • M services/preferences/tracked/pref_hash_calculator_unittest.cc
      • M services/preferences/tracked/pref_hash_filter.cc
      • M services/preferences/tracked/pref_hash_filter.h
      • M services/preferences/tracked/pref_hash_filter_unittest.cc
      • M services/preferences/tracked/pref_hash_store.h
      • M services/preferences/tracked/pref_hash_store_impl.cc
      • M services/preferences/tracked/pref_hash_store_impl.h
      • M services/preferences/tracked/pref_hash_store_impl_unittest.cc
      • M services/preferences/tracked/pref_hash_store_transaction.h
      • M services/preferences/tracked/registry_hash_store_contents_win.cc
      • M services/preferences/tracked/registry_hash_store_contents_win.h
      • M services/preferences/tracked/tracked_atomic_preference.cc
      • M services/preferences/tracked/tracked_atomic_preference.h
      • M services/preferences/tracked/tracked_persistent_pref_store_factory.cc
      • M services/preferences/tracked/tracked_persistent_pref_store_factory.h
      • M services/preferences/tracked/tracked_preference.h
      • M services/preferences/tracked/tracked_preferences_migration.cc
      • M services/preferences/tracked/tracked_preferences_migration_unittest.cc
      • M services/preferences/tracked/tracked_split_preference.cc
      • M services/preferences/tracked/tracked_split_preference.h
      • M services/screen_ai/screen_ai_ocr_perf_test.cc
      • M services/tracing/public/cpp/trace_startup_config.cc
      • M services/webnn/coreml/graph_builder_coreml.cc
      Change size: XL
      Delta: 90 files changed, 581 insertions(+), 594 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Daniel Cheng
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If79ef960f6ee7499b7337ad0ad826f89fbd1e188
      Gerrit-Change-Number: 7511807
      Gerrit-PatchSet: 2
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      open
      diffy
      satisfied_requirement

      Avi Drissman (Gerrit)

      unread,
      Jan 25, 2026, 4:38:31 PM (13 days ago) Jan 25
      to Avi Drissman, Daniel Cheng, chromium...@chromium.org, Sarah Krakowiak, Zijie He, Chromium LUCI CQ, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, cc-...@chromium.org, christia...@chromium.org, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, estali...@chromium.org, fuchsia...@chromium.org, gangwu...@chromium.org, ios-r...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
      Attention needed from Daniel Cheng

      Avi Drissman voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I203f7d91a5c8d3dc1bd5f3bc22d8144754122a66
      Gerrit-Change-Number: 7509893
      Gerrit-PatchSet: 2
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
      Gerrit-CC: Zijie He <zij...@google.com>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Sun, 25 Jan 2026 21:38:25 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 25, 2026, 5:06:10 PM (13 days ago) Jan 25
      to Avi Drissman, Daniel Cheng, chromium...@chromium.org, Sarah Krakowiak, Zijie He, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, cc-...@chromium.org, christia...@chromium.org, chrome-tab-group-en...@google.com, chromiumme...@microsoft.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, donnd...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, estali...@chromium.org, fuchsia...@chromium.org, gangwu...@chromium.org, ios-r...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, net-r...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, spang...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, tracing...@chromium.org, twelling...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Use modern names for base::DictValue and base::ListValue

      These classes were hoisted and renamed; switch all usage of these
      classes to use the new names.

      This is a strictly mechanical change, except for the
      forward-declarations in:
      - components/security_interstitials/content/stateful_ssl_host_state_delegate.h
      - components/translate/translate_internals/translate_internals_handler.h

      NO_IFTTT=strict renaming of a class, no code change
      Bug: 478100525
      Change-Id: I203f7d91a5c8d3dc1bd5f3bc22d8144754122a66
      Reviewed-by: Daniel Cheng <dch...@chromium.org>
      Owners-Override: Daniel Cheng <dch...@chromium.org>
      Commit-Queue: Avi Drissman <a...@chromium.org>
      Auto-Submit: Avi Drissman <a...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1574279}
      Files:
      • M components/safe_browsing/content/browser/base_blocking_page.cc
      • M components/safe_browsing/content/browser/base_blocking_page.h
      • M components/safe_browsing/content/browser/client_side_detection_service.cc
      • M components/safe_browsing/content/browser/notification_content_detection/notification_content_detection_model.cc
      • M components/safe_browsing/content/browser/password_protection/password_protection_service_unittest.cc
      • M components/safe_browsing/content/browser/triggers/trigger_throttler.cc
      • M components/safe_browsing/content/browser/triggers/trigger_throttler_unittest.cc
      • M components/safe_browsing/content/browser/web_ui/safe_browsing_content_ui_handler.cc
      • M components/safe_browsing/content/browser/web_ui/safe_browsing_content_ui_handler.h
      • M components/safe_browsing/content/browser/web_ui/safe_browsing_ui_unittest.cc
      • M components/safe_browsing/content/common/file_type_policies_policy_util.cc
      • M components/safe_browsing/content/common/file_type_policies_policy_util_unittest.cc
      • M components/safe_browsing/content/common/file_type_policies_test_util.cc
      • M components/safe_browsing/content/common/file_type_policies_test_util.h
      • M components/safe_browsing/content/common/file_type_policies_unittest.cc
      • M components/safe_browsing/core/browser/password_protection/password_protection_service_base.cc
      • M components/safe_browsing/core/browser/safe_browsing_metrics_collector.cc
      • M components/safe_browsing/core/browser/safe_browsing_metrics_collector.h
      • M components/safe_browsing/core/browser/safe_browsing_metrics_collector_unittest.cc
      • M components/safe_browsing/core/browser/tailored_security_service/tailored_security_service.cc
      • M components/safe_browsing/core/browser/tailored_security_service/tailored_security_service.h
      • M components/safe_browsing/core/browser/tailored_security_service/tailored_security_service_unittest.cc
      • M components/safe_browsing/core/browser/verdict_cache_manager.cc
      • M components/safe_browsing/core/browser/verdict_cache_manager.h
      • M components/safe_browsing/core/browser/verdict_cache_manager_unittest.cc
      • M components/safe_browsing/core/browser/web_ui/safe_browsing_ui_handler.cc
      • M components/safe_browsing/core/browser/web_ui/safe_browsing_ui_handler.h
      • M components/safe_browsing/core/browser/web_ui/safe_browsing_ui_util.cc
      • M components/safe_browsing/core/browser/web_ui/safe_browsing_ui_util.h
      • M components/safe_browsing/core/browser/web_ui/web_ui_info_singleton.cc
      • M components/safe_browsing/core/browser/web_ui/web_ui_info_singleton.h
      • M components/safe_browsing/core/browser/web_ui/web_ui_info_singleton_event_observer.h
      • M components/safe_browsing/core/browser/web_ui/web_ui_info_singleton_event_observer_impl.cc
      • M components/safe_browsing/core/browser/web_ui/web_ui_info_singleton_event_observer_impl.h
      • M components/safe_browsing/core/common/features.cc
      • M components/safe_browsing/core/common/features.h
      • M components/safe_browsing/core/common/safe_browsing_prefs.cc
      • M components/safe_browsing/core/common/safe_browsing_prefs.h
      • M components/safe_browsing/core/common/safe_browsing_prefs_unittest.cc
      • M components/safe_search_api/safe_search/safe_search_url_checker_client.cc
      • M components/safe_search_api/safe_search/safe_search_url_checker_client_unittest.cc
      • M components/safe_search_api/stub_url_checker.cc
      • M components/saved_tab_groups/internal/tab_group_sync_service_impl.cc
      • M components/saved_tab_groups/internal/tab_group_sync_service_impl_unittest.cc
      • M components/saved_tab_groups/public/pref_names.cc
      • M components/search_engines/default_search_manager.cc
      • M components/search_engines/default_search_manager.h
      • M components/search_engines/default_search_manager_unittest.cc
      • M components/search_engines/enterprise/default_search_policy_handler.cc
      • M components/search_engines/enterprise/default_search_policy_handler_unittest.cc
      • M components/search_engines/enterprise/enterprise_search_manager.cc
      • M components/search_engines/enterprise/enterprise_search_manager.h
      • M components/search_engines/enterprise/enterprise_search_manager_unittest.cc
      • M components/search_engines/enterprise/search_aggregator_policy_handler.cc
      • M components/search_engines/enterprise/search_aggregator_policy_handler_unittest.cc
      • M components/search_engines/enterprise/search_engine_fields_validators.cc
      • M components/search_engines/enterprise/site_search_policy_handler.cc
      • M components/search_engines/enterprise/site_search_policy_handler_unittest.cc
      • M components/search_engines/keyword_table.cc
      • M components/search_engines/search_engine_choice/search_engine_choice_eligibility_unittest.cc
      • M components/search_engines/search_engine_choice/search_engine_choice_service.cc
      • M components/search_engines/search_engine_choice/search_engine_choice_utils.cc
      • M components/search_engines/search_engine_choice/search_engine_choice_utils.h
      • M components/search_engines/search_engine_choice/search_engine_choice_utils_unittest.cc
      • M components/search_engines/search_engines_test_util.cc
      • M components/search_engines/template_url_data.cc
      • M components/search_engines/template_url_data.h
      • M components/search_engines/template_url_data_util.cc
      • M components/search_engines/template_url_data_util.h
      • M components/search_engines/template_url_parser.cc
      • M components/search_engines/template_url_prepopulate_data.cc
      • M components/search_engines/template_url_prepopulate_data_unittest.cc
      • M components/search_engines/template_url_service_util_unittest.cc
      • M components/search_provider_logos/google_logo_api.cc
      • M components/search_provider_logos/logo_cache.cc
      • M components/search_provider_logos/logo_service_impl_unittest.cc
      • M components/security_interstitials/content/bad_clock_blocking_page.cc
      • M components/security_interstitials/content/bad_clock_blocking_page.h
      • M components/security_interstitials/content/blocked_interception_blocking_page.cc
      • M components/security_interstitials/content/blocked_interception_blocking_page.h
      • M components/security_interstitials/content/captive_portal_blocking_page.cc
      • M components/security_interstitials/content/captive_portal_blocking_page.h
      • M components/security_interstitials/content/https_only_mode_blocking_page.cc
      • M components/security_interstitials/content/https_only_mode_blocking_page.h
      • M components/security_interstitials/content/insecure_form_blocking_page.cc
      • M components/security_interstitials/content/insecure_form_blocking_page.h
      • M components/security_interstitials/content/mitm_software_blocking_page.cc
      • M components/security_interstitials/content/mitm_software_blocking_page.h
      • M components/security_interstitials/content/security_interstitial_page.cc
      • M components/security_interstitials/content/security_interstitial_page.h
      • M components/security_interstitials/content/security_interstitial_tab_helper_unittest.cc
      • M components/security_interstitials/content/ssl_blocking_page.cc
      • M components/security_interstitials/content/ssl_blocking_page.h
      • M components/security_interstitials/content/ssl_blocking_page_base.cc
      • M components/security_interstitials/content/ssl_blocking_page_base.h
      • M components/security_interstitials/content/ssl_error_navigation_throttle_unittest.cc
      • M components/security_interstitials/content/stateful_ssl_host_state_delegate.cc
      • M components/security_interstitials/content/stateful_ssl_host_state_delegate.h
      • M components/security_interstitials/core/bad_clock_ui.cc
      • M components/security_interstitials/core/bad_clock_ui.h
      • M components/security_interstitials/core/base_safe_browsing_error_ui.h
      • M components/security_interstitials/core/blocked_interception_ui.cc
      • M components/security_interstitials/core/blocked_interception_ui.h
      • M components/security_interstitials/core/common_string_util.cc
      • M components/security_interstitials/core/common_string_util.h
      • M components/security_interstitials/core/https_only_mode_allowlist.cc
      • M components/security_interstitials/core/https_only_mode_enforcelist.cc
      • M components/security_interstitials/core/https_only_mode_ui_util.cc
      • M components/security_interstitials/core/https_only_mode_ui_util.h
      • M components/security_interstitials/core/mitm_software_ui.cc
      • M components/security_interstitials/core/mitm_software_ui.h
      • M components/security_interstitials/core/safe_browsing_loud_error_ui.cc
      • M components/security_interstitials/core/safe_browsing_loud_error_ui.h
      • M components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
      • M components/security_interstitials/core/safe_browsing_quiet_error_ui.h
      • M components/security_interstitials/core/ssl_error_ui.cc
      • M components/security_interstitials/core/ssl_error_ui.h
      • M components/security_interstitials/core/utils.cc
      • M components/security_interstitials/core/utils.h
      • M components/segmentation_platform/embedder/default_model/device_switcher_result_dispatcher.cc
      • M components/segmentation_platform/embedder/home_modules/tips_manager/tips_manager.cc
      • M components/segmentation_platform/embedder/home_modules/tips_manager/tips_manager_unittest.cc
      • M components/segmentation_platform/internal/config_parser.cc
      • M components/segmentation_platform/internal/segmentation_platform_service_impl_unittest.cc
      • M components/segmentation_platform/internal/segmentation_platform_service_test_base.cc
      • M components/segmentation_platform/internal/selection/segmentation_result_prefs.cc
      • M components/segmentation_platform/public/input_context.cc
      • M components/segmentation_platform/public/types/processed_value.cc
      • M components/services/app_service/public/cpp/app.h
      • M components/services/app_service/public/cpp/app_unittest.cc
      • M components/services/app_service/public/cpp/app_update.cc
      • M components/services/app_service/public/cpp/app_update.h
      • M components/services/app_service/public/cpp/app_update_unittest.cc
      • M components/services/app_service/public/cpp/file_handler.cc
      • M components/services/app_service/public/cpp/icon_info.cc
      • M components/services/app_service/public/cpp/intent_filter_util.cc
      • M components/services/app_service/public/cpp/intent_filter_util.h
      • M components/services/app_service/public/cpp/intent_filter_util_unittest.cc
      • M components/services/app_service/public/cpp/intent_util.cc
      • M components/services/app_service/public/cpp/intent_util.h
      • M components/services/app_service/public/cpp/permission.cc
      • M components/services/app_service/public/cpp/permission.h
      • M components/services/app_service/public/cpp/permission_unittest.cc
      • M components/services/app_service/public/cpp/preferred_apps_converter.cc
      • M components/services/app_service/public/cpp/preferred_apps_converter_unittest.cc
      • M components/services/app_service/public/cpp/protocol_handler_info.cc
      • M components/services/app_service/public/cpp/run_on_os_login_types.cc
      • M components/services/app_service/public/cpp/run_on_os_login_types.h
      • M components/services/app_service/public/cpp/share_target.cc
      • M components/services/heap_profiling/json_exporter.cc
      • M components/services/heap_profiling/json_exporter_unittest.cc
      • M components/services/storage/indexed_db/locks/partitioned_lock_manager.cc
      • M components/sessions/core/command_storage_manager.cc
      • M components/shared_highlighting/core/common/fragment_directives_utils.cc
      • M components/shared_highlighting/core/common/shared_highlighting_data_driven_test.cc
      • M components/shared_highlighting/core/common/text_fragment.cc
      • M components/shared_highlighting/core/common/text_fragment_unittest.cc
      • M components/shared_highlighting/ios/parsing_utils.h
      • M components/shared_highlighting/ios/parsing_utils.mm
      • M components/shared_highlighting/ios/parsing_utils_unittest.mm
      • M components/sharing_message/sharing_sync_preference.cc
      • M components/sharing_message/sharing_sync_preference_unittest.cc
      • M components/signin/core/browser/about_signin_internals.cc
      • M components/signin/core/browser/about_signin_internals.h
      • M components/signin/core/browser/active_primary_accounts_metrics_recorder.cc
      • M components/signin/core/browser/signin_metrics_service.cc
      • M components/signin/core/browser/signin_metrics_service_unittest.cc
      • M components/signin/internal/identity_manager/account_capabilities_fetcher_gaia.cc
      • M components/signin/internal/identity_manager/account_capabilities_fetcher_gaia.h
      • M components/signin/internal/identity_manager/account_fetcher_service.cc
      • M components/signin/internal/identity_manager/account_fetcher_service.h
      • M components/signin/internal/identity_manager/account_info_serializer.cc
      • M components/signin/internal/identity_manager/account_info_util.cc
      • M components/signin/internal/identity_manager/account_info_util.h
      • M components/signin/internal/identity_manager/account_info_util_unittest.cc
      • M components/signin/internal/identity_manager/account_tracker_service.cc
      • M components/signin/internal/identity_manager/account_tracker_service.h
      • M components/signin/internal/identity_manager/account_tracker_service_unittest.cc
      • M components/signin/internal/identity_manager/gaia_account_info_fetcher.cc
      • M components/signin/internal/identity_manager/gaia_account_info_fetcher.h
      • M components/signin/internal/identity_manager/gaia_cookie_manager_service.cc
      • M components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc
      • M components/signin/internal/identity_manager/primary_account_manager_unittest.cc
      • M components/signin/public/base/session_binding_test_utils.cc
      • M components/signin/public/base/session_binding_test_utils.h
      • M components/signin/public/base/session_binding_utils.cc
      • M components/signin/public/base/session_binding_utils_unittest.cc
      • M components/signin/public/base/signin_prefs.cc
      • M components/signin/public/identity_manager/account_capabilities.h
      • M components/signin/public/identity_manager/account_info.h
      • M components/signin/public/identity_manager/identity_test_utils.cc
      • M components/site_engagement/content/site_engagement_score.cc
      • M components/site_engagement/content/site_engagement_score.h
      • M components/site_engagement/content/site_engagement_score_unittest.cc
      • M components/site_isolation/site_isolation_policy.cc
      • M components/site_isolation/site_isolation_policy_unittest.cc
      • M components/soda/soda_installer.cc
      • M components/soda/soda_installer_impl_chromeos_unittest.cc
      • M components/spellcheck/browser/spelling_service_client.cc
      • M components/subresource_filter/content/browser/ads_intervention_manager.cc
      • M components/subresource_filter/content/browser/subresource_filter_content_settings_manager.cc
      • M components/subresource_filter/content/browser/subresource_filter_content_settings_manager.h
      • M components/subresource_filter/content/browser/subresource_filter_content_settings_manager_unittest.cc
      • M components/subresource_filter/tools/filter_tool.cc
      • M components/subresource_filter/tools/filter_tool_unittest.cc
      • M components/supervised_user/core/browser/family_link_settings_service.cc
      • M components/supervised_user/core/browser/family_link_settings_service.h
      • M components/supervised_user/core/browser/family_link_settings_service_unittest.cc
      • M components/supervised_user/core/browser/permission_request_creator_mock.cc
      • M components/supervised_user/core/browser/supervised_user_content_settings_provider.cc
      • M components/supervised_user/core/browser/supervised_user_content_settings_provider.h
      • M components/supervised_user/core/browser/supervised_user_error_page.cc
      • M components/supervised_user/core/browser/supervised_user_pref_store.cc
      • M components/supervised_user/core/browser/supervised_user_pref_store.h
      • M components/supervised_user/core/browser/supervised_user_pref_store_unittest.cc
      • M components/supervised_user/core/browser/supervised_user_test_environment.cc
      • M components/sync/android/sync_service_android_bridge.cc
      • M components/sync/base/account_pref_utils.cc
      • M components/sync/base/progress_marker_map.cc
      • M components/sync/base/progress_marker_map.h
      • M components/sync/base/user_selectable_type.cc
      • M components/sync/base/user_selectable_type.h
      • M components/sync/base/user_selectable_type_unittest.cc
      • M components/sync/engine/cycle/sync_cycle_snapshot.cc
      • M components/sync/engine/cycle/sync_cycle_snapshot.h
      • M components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc
      • M components/sync/engine/data_type_configurer.h
      • M components/sync/engine/events/commit_request_event.cc
      • M components/sync/engine/events/commit_request_event.h
      • M components/sync/engine/events/commit_response_event.cc
      • M components/sync/engine/events/commit_response_event.h
      • M components/sync/engine/events/configure_get_updates_request_event.cc
      • M components/sync/engine/events/configure_get_updates_request_event.h
      • M components/sync/engine/events/get_updates_response_event.cc
      • M components/sync/engine/events/get_updates_response_event.h
      • M components/sync/engine/events/normal_get_updates_request_event.cc
      • M components/sync/engine/events/normal_get_updates_request_event.h
      • M components/sync/engine/events/poll_get_updates_request_event.cc
      • M components/sync/engine/events/poll_get_updates_request_event.h
      • M components/sync/engine/events/protocol_event.cc
      • M components/sync/engine/events/protocol_event.h
      • M components/sync/engine/loopback_server/loopback_server.cc
      • M components/sync/engine/loopback_server/loopback_server.h
      • M components/sync/engine/sync_status.h
      • M components/sync/model/client_tag_based_data_type_processor.cc
      • M components/sync/model/data_type_controller_delegate.h
      • M components/sync/nigori/nigori_data_type_processor.cc
      • M components/sync/protocol/entity_data.cc
      • M components/sync/protocol/entity_data.h
      • M components/sync/protocol/proto_value_conversions.cc
      • M components/sync/protocol/proto_value_conversions_unittest.cc
      • M components/sync/protocol/proto_visitors.h
      • M components/sync/service/data_type_controller.cc
      • M components/sync/service/data_type_controller.h
      • M components/sync/service/data_type_manager.h
      • M components/sync/service/data_type_manager_impl.cc
      • M components/sync/service/data_type_manager_impl.h
      • M components/sync/service/data_type_manager_impl_unittest.cc
      • M components/sync/service/get_all_nodes_request_barrier.cc
      • M components/sync/service/get_all_nodes_request_barrier.h
      • M components/sync/service/glue/sync_engine_backend.h
      • M components/sync/service/glue/sync_transport_data_prefs.cc
      • M components/sync/service/sync_internals_util.cc
      • M components/sync/service/sync_internals_util.h
      • M components/sync/service/sync_internals_util_unittest.cc
      • M components/sync/service/sync_policy_handler.cc
      • M components/sync/service/sync_policy_handler_unittest.cc
      • M components/sync/service/sync_prefs.cc
      • M components/sync/service/sync_prefs_unittest.cc
      • M components/sync/service/sync_service.h
      • M components/sync/service/sync_service_impl.cc
      • M components/sync/service/sync_service_impl.h
      • M components/sync/service/sync_user_settings_impl_unittest.cc
      • M components/sync/test/data_type_manager_mock.h
      • M components/sync/test/fake_data_type_controller_delegate.cc
      • M components/sync/test/fake_data_type_controller_delegate.h
      • M components/sync/test/fake_server.cc
      • M components/sync/test/fake_server.h
      • M components/sync/test/fake_server_verifier.cc
      • M components/sync/test/mock_sync_service.h
      • M components/sync/test/test_sync_service.cc
      • M components/sync/test/test_sync_service.h
      • M components/sync_bookmarks/bookmark_data_type_processor.cc
      • M components/sync_bookmarks/bookmark_data_type_processor.h
      • M components/sync_device_info/device_info_prefs.cc
      • M components/sync_device_info/device_info_prefs_unittest.cc
      • M components/sync_preferences/cross_device_pref_tracker/cross_device_pref_tracker_impl.cc
      • M components/sync_preferences/cross_device_pref_tracker/cross_device_pref_tracker_impl.h
      • M components/sync_preferences/cross_device_pref_tracker/cross_device_pref_tracker_impl_unittest.cc
      • M components/sync_preferences/dual_layer_user_pref_store.cc
      • M components/sync_preferences/dual_layer_user_pref_store.h
      • M components/sync_preferences/dual_layer_user_pref_store_unittest.cc
      • M components/sync_preferences/pref_model_associator_unittest.cc
      • M components/sync_preferences/pref_service_syncable_unittest.cc
      • M components/sync_preferences/preferences_merge_helper.cc
      • M components/sync_preferences/preferences_merge_helper.h
      • M components/sync_preferences/preferences_merge_helper_unittest.cc
      • M components/touch_to_search/core/browser/contextual_search_delegate_impl.cc
      • M components/touch_to_search/core/browser/contextual_search_delegate_impl.h
      • M components/touch_to_search/core/browser/contextual_search_delegate_impl_unittest.cc
      • M components/tpcd/metadata/browser/manager.cc
      • M components/tracing/common/background_tracing_state_manager.cc
      • M components/tracing/common/background_tracing_state_manager_unittest.cc
      • M components/translate/core/browser/translate_infobar_delegate_unittest.cc
      • M components/translate/core/browser/translate_language_list.cc
      • M components/translate/core/browser/translate_prefs.cc
      • M components/translate/core/browser/translate_prefs.h
      • M components/translate/core/browser/translate_prefs_unittest.cc
      • M components/translate/ios/browser/translate_controller.h
      • M components/translate/ios/browser/translate_controller.mm
      • M components/translate/ios/browser/translate_controller_unittest.mm
      • M components/translate/ios/browser/translate_java_script_feature.mm
      • M components/translate/translate_internals/translate_internals_handler.cc
      • M components/translate/translate_internals/translate_internals_handler.h
      • M components/ukm/debug/ukm_debug_data_extractor.cc
      • M components/update_client/action_runner.cc
      • M components/update_client/action_runner.h
      • M components/update_client/component.cc
      • M components/update_client/component.h
      • M components/update_client/crx_cache.cc
      • M components/update_client/op_download.cc
      • M components/update_client/op_download.h
      • M components/update_client/op_download_unittest.cc
      • M components/update_client/op_install.cc
      • M components/update_client/op_install.h
      • M components/update_client/op_puffin.cc
      • M components/update_client/op_puffin.h
      • M components/update_client/op_puffin_unittest.cc
      • M components/update_client/op_xz.cc
      • M components/update_client/op_xz.h
      • M components/update_client/op_xz_unittest.cc
      • M components/update_client/op_zucchini.cc
      • M components/update_client/op_zucchini.h
      • M components/update_client/op_zucchini_unittest.cc
      • M components/update_client/persisted_data.cc
      • M components/update_client/ping_manager.cc
      • M components/update_client/ping_manager.h
      • M components/update_client/ping_manager_unittest.cc
      • M components/update_client/pipeline.cc
      • M components/update_client/pipeline.h
      • M components/update_client/pipeline_util.cc
      • M components/update_client/pipeline_util.h
      • M components/update_client/protocol_definition.h
      • M components/update_client/protocol_parser_json.cc
      • M components/update_client/protocol_serializer.cc
      • M components/update_client/protocol_serializer.h
      • M components/update_client/protocol_serializer_json.cc
      • M components/update_client/protocol_serializer_json_unittest.cc
      • M components/update_client/test_installer.cc
      • M components/update_client/update_checker_unittest.cc
      • M components/update_client/update_client_unittest.cc
      • M components/update_client/update_engine.cc
      • M components/update_client/utils.cc
      • M components/update_client/utils.h
      • M components/upload_list/text_log_upload_list.cc
      • M components/upload_list/text_log_upload_list.h
      • M components/url_matcher/url_matcher_factory.cc
      • M components/url_matcher/url_matcher_factory.h
      • M components/url_matcher/url_matcher_factory_unittest.cc
      • M components/url_matcher/url_util.cc
      • M components/url_matcher/url_util.h
      • M components/url_matcher/url_util_unittest.cc
      • M components/user_data_importer/ios/ios_bookmark_parser.mm
      • M components/user_education/common/help_bubble/help_bubble_params.h
      • M components/user_education/webui/mock_whats_new_storage_service.h
      • M components/user_education/webui/whats_new_registry.cc
      • M components/user_education/webui/whats_new_registry_feature_param_unittest.cc
      • M components/user_education/webui/whats_new_registry_unittest.cc
      • M components/user_education/webui/whats_new_storage_service.h
      • M components/user_manager/account_id_util.cc
      • M components/user_manager/account_id_util.h
      • M components/user_manager/account_id_util_unittest.cc
      • M components/user_manager/known_user.cc
      • M components/user_manager/known_user.h
      • M components/user_manager/known_user_unittest.cc
      • M components/user_manager/multi_user/multi_user_sign_in_policy_controller.cc
      • M components/user_manager/user_directory_integrity_manager.cc
      • M components/user_manager/user_manager_impl.cc
      • M components/user_manager/user_manager_impl.h
      • M components/value_store/leveldb_value_store.cc
      • M components/value_store/leveldb_value_store.h
      • M components/value_store/testing_value_store.cc
      • M components/value_store/testing_value_store.h
      • M components/value_store/value_store.cc
      • M components/value_store/value_store.h
      • M components/value_store/value_store_change.cc
      • M components/value_store/value_store_change_unittest.cc
      • M components/value_store/value_store_test_suite.cc
      • M components/variations/net/variations_command_line.cc
      • M components/variations/seed_reader_writer.cc
      • M components/variations/service/google_groups_manager.cc
      • M components/variations/service/google_groups_manager_unittest.cc
      • M components/variations/service/variations_field_trial_creator.cc
      • M components/variations/service/variations_field_trial_creator_unittest.cc
      • M components/variations/service/variations_service_unittest.cc
      • M components/visited_url_ranking/internal/url_grouping/group_suggestions_tracker.cc
      • M components/visited_url_ranking/internal/url_grouping/group_suggestions_tracker.h
      • M components/visited_url_ranking/internal/url_grouping/group_suggestions_tracker_unittest.cc
      • M components/viz/common/quads/render_pass_io.cc
      • M components/viz/common/quads/render_pass_io.h
      • M components/viz/common/quads/render_pass_io_unittest.cc
      • M components/viz/common/quads/texture_draw_quad.h
      • M components/viz/host/gpu_host_impl.cc
      • M components/viz/host/gpu_host_impl.h
      • M components/viz/service/debugger/viz_debugger.cc
      • M components/viz/service/debugger/viz_debugger.h
      • M components/viz/service/debugger/viz_debugger_unittests/viz_debugger_unittest_base.cc
      • M components/viz/service/display/surface_aggregator_perftest.cc
      • M components/viz/service/main/viz_main_impl.cc
      • M components/viz/service/main/viz_main_impl.h
      • M components/wallet/core/browser/network/wallet_http_client_impl.cc
      • M components/wallet/core/browser/network/wallet_http_client_impl_unittest.cc
      • M components/webapps/browser/banners/app_banner_settings_helper.cc
      • M components/webapps/isolated_web_apps/public/iwa_runtime_data_provider.cc
      • M components/webapps/isolated_web_apps/types/source.cc
      • M components/webapps/isolated_web_apps/types/storage_location.cc
      • M components/webapps/services/web_app_origin_association/web_app_origin_association_parser.cc
      • M components/webauthn/core/browser/remote_validation.cc
      • M components/webauthn/ios/passkey_java_script_feature.mm
      • M components/webauthn/ios/passkey_request_parser.h
      • M components/webauthn/ios/passkey_request_parser.mm
      • M components/webauthn/ios/passkey_request_parser_unittest.mm
      • M components/webauthn/json/value_conversions.cc
      • M components/webcrypto/algorithms/aes_cbc_unittest.cc
      • M components/webcrypto/algorithms/aes_kw_unittest.cc
      • M components/webcrypto/algorithms/ecdh_unittest.cc
      • M components/webcrypto/algorithms/ecdsa_unittest.cc
      • M components/webcrypto/algorithms/hmac_unittest.cc
      • M components/webcrypto/algorithms/rsa_oaep_unittest.cc
      • M components/webcrypto/algorithms/rsa_ssa_unittest.cc
      • M components/webcrypto/algorithms/sha_unittest.cc
      • M components/webcrypto/algorithms/test_helpers.cc
      • M components/webcrypto/algorithms/test_helpers.h
      • M components/webcrypto/jwk.cc
      • M components/webcrypto/jwk.h
      • M components/webui/flags/flags_state.cc
      • M components/webui/flags/flags_state.h
      • M components/webui/flags/flags_state_unittest.cc
      • M components/webui/flags/flags_test_helpers.cc
      • M components/webui/flags/pref_service_flags_storage.cc
      • M components/webui/version/version_handler_helper.cc
      • M components/webui/version/version_handler_helper.h
      • M components/wifi/fake_wifi_service.cc
      • M components/wifi/fake_wifi_service.h
      • M components/wifi/network_properties.cc
      • M components/wifi/network_properties.h
      • M components/wifi/wifi_service.h
      • M components/wifi/wifi_service_fuchsia.cc
      • M components/wifi/wifi_service_mac.mm
      • M components/wifi/wifi_service_win.cc
      • M components/wifi/wifi_test.cc
      • M components/zoom/page_zoom_constants.cc
      Change size: XL
      Delta: 452 files changed, 2643 insertions(+), 2727 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Daniel Cheng
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I203f7d91a5c8d3dc1bd5f3bc22d8144754122a66
      Gerrit-Change-Number: 7509893
      Gerrit-PatchSet: 3
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages