spanification: automatically spanify base/trace_event/heap_profiler_allocation_context.cc etc. [chromium/src : main]

0 views
Skip to first unread message

Roberto Torres (Gerrit)

unread,
Dec 12, 2025, 9:07:12 PM (8 days ago) Dec 12
to Siddhartha S, Stephen Nusko, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Siddhartha S and Stephen Nusko

Roberto Torres voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Siddhartha S
  • Stephen Nusko
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
Gerrit-Change-Number: 7256960
Gerrit-PatchSet: 1
Gerrit-Owner: Roberto Torres <jr...@google.com>
Gerrit-Reviewer: Roberto Torres <jr...@google.com>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
Gerrit-Attention: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Sat, 13 Dec 2025 02:07:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Nusko (Gerrit)

unread,
Dec 14, 2025, 10:34:22 PM (6 days ago) Dec 14
to Roberto Torres, Siddhartha S, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Roberto Torres and Siddhartha S

Stephen Nusko voted and added 1 comment

Votes added by Stephen Nusko

Code-Review+1

1 comment

File base/trace_event/heap_profiler_allocation_context.cc
Line 32, Patchset 1 (Latest): return lhs.frame_count == rhs.frame_count &&
base::span(lhs.frames).first(lhs.frame_count) ==
base::span(rhs.frames).first(rhs.frame_count);
Stephen Nusko . unresolved

can we just use

```
return std::ranges::equal(
   base::span(lhs.frames).first(lhs.frame_count),
   base::span(rhs.frames).first(rhs.frame_count));
```

Which will check that `lhs.frame_count == rhs.frame_count` as well?

As per https://en.cppreference.com/w/cpp/algorithm/ranges/equal.html

Open in Gerrit

Related details

Attention is currently required from:
  • Roberto Torres
  • Siddhartha S
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
Gerrit-Change-Number: 7256960
Gerrit-PatchSet: 1
Gerrit-Owner: Roberto Torres <jr...@google.com>
Gerrit-Reviewer: Roberto Torres <jr...@google.com>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Attention: Roberto Torres <jr...@google.com>
Gerrit-Attention: Siddhartha S <ss...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 03:33:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Siddhartha S (Gerrit)

unread,
Dec 15, 2025, 5:08:49 PM (5 days ago) Dec 15
to Roberto Torres, Siddhartha S, Stephen Nusko, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Roberto Torres

Siddhartha S voted and added 1 comment

Votes added by Siddhartha S

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Siddhartha S . resolved

Lgtm stamp

Open in Gerrit

Related details

Attention is currently required from:
  • Roberto Torres
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
    Gerrit-Change-Number: 7256960
    Gerrit-PatchSet: 1
    Gerrit-Owner: Roberto Torres <jr...@google.com>
    Gerrit-Reviewer: Roberto Torres <jr...@google.com>
    Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Attention: Roberto Torres <jr...@google.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 22:08:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Roberto Torres (Gerrit)

    unread,
    Dec 15, 2025, 7:32:24 PM (5 days ago) Dec 15
    to Siddhartha S, Stephen Nusko, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
    Attention needed from Siddhartha S and Stephen Nusko

    Roberto Torres added 1 comment

    File base/trace_event/heap_profiler_allocation_context.cc
    Line 32, Patchset 1: return lhs.frame_count == rhs.frame_count &&

    base::span(lhs.frames).first(lhs.frame_count) ==
    base::span(rhs.frames).first(rhs.frame_count);
    Stephen Nusko . resolved

    can we just use

    ```
    return std::ranges::equal(
       base::span(lhs.frames).first(lhs.frame_count),
       base::span(rhs.frames).first(rhs.frame_count));
    ```

    Which will check that `lhs.frame_count == rhs.frame_count` as well?

    As per https://en.cppreference.com/w/cpp/algorithm/ranges/equal.html

    Roberto Torres

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Siddhartha S
    • Stephen Nusko
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
      Gerrit-Change-Number: 7256960
      Gerrit-PatchSet: 2
      Gerrit-Owner: Roberto Torres <jr...@google.com>
      Gerrit-Reviewer: Roberto Torres <jr...@google.com>
      Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
      Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
      Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
      Gerrit-Attention: Siddhartha S <ss...@chromium.org>
      Gerrit-Comment-Date: Tue, 16 Dec 2025 00:32:14 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Stephen Nusko <nus...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Stephen Nusko (Gerrit)

      unread,
      Dec 15, 2025, 8:06:22 PM (5 days ago) Dec 15
      to Roberto Torres, Siddhartha S, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
      Attention needed from Roberto Torres and Siddhartha S

      Stephen Nusko voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Roberto Torres
      • Siddhartha S
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
        Gerrit-Change-Number: 7256960
        Gerrit-PatchSet: 2
        Gerrit-Owner: Roberto Torres <jr...@google.com>
        Gerrit-Reviewer: Roberto Torres <jr...@google.com>
        Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
        Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
        Gerrit-Attention: Roberto Torres <jr...@google.com>
        Gerrit-Attention: Siddhartha S <ss...@chromium.org>
        Gerrit-Comment-Date: Tue, 16 Dec 2025 01:05:56 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Siddhartha S (Gerrit)

        unread,
        Dec 15, 2025, 10:12:09 PM (5 days ago) Dec 15
        to Roberto Torres, Siddhartha S, Stephen Nusko, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
        Attention needed from Roberto Torres

        Siddhartha S voted

        Code-Review+1
        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Roberto Torres
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
          Gerrit-Change-Number: 7256960
          Gerrit-PatchSet: 2
          Gerrit-Owner: Roberto Torres <jr...@google.com>
          Gerrit-Reviewer: Roberto Torres <jr...@google.com>
          Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
          Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
          Gerrit-Attention: Roberto Torres <jr...@google.com>
          Gerrit-Comment-Date: Tue, 16 Dec 2025 03:12:00 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Chromium LUCI CQ (Gerrit)

          unread,
          Dec 15, 2025, 10:14:54 PM (5 days ago) Dec 15
          to Roberto Torres, Siddhartha S, Stephen Nusko, AyeAye, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org

          Chromium LUCI CQ submitted the change

          Change information

          Commit message:
          spanification: automatically spanify base/trace_event/heap_profiler_allocation_context.cc etc.

          This is the result of running the automatic spanification on linux and
          updating code to use and pass spans where size is known.

          The original patch was fully automated using script:
          //tools/clang/spanify/rewrite-multiple-platforms.sh -platforms=linux
          Then refined with gemini-cli

          gemini-run/batch-run-1761798078/group_85

          BUG=439964610
          Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
          Reviewed-by: Stephen Nusko <nus...@chromium.org>
          Auto-Submit: Roberto Torres <jr...@google.com>
          Reviewed-by: Siddhartha S <ss...@chromium.org>
          Commit-Queue: Siddhartha S <ss...@chromium.org>
          Cr-Commit-Position: refs/heads/main@{#1559112}
          Files:
          • M base/trace_event/heap_profiler_allocation_context.cc
          • M base/trace_event/heap_profiler_allocation_context.h
          Change size: S
          Delta: 2 files changed, 11 insertions(+), 7 deletions(-)
          Branch: refs/heads/main
          Submit Requirements:
          • requirement satisfiedCode-Review: +1 by Siddhartha S, +1 by Stephen Nusko
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I76c67ebefe0c454132998606526fc6945ed5d4e8
          Gerrit-Change-Number: 7256960
          Gerrit-PatchSet: 3
          Gerrit-Owner: Roberto Torres <jr...@google.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages