Joe Mason (Gerrit)

unread,

Apr 10, 2026, 3:37:21 PMApr 10

to Justin Novosad, android-bu...@system.gserviceaccount.com, Chromium IPC Reviews, Etienne Pierre-Doray, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Chromium IPC Reviews, Etienne Pierre-Doray and Justin Novosad

Joe Mason added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Joe Mason . resolved

No security concerns, but I'll wait for Etienne to review before I stamp the mojom.

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Etienne Pierre-Doray
Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Apr 10, 2026, 3:47:28 PMApr 10

to Justin Novosad, android-bu...@system.gserviceaccount.com, Chromium IPC Reviews, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Chromium IPC Reviews and Justin Novosad

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Etienne Pierre-Doray . resolved

Thanks, LGTM!
% missing update to tracing_sampler_profiler_unittest.cc

File services/tracing/public/mojom/perfetto_service.mojom

Line 13, Patchset 5 (Latest):

// Producer processes register with the format
// "kPerfettoProducerNamePrefix-PID" when connecting to Chrome's internal
// tracing service. Note that system producers use a different but similar
// naming scheme to disambiguate between different apps on the same system,
// see SystemProducer::ConnectToSystemService() implementations. Of

Etienne Pierre-Doray . unresolved

Remove stale comment.

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Apr 10, 2026, 3:55:57 PMApr 10

to Justin Novosad, Chromium IPC Reviews, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Justin Novosad

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): joenot...@google.com

Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Novosad (Gerrit)

unread,

Apr 10, 2026, 3:58:43 PMApr 10

to Chromium IPC Reviews, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Etienne Pierre-Doray

Justin Novosad added 1 comment

File services/tracing/public/mojom/perfetto_service.mojom

Line 13, Patchset 5:// Producer processes register with the format


// "kPerfettoProducerNamePrefix-PID" when connecting to Chrome's internal
// tracing service. Note that system producers use a different but similar
// naming scheme to disambiguate between different apps on the same system,
// see SystemProducer::ConnectToSystemService() implementations. Of

Etienne Pierre-Doray . resolved

Remove stale comment.

Justin Novosad

Done

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Apr 10, 2026, 4:03:38 PMApr 10

to Justin Novosad, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Justin Novosad

Etienne Pierre-Doray voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Novosad (Gerrit)

unread,

Apr 10, 2026, 5:42:22 PMApr 10

to Dave Tapuska, Hidehiko Abe, Etienne Pierre-Doray, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe and Justin Novosad

Justin Novosad voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Dave Tapuska
Etienne Pierre-Doray
Hidehiko Abe
Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

Apr 12, 2026, 10:49:05 PM (14 days ago) Apr 12

to Justin Novosad, Justin Cohen, Dave Tapuska, Etienne Pierre-Doray, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Dave Tapuska, Etienne Pierre-Doray, Justin Cohen and Justin Novosad

Hidehiko Abe added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Hidehiko Abe . resolved

the direction looking good, but could you fix bot failures?

Open in Gerrit

Related details

Attention is currently required from:

Dave Tapuska
Etienne Pierre-Doray
Justin Cohen
Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Apr 13, 2026, 10:58:00 AM (13 days ago) Apr 13

to Justin Novosad, Justin Cohen, Dave Tapuska, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Dave Tapuska, Justin Cohen and Justin Novosad

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Etienne Pierre-Doray . resolved

Still LGTM

Open in Gerrit

Related details

Attention is currently required from:

Dave Tapuska
Justin Cohen
Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joe Mason (Gerrit)

unread,

Apr 13, 2026, 5:49:02 PM (13 days ago) Apr 13

to Justin Novosad, Justin Cohen, Etienne Pierre-Doray, Dave Tapuska, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Dave Tapuska, Hidehiko Abe, Justin Cohen and Justin Novosad

Joe Mason voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Dave Tapuska
Hidehiko Abe
Justin Cohen
Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dave Tapuska (Gerrit)

unread,

Apr 13, 2026, 7:06:56 PM (13 days ago) Apr 13

to Justin Novosad, Justin Cohen, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Hidehiko Abe, Justin Cohen and Justin Novosad

Dave Tapuska voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Novosad (Gerrit)

unread,

Apr 14, 2026, 10:47:27 AM (12 days ago) Apr 14

to Justin Cohen, Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Hidehiko Abe and Justin Cohen

Justin Novosad voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe
Justin Cohen

satisfied_requirement

unsatisfied_requirement

open

diffy

Yury Khmel (Gerrit)

unread,

Apr 14, 2026, 2:41:48 PM (12 days ago) Apr 14

to Justin Novosad, Justin Cohen, Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Hidehiko Abe, Justin Cohen and Justin Novosad

Yury Khmel voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe
Justin Cohen
Justin Novosad

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Apr 14, 2026, 6:00:25 PM (12 days ago) Apr 14

to Justin Novosad, Justin Cohen, Yury Khmel, Dave Tapuska, Etienne Pierre-Doray, Hidehiko Abe, Chromium IPC Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, arc-review...@google.com, yhanada+...@chromium.org, hidehik...@chromium.org, devtools...@chromium.org, chrome-gr...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[iOS tracing] Move Perfetto data source names from mojom to C++ header

This CL relocates Perfetto data source and producer string constants
out of `perfetto_service.mojom` and into a new standalone C++ header
`perfetto_data_source_names.h`.

Moving these constants into a C++ header removes unnecessary Mojo
dependencies for consumers that only need the raw string constants to
identify data sources or tracks (such as on platforms like iOS where the
full Mojo-based tracing service is not built).

This CL was written in response to this review comment:
https://chromium-review.googlesource.com/c/chromium/src/+/7700720/comment/9a2f9535_3336d7dd/

Bug: 495937056

Low-Coverage-Reason: TRIVIAL_CHANGE in low coverage file services/tracing/public/cpp/perfetto/java_heap_profiler/java_heap_profiler_android.cc

Change-Id: I02a084e9dbcd7c01e3770151adb2d781b4e50fca

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748975

Reviewed-by: Joe Mason <joenot...@google.com>

Reviewed-by: Dave Tapuska <dtap...@chromium.org>

Reviewed-by: Yury Khmel <kh...@chromium.org>

Auto-Submit: Justin Novosad <ju...@chromium.org>

Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>

Commit-Queue: Yury Khmel <kh...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1614733}

Files:

M chrome/browser/ash/arc/tracing/arc_tracing_bridge.cc
M content/browser/devtools/protocol/tracing_handler.cc
M content/browser/tracing/cast_tracing_agent.cc
M content/browser/tracing/cros_tracing_agent.cc
M content/browser/tracing/tracing_end_to_end_browsertest.cc
M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
M services/tracing/perfetto/consumer_host_unittest.cc
M services/tracing/perfetto/perfetto_service.cc
M services/tracing/public/cpp/BUILD.gn
M services/tracing/public/cpp/perfetto/histogram_samples_data_source.cc
M services/tracing/public/cpp/perfetto/java_heap_profiler/java_heap_profiler_android.cc
M services/tracing/public/cpp/perfetto/metadata_data_source.cc
M services/tracing/public/cpp/perfetto/perfetto_config.cc
A services/tracing/public/cpp/perfetto/perfetto_data_source_names.h
M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.cc
M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler_unittest.cc
M services/tracing/public/cpp/system_metrics_sampler.cc
M services/tracing/public/cpp/trace_startup_config.cc
M services/tracing/public/mojom/perfetto_service.mojom

Change size: M

Delta: 19 files changed, 111 insertions(+), 93 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Joe Mason, +1 by Yury Khmel, +1 by Etienne Pierre-Doray, +1 by Dave Tapuska

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[iOS tracing] Move Perfetto data source names from mojom to C++ header [chromium/src : main]

Joe Mason (Gerrit)

Joe Mason added 1 comment

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

2 comments

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Justin Novosad (Gerrit)

Justin Novosad added 1 comment

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted Code-Review+1

Related details

Justin Novosad (Gerrit)

Justin Novosad voted Commit-Queue+1

Related details

Hidehiko Abe (Gerrit)

Hidehiko Abe added 1 comment

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

1 comment

Related details

Joe Mason (Gerrit)

Joe Mason voted Code-Review+1

Related details

Dave Tapuska (Gerrit)

Dave Tapuska voted Code-Review+1

Related details

Justin Novosad (Gerrit)

Justin Novosad voted Auto-Submit+1

Related details

Yury Khmel (Gerrit)

Yury Khmel voted

Related details

chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information