Drop k from public constant kUnprotectedInRelease. [chromium/src : main]

3 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Jul 16, 2026, 1:49:24 PMJul 16
to Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Stephen Nusko

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tom Sepez . resolved

Something I noticed while putting together test on previous CL.

Open in Gerrit

Related details

Attention is currently required from:
  • Stephen Nusko
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
Gerrit-Change-Number: 8109259
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Stephen Nusko <nus...@chromium.org>
Gerrit-Comment-Date: Thu, 16 Jul 2026 17:49:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Nusko (Gerrit)

unread,
Jul 17, 2026, 5:15:04 AMJul 17
to Tom Sepez, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Keishi Hattori and Tom Sepez

Stephen Nusko added 1 comment

Patchset-level comments
Stephen Nusko . resolved

+kei...@chromium.org for visibility. I don't know where you are in landing your final rewrite CLs, but probably makes sense to do this after you've landed so we get them all rather than having to edit all the split rewrite CLs? But your call since I'm not sure what the exact status of the CLs are.

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
Gerrit-Change-Number: 8109259
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jul 2026 09:14:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Jul 17, 2026, 12:45:44 PMJul 17
to Keishi Hattori, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Keishi Hattori

Tom Sepez voted and added 1 comment

Votes added by Tom Sepez

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tom Sepez . resolved

Split this CL in two, deprecate first remove later.

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
Gerrit-Change-Number: 8109259
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jul 2026 16:45:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Jul 17, 2026, 12:47:28 PMJul 17
to Keishi Hattori, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Keishi Hattori

Tom Sepez voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
Gerrit-Change-Number: 8109259
Gerrit-PatchSet: 5
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Jul 2026 16:47:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Nusko (Gerrit)

unread,
Jul 17, 2026, 1:55:26 PMJul 17
to Tom Sepez, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Keishi Hattori

Stephen Nusko voted and added 1 comment

Votes added by Stephen Nusko

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Stephen Nusko . resolved

LGTM sorry we're off in japan on Monday so lets wait for Keishi on Tuesday (your monday).

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
    Gerrit-Change-Number: 8109259
    Gerrit-PatchSet: 5
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
    Gerrit-Comment-Date: Fri, 17 Jul 2026 17:55:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Arthur Sonzogni (Gerrit)

    unread,
    Jul 20, 2026, 4:21:14 AMJul 20
    to Tom Sepez, Stephen Nusko, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Keishi Hattori and Tom Sepez

    Arthur Sonzogni voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keishi Hattori
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
    Gerrit-Change-Number: 8109259
    Gerrit-PatchSet: 5
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 08:20:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keishi Hattori (Gerrit)

    unread,
    Jul 21, 2026, 1:29:50 PMJul 21
    to Tom Sepez, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Tom Sepez

    Keishi Hattori voted and added 1 comment

    Votes added by Keishi Hattori

    Code-Review+1

    1 comment

    Patchset-level comments
    Keishi Hattori . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Sepez
    Gerrit-Comment-Date: Tue, 21 Jul 2026 17:29:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Sepez (Gerrit)

    unread,
    Jul 21, 2026, 2:08:57 PMJul 21
    to Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Daniel Cheng

    Tom Sepez added 1 comment

    Patchset-level comments
    Tom Sepez . resolved

    Need +OO from one of y'all.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
    Gerrit-Change-Number: 8109259
    Gerrit-PatchSet: 5
    Gerrit-Owner: Tom Sepez <tse...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
    Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Jul 2026 18:08:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Jul 21, 2026, 2:10:57 PMJul 21
    to Tom Sepez, Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Tom Sepez

    Daniel Cheng added 2 comments

    Patchset-level comments
    Daniel Cheng . unresolved

    Arguably the lack of a k prefix on the other constants is a style guide violation, no?

    File base/memory/raw_ptr_asan_service.cc
    Line 450, Patchset 5 (Latest): case ProtectionStatus::UnprotectedInRelease:
    Daniel Cheng . unresolved

    This looks inconsistent now?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Sepez
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
      Gerrit-Change-Number: 8109259
      Gerrit-PatchSet: 5
      Gerrit-Owner: Tom Sepez <tse...@chromium.org>
      Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
      Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Tom Sepez <tse...@chromium.org>
      Gerrit-Comment-Date: Tue, 21 Jul 2026 18:10:43 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Tom Sepez (Gerrit)

      unread,
      Jul 21, 2026, 2:26:00 PMJul 21
      to Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
      Attention needed from Daniel Cheng

      Tom Sepez voted and added 2 comments

      Votes added by Tom Sepez

      Commit-Queue+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 5:
      Daniel Cheng . resolved

      Arguably the lack of a k prefix on the other constants is a style guide violation, no?

      Tom Sepez

      Yep, but this is in some sense type information, so I guess that's why the omitted it.

      File base/memory/raw_ptr_asan_service.cc
      Line 450, Patchset 5: case ProtectionStatus::UnprotectedInRelease:
      Daniel Cheng . resolved

      This looks inconsistent now?

      Tom Sepez

      Seems like a stray edit. Done.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
        Gerrit-Change-Number: 8109259
        Gerrit-PatchSet: 6
        Gerrit-Owner: Tom Sepez <tse...@chromium.org>
        Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
        Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
        Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
        Gerrit-CC: Stephen Chenney <sche...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Tue, 21 Jul 2026 18:25:50 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Daniel Cheng (Gerrit)

        unread,
        Jul 21, 2026, 4:48:43 PMJul 21
        to Tom Sepez, Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
        Attention needed from Tom Sepez

        Daniel Cheng voted and added 1 comment

        Votes added by Daniel Cheng

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 6 (Latest):
        Daniel Cheng . resolved

        LGTM

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Tom Sepez
        Gerrit-Attention: Tom Sepez <tse...@chromium.org>
        Gerrit-Comment-Date: Tue, 21 Jul 2026 20:48:28 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Daniel Cheng (Gerrit)

        unread,
        Jul 21, 2026, 4:48:59 PMJul 21
        to Tom Sepez, Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
        Attention needed from Tom Sepez

        Daniel Cheng voted Owners-Override+1

        Owners-Override+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Tom Sepez
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        Gerrit-Comment-Date: Tue, 21 Jul 2026 20:48:45 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Tom Sepez (Gerrit)

        unread,
        Jul 21, 2026, 7:45:54 PMJul 21
        to Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

        Tom Sepez voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Gerrit-Comment-Date: Tue, 21 Jul 2026 23:45:42 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Tom Sepez (Gerrit)

        unread,
        Jul 21, 2026, 10:39:29 PMJul 21
        to Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org
        Gerrit-Comment-Date: Wed, 22 Jul 2026 02:39:14 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jul 21, 2026, 11:34:03 PMJul 21
        to Tom Sepez, Daniel Cheng, Keishi Hattori, Arthur Sonzogni, Stephen Nusko, Akihiro Ota, chromium...@chromium.org, Dirk Schulze, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Sadrul Chowdhury, Stephen Chenney, abigailbk...@google.com, bartek...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fdoray...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, geoffla...@chromium.org, jdeblas...@chromium.org, jessemcke...@google.com, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lize...@chromium.org, lizeb...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Drop k from public constant kUnprotectedInRelease.

        None of the other public constants have the k-prefix, although raw_ptr
        uses k-prefix constants internally.

        Provides duplicate constant so that a one-line follow-on change can
        remove the deprecated form (for easy revert if needed).
        Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
        Reviewed-by: Keishi Hattori <kei...@chromium.org>
        Owners-Override: Daniel Cheng <dch...@chromium.org>
        Reviewed-by: Daniel Cheng <dch...@chromium.org>
        Reviewed-by: Stephen Nusko <nus...@chromium.org>
        Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
        Commit-Queue: Tom Sepez <tse...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1665998}
        Files:
        • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr.h
        • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_hookable_impl.h
        • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_unittest.cc
        • M base/location.h
        • M base/memory/raw_ptr_asan_service.cc
        • M base/memory/raw_ptr_asan_service.h
        • M base/memory/raw_ptr_asan_unittest.cc
        • M base/message_loop/message_pump.h
        • M base/message_loop/message_pump_epoll.h
        • M base/pickle.h
        • M base/task/common/task_annotator.h
        • M base/task/sequence_manager/work_queue.h
        • M base/task/sequence_manager/work_queue_sets.h
        • M base/task/sequence_manager/work_tracker.h
        • M base/task/sequenced_task_runner.h
        • M base/task/single_thread_task_runner.h
        • M base/task/thread_pool/task_source.h
        • M base/task/thread_pool/thread_group.h
        • M base/trace_event/typed_macros_embedder_support.h
        • M components/feedback/redaction_tool/url_canon_stdstring.h
        • M components/site_engagement/content/site_engagement_score.h
        • M extensions/browser/lazy_context_task_queue.h
        • M gpu/command_buffer/client/client_shared_image.h
        • M gpu/command_buffer/service/passthrough_program_cache.h
        • M gpu/command_buffer/service/scheduler.h
        • M gpu/command_buffer/service/shared_image/shared_image_backing.h
        • M gpu/command_buffer/service/shared_image/shared_image_representation.h
        • M third_party/blink/renderer/platform/graphics/memory_managed_paint_recorder.h
        • M ui/accelerated_widget_mac/ca_renderer_layer_tree.h
        • M ui/accessibility/ax_tree_serializer.h
        • M url/url_canon_stdstring.h
        Change size: M
        Delta: 31 files changed, 107 insertions(+), 105 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Keishi Hattori, +1 by Stephen Nusko, +1 by Daniel Cheng, +1 by Arthur Sonzogni
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I66aaaf7be473f66524805339a27374535e4f6832
        Gerrit-Change-Number: 8109259
        Gerrit-PatchSet: 7
        Gerrit-Owner: Tom Sepez <tse...@chromium.org>
        Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
        Gerrit-Reviewer: Stephen Nusko <nus...@chromium.org>
        Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages