[tracing] Fix privacy_filtering_enabled in cloned sessions [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
May 13, 2026, 11:59:01 AM (8 days ago) May 13
to Mikhail Khokhlov, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Chromium IPC Reviews and Mikhail Khokhlov
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
May 13, 2026, 12:06:35 PM (8 days ago) May 13
to Etienne Pierre-Doray, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Giovanni Ortuno Urquidi and Mikhail Khokhlov
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ort...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ort...@chromium.org
Reviewer source(s):
ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Giovanni Ortuno Urquidi
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
May 13, 2026, 12:59:10 PM (8 days ago) May 13
to Etienne Pierre-Doray, Chromium IPC Reviews, Giovanni Ortuno Urquidi, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Giovanni Ortuno Urquidi
Mikhail Khokhlov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Giovanni Ortuno Urquidi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Ortuno Urquidi (Gerrit)
May 13, 2026, 1:21:48 PM (8 days ago) May 13
to Etienne Pierre-Doray, Giovanni Ortuno Urquidi, Mikhail Khokhlov, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Giovanni Ortuno Urquidi voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 13, 2026, 1:25:32 PM (8 days ago) May 13
to Giovanni Ortuno Urquidi, Mikhail Khokhlov, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 13, 2026, 1:32:04 PM (8 days ago) May 13
to Etienne Pierre-Doray, Giovanni Ortuno Urquidi, Mikhail Khokhlov, Chromium IPC Reviews, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Fix privacy_filtering_enabled in cloned sessions
privacy_filtering_enabled plumbing was incorrect because it
infered from uninitialized trace_config_ in a cloned session.
This CL fixes this by peeking PerfettoService::tracing_sessions_
identified by unique_session_name; a clone session will always
be identified by its unique_session_name.
This is a privacy bug, but its impact is limited because we don't
collect traces using cloning in the field.
Change-Id: I9b83abc0d2b0ec015eb9c410cebe66f979a634b7
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1630068}
Files:
- M services/tracing/perfetto/consumer_host.cc
- M services/tracing/perfetto/consumer_host.h
- M services/tracing/perfetto/perfetto_service.cc
- M services/tracing/perfetto/perfetto_service.h
- M services/tracing/public/cpp/perfetto/perfetto_tracing_backend.cc
- M services/tracing/public/mojom/perfetto_service.mojom
Change size: S
Delta: 6 files changed, 24 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Giovanni Ortuno Urquidi, +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages