Use SplitStringPiece and string_view in TraceConfig parsing. [chromium/src : main]

1 view
Skip to first unread message

Siddhartha S (Gerrit)

unread,
Jun 3, 2026, 1:07:33 AM (8 days ago) Jun 3
to Jeffrey Yu, Siddhartha S, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Jeffrey Yu

Siddhartha S voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9b6ae7d1de8e07ba4b5ca4bcd50d599ebe3535c6
Gerrit-Change-Number: 7891848
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jun 2026 05:07:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jeffrey Yu (Gerrit)

unread,
Jun 3, 2026, 11:36:06 AM (8 days ago) Jun 3
to Lei Zhang, Siddhartha S, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Lei Zhang

Jeffrey Yu voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9b6ae7d1de8e07ba4b5ca4bcd50d599ebe3535c6
Gerrit-Change-Number: 7891848
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jun 2026 15:35:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 3, 2026, 12:19:46 PM (8 days ago) Jun 3
to Jeffrey Yu, Lei Zhang, Siddhartha S, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Jeffrey Yu

Lei Zhang voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b6ae7d1de8e07ba4b5ca4bcd50d599ebe3535c6
    Gerrit-Change-Number: 7891848
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
    Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Comment-Date: Wed, 03 Jun 2026 16:19:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 3, 2026, 2:59:49 PM (8 days ago) Jun 3
    to Jeffrey Yu, Lei Zhang, Siddhartha S, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Use SplitStringPiece and string_view in TraceConfig parsing.

    Splitting to string_view instead of string avoids unnecessary string
    copies.
    Bug: 501076278
    Change-Id: I9b6ae7d1de8e07ba4b5ca4bcd50d599ebe3535c6
    Auto-Submit: Jeffrey Yu <yu...@chromium.org>
    Reviewed-by: Siddhartha S <ss...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Commit-Queue: Lei Zhang <the...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1641095}
    Files:
    • M base/trace_event/trace_config.cc
    Change size: S
    Delta: 1 file changed, 7 insertions(+), 7 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Siddhartha S, +1 by Lei Zhang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b6ae7d1de8e07ba4b5ca4bcd50d599ebe3535c6
    Gerrit-Change-Number: 7891848
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Siddhartha S <ss...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages