Use SplitStringPiece and string_view in TraceConfig parsing. [chromium/src : main]
1 view
Skip to first unread message
Siddhartha S (Gerrit)
Jun 3, 2026, 1:07:33 AM (8 days ago) Jun 3
to Jeffrey Yu, Siddhartha S, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Jeffrey Yu
Siddhartha S voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Jun 3, 2026, 11:36:06 AM (8 days ago) Jun 3
to Lei Zhang, Siddhartha S, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Lei Zhang
Jeffrey Yu voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 3, 2026, 12:19:46 PM (8 days ago) Jun 3
to Jeffrey Yu, Lei Zhang, Siddhartha S, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Jeffrey Yu
Lei Zhang voted![]( "Open in Gerrit")
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 3, 2026, 2:59:49 PM (8 days ago) Jun 3
to Jeffrey Yu, Lei Zhang, Siddhartha S, android-bu...@system.gserviceaccount.com, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Use SplitStringPiece and string_view in TraceConfig parsing.
Splitting to string_view instead of string avoids unnecessary string
copies.
Bug: 501076278
Change-Id: I9b6ae7d1de8e07ba4b5ca4bcd50d599ebe3535c6
Auto-Submit: Jeffrey Yu <yu...@chromium.org>
Reviewed-by: Siddhartha S <ss...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1641095}
Files:
- M base/trace_event/trace_config.cc
Change size: S
Delta: 1 file changed, 7 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Siddhartha S, +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages