Disable WebUI omnibox Features in failing tests. [chromium/src : main]
1 view
Skip to first unread message
Tibor Goldschwendt (Gerrit)
Jul 29, 2026, 5:01:31 PM (7 days ago) Jul 29
to Justin Donnelly, Etienne Pierre-Doray, Riley Tatum, Fabio Tirelo, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray, Fabio Tirelo, Justin Donnelly and Riley Tatum
Tibor Goldschwendt voted and added 2 comments![]( "Open in Gerrit")
Votes added by Tibor Goldschwendt
| Code-Review | +1 |
2 comments
Commit Message
Line 1, Patchset 1 (Latest):
Parent: 5e7ea61d (Update Win toolchain to SDK 10.0.28000.2270)Tibor Goldschwendt . unresolved
Please remove the trailing period from the subject line. Also, 'features' should be lowercase: 'Disable WebUI omnibox features in failing tests'
Line 3, Patchset 1 (Latest):
AuthorDate: 2026-07-29 20:54:45 +0000Tibor Goldschwendt . unresolved
Consider rephrasing to avoid 'I' and use imperative mood or passive voice. E.g., 'Missed these when disabling the features in all the tests in...'
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Fabio Tirelo
- Justin Donnelly
- Riley Tatum
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tibor Goldschwendt (Gerrit)
Jul 29, 2026, 5:02:25 PM (7 days ago) Jul 29
to Justin Donnelly, Etienne Pierre-Doray, Riley Tatum, Fabio Tirelo, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray, Fabio Tirelo, Justin Donnelly and Riley Tatum
Tibor Goldschwendt added 2 comments![]( "Open in Gerrit")
Commit Message
Line 1, Patchset 1 (Latest):
Parent: 5e7ea61d (Update Win toolchain to SDK 10.0.28000.2270)Tibor Goldschwendt . resolved
Please remove the trailing period from the subject line. Also, 'features' should be lowercase: 'Disable WebUI omnibox features in failing tests'
Tibor Goldschwendt
Ignore. My agent did that :D
Line 3, Patchset 1 (Latest):
AuthorDate: 2026-07-29 20:54:45 +0000Tibor Goldschwendt . resolved
Consider rephrasing to avoid 'I' and use imperative mood or passive voice. E.g., 'Missed these when disabling the features in all the tests in...'
Tibor Goldschwendt
Ignore. My agent did that :D
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Fabio Tirelo
- Justin Donnelly
- Riley Tatum
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jul 29, 2026, 6:10:25 PM (7 days ago) Jul 29
to Justin Donnelly, Fabio Tirelo, Riley Tatum, Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Fabio Tirelo, Justin Donnelly and Riley Tatum
Etienne Pierre-Doray voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Fabio Tirelo
- Justin Donnelly
- Riley Tatum
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Donnelly (Gerrit)
Jul 29, 2026, 6:17:47 PM (7 days ago) Jul 29
to Justin Donnelly, Etienne Pierre-Doray, Fabio Tirelo, Riley Tatum, Tibor Goldschwendt, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Fabio Tirelo and Riley Tatum
Justin Donnelly voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Fabio Tirelo
- Riley Tatum
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 29, 2026, 6:55:23 PM (7 days ago) Jul 29
to Justin Donnelly, Etienne Pierre-Doray, Fabio Tirelo, Riley Tatum, Tibor Goldschwendt, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Disable WebUI omnibox Features in failing tests.
I seem to have missed these when disabling the Features in all the tests
in https://crrev.com/c/8168560.
Bug: b:452061489
Change-Id: If19bfcf98c0032decf6b000851241bd05b72ddd2
Reviewed-by: Tibor Goldschwendt <tib...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Justin Donnelly <jdon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1670658}
Files:
- M chrome/browser/default_browser/default_browser_manager_browsertest.cc
- M chrome/test/data/webui/contextual_tasks/contextual_tasks_pixel_interactive_ui_test.cc
- M content/browser/tracing/startup_tracing_browsertest.cc
Change size: S
Delta: 3 files changed, 19 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray, +1 by Tibor Goldschwendt
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages