Benoit Lize (Gerrit)

unread,

Oct 28, 2025, 6:42:50 AM (13 days ago) Oct 28

to Egor Pasko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Egor Pasko

Benoit Lize voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Egor Pasko

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Egor Pasko (Gerrit)

unread,

Oct 28, 2025, 9:21:16 AM (13 days ago) Oct 28

to Benoit Lize, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Benoit Lize

Egor Pasko voted and added 1 comment

Votes added by Egor Pasko

Code-Review

+1

1 comment

File tools/metrics/histograms/metadata/memory/histograms.xml

Line 132, Patchset 2 (Latest):

      summary="Only counting memory used by Java heap in Android. This is the
               heap size, not actual allocated memory from the app. See

Egor Pasko . unresolved

My inner perfectionist says this remains confusing to read :/

The metric reports difference between Java totalMemory() and freeMemory(). Can we say that explicitly in the doc? I believe this simple formula explains the matter quicker than references to live objects, the way GC works and the differences with v8.

Overall what I learned today:

The word 'heap' is ambiguous, the part 'allocated_objects' is a lie. Ideally we should rename them, but I am not sure what changes in tooling that would involve. Clarification LGTM with those nits above.

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Benoit Lize (Gerrit)

unread,

Oct 28, 2025, 12:00:58 PM (13 days ago) Oct 28

to Egor Pasko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Benoit Lize added 2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Benoit Lize . resolved

Thanks!

File tools/metrics/histograms/metadata/memory/histograms.xml

Line 132, Patchset 2: summary="Only counting memory used by Java heap in Android. This is the


               heap size, not actual allocated memory from the app. See

Egor Pasko . resolved

My inner perfectionist says this remains confusing to read :/
The metric reports difference between Java totalMemory() and freeMemory(). Can we say that explicitly in the doc? I believe this simple formula explains the matter quicker than references to live objects, the way GC works and the differences with v8.
Overall what I learned today:
The word 'heap' is ambiguous, the part 'allocated_objects' is a lie. Ideally we should rename them, but I am not sure what changes in tooling that would involve. Clarification LGTM with those nits above.

Benoit Lize

The metric reports totalMemory(), not totalMemory() - freeMemory(). This would be another metric that I was considering adding, but that would not provide a lot of value for the reasons above.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Egor Pasko (Gerrit)

unread,

Oct 28, 2025, 1:39:45 PM (13 days ago) Oct 28

to Benoit Lize, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Benoit Lize

Egor Pasko voted and added 2 comments

Votes added by Egor Pasko

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Egor Pasko . resolved

still lgtm

File tools/metrics/histograms/metadata/memory/histograms.xml

Line 132, Patchset 2:

      summary="Only counting memory used by Java heap in Android. This is the
               heap size, not actual allocated memory from the app. See

Egor Pasko . resolved

My inner perfectionist says this remains confusing to read :/
The metric reports difference between Java totalMemory() and freeMemory(). Can we say that explicitly in the doc? I believe this simple formula explains the matter quicker than references to live objects, the way GC works and the differences with v8.
Overall what I learned today:
The word 'heap' is ambiguous, the part 'allocated_objects' is a lie. Ideally we should rename them, but I am not sure what changes in tooling that would involve. Clarification LGTM with those nits above.

Benoit Lize

The metric reports totalMemory(), not totalMemory() - freeMemory(). This would be another metric that I was considering adding, but that would not provide a lot of value for the reasons above.

Egor Pasko

sorry, I was thinking it is about another metric. Saying that it is totalMemory() would be better then.

Open in Gerrit

Related details

Attention is currently required from:

Benoit Lize

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Benoit Lize (Gerrit)

unread,

Oct 29, 2025, 4:50:22 AM (12 days ago) Oct 29

to Egor Pasko, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Benoit Lize voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 29, 2025, 4:55:58 AM (12 days ago) Oct 29

to Benoit Lize, Egor Pasko, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[android] Document Java heap metrics

Bug: b:455782509

Change-Id: I4f4ff411bbc4ac4d76ad23b1a9854f75625c7c37

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7089536

Reviewed-by: Egor Pasko <pa...@chromium.org>

Commit-Queue: Benoit Lize <li...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1537171}

Files:

M base/trace_event/java_heap_dump_provider_android.cc
M tools/metrics/histograms/metadata/memory/histograms.xml

Change size: S

Delta: 2 files changed, 17 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Egor Pasko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[android] Document Java heap metrics [chromium/src : main]

Benoit Lize (Gerrit)

Benoit Lize voted Commit-Queue+1

Related details

Egor Pasko (Gerrit)

Egor Pasko voted and added 1 comment

Votes added by Egor Pasko

1 comment

Related details

Benoit Lize (Gerrit)

Benoit Lize added 2 comments

Related details

Egor Pasko (Gerrit)

Egor Pasko voted and added 2 comments

Votes added by Egor Pasko

2 comments

Related details

Benoit Lize (Gerrit)

Benoit Lize voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information