etw-stackwalk: handle null EtwConsumer [chromium/src : main]

2 views
Skip to first unread message

Jesse McKenna (Gerrit)

unread,
Jun 18, 2026, 7:55:23 PMJun 18
to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Jesse McKenna added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jesse McKenna . resolved

PTAL, thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I398465375be3cbbf3809c6c4b2121c8bd2a2b9af
Gerrit-Change-Number: 7965977
Gerrit-PatchSet: 1
Gerrit-Owner: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Jun 2026 23:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jun 19, 2026, 11:20:06 AMJun 19
to Jesse McKenna, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Jesse McKenna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I398465375be3cbbf3809c6c4b2121c8bd2a2b9af
Gerrit-Change-Number: 7965977
Gerrit-PatchSet: 1
Gerrit-Owner: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Jesse McKenna <jessem...@google.com>
Gerrit-Comment-Date: Fri, 19 Jun 2026 15:19:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 19, 2026, 11:55:42 AMJun 19
to Jesse McKenna, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
etw-stackwalk: handle null EtwConsumer

The EtwConsumer member of EtwSystemDataSource can be null. This change
handles this possibility to prevent a null dereference.
Bug: 524753236, 400769265
Change-Id: I398465375be3cbbf3809c6c4b2121c8bd2a2b9af
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1649698}
Files:
  • M components/tracing/common/etw_system_data_source_win.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I398465375be3cbbf3809c6c4b2121c8bd2a2b9af
Gerrit-Change-Number: 7965977
Gerrit-PatchSet: 2
Gerrit-Owner: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages