[DO NOT SUBMIT] compare results of new clang-format [chromium/src : main]

0 views
Skip to first unread message

Yue She (Gerrit)

unread,
May 21, 2026, 4:08:08 PMMay 21
to SLSA Policy Verification Service, chromium...@chromium.org, Kentaro Hara, Sean Maher, Thiabaud Engelbrecht, agriev...@chromium.org, asvitki...@chromium.org, bartek...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, security-...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Yue She added 1 comment

File base/i18n/utf8_validator_tables.cc
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I38410b1d3f908e4e96a1dc3d6fd23a06dfb56c4a
Gerrit-Change-Number: 7867861
Gerrit-PatchSet: 2
Gerrit-Owner: Yue She <yue...@google.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Sean Maher <sp...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Thu, 21 May 2026 20:08:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hans Wennborg (Gerrit)

unread,
May 22, 2026, 9:41:57 AMMay 22
to Thiabaud Engelbrecht, chromium...@chromium.org, SLSA Policy Verification Service, Sean Maher, Kentaro Hara, agriev...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, roblia...@chromium.org, torne...@chromium.org, bartek...@chromium.org, lizeb...@chromium.org, lize...@chromium.org, pasko...@chromium.org, security-...@chromium.org, chromiumme...@microsoft.com, jessemcke...@google.com, jshin...@chromium.org, tracing...@chromium.org, yfriedm...@chromium.org, fdoray...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, nyquis...@chromium.org, mac-r...@chromium.org, gab+...@chromium.org, asvitki...@chromium.org, grt+...@chromium.org, Hans Wennborg
Attention needed from Yue She

Yue She has uploaded the change for review

Commit message

[DO NOT SUBMIT] compare results of new clang-format
Change-Id: I38410b1d3f908e4e96a1dc3d6fd23a06dfb56c4a

Change diff


Change information

Files:
  • M DEPS
  • M base/allocator/partition_alloc_features.h
  • M base/allocator/partition_alloc_support.cc
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager.h
  • M base/allocator/partition_allocator/src/partition_alloc/page_allocator_internals_posix.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/apple/scoped_cftyperef.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/numerics/checked_math.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/numerics/checked_math_impl.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/numerics/clamped_math_impl.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/numerics/safe_conversions_impl.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/system/sys_info_mac.mm
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_posix.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_perftest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_dcheck_helper.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_lock.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_page.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_root.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_superpage_extent_entry.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_tls_win.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_interception_apple.mm
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_alloc_token_symbols.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_alloc_token_symbols_apple.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_internals.h
  • M base/allocator/partition_allocator/src/partition_alloc/spinning_mutex.cc
  • M base/android/command_line_android.h
  • M base/android/library_loader/library_loader_hooks.cc
  • M base/android/library_loader/library_prefetcher_hooks.cc
  • M base/android/linker/ashmem.cc
  • M base/android/linker/linker_jni.cc
  • M base/android/pre_freeze_background_memory_trimmer.h
  • M base/android/scoped_hardware_buffer_handle.cc
  • M base/barrier_callback.h
  • M base/containers/span_reader.h
  • M base/debug/asan_invalid_access.cc
  • M base/debug/debugger_posix.cc
  • M base/feature_internal.h
  • M base/feature_list.h
  • M base/files/dir_reader_linux.h
  • M base/files/file_descriptor_watcher_posix_unittest.cc
  • M base/files/file_path.cc
  • M base/files/file_path_unittest.cc
  • M base/files/file_util_unittest.cc
  • M base/files/memory_mapped_file_unittest.cc
  • M base/files/os_validation_win_unittest.cc
  • M base/files/scoped_file_linux.cc
  • M base/functional/bind_unittest.cc
  • M base/functional/callback_internal.h
  • M base/functional/function_ref_unittest.cc
  • M base/i18n/streaming_utf8_validator_unittest.cc
  • M base/i18n/utf8_validator_tables.cc
  • M base/json/json_reader.cc
  • M base/json/json_value_converter.h
  • M base/json/json_writer_unittest.cc
  • M base/lazy_instance.h
  • M base/logging_chromeos.cc
  • M base/memory/discardable_shared_memory.cc
  • M base/memory/memory_pressure_listener.cc
  • M base/memory/raw_ptr_asan_unittest.cc
  • M base/memory/ref_counted_memory_unittest.cc
  • M base/memory/safe_ref_unittest.cc
  • M base/memory/shared_memory_switch_unittest.cc
  • M base/memory/singleton_unittest.cc
  • M base/memory/weak_auto_reset.h
  • M base/memory/weak_ptr_unittest.cc
  • M base/metrics/crc32.cc
  • M base/metrics/dummy_histogram.cc
  • M base/metrics/histogram_threadsafe_unittest.cc
  • M base/metrics/metrics_hashes_unittest.cc
  • M base/metrics/statistics_recorder.cc
  • M base/metrics/statistics_recorder.h
  • M base/nix/xdg_util.cc
  • M base/numerics/checked_math.h
  • M base/numerics/safe_conversions_impl.h
  • M base/observer_list_threadsafe_unittest.cc
  • M base/parameter_pack.h
  • M base/process/launch_mac.cc
  • M base/process/launch_unittest_win.cc
  • M base/process/process_unittest.cc
  • M base/profiler/chrome_unwinder_android_32.cc
  • M base/profiler/chrome_unwinder_android_32_unittest.cc
  • M base/profiler/metadata_recorder.cc
  • M base/run_loop_unittest.cc
  • M base/scoped_generic.h
  • M base/sequence_checker_impl.h
  • M base/strings/utf_offset_string_conversions_unittest.cc
  • M base/substring_set_matcher/substring_set_matcher.h
  • M base/sync_socket_unittest.cc
  • M base/synchronization/lock_impl_posix.cc
  • M base/synchronization/lock_unittest.cc
  • M base/task/scoped_set_task_priority_for_current_thread.h
  • M base/task/sequence_manager/work_queue_unittest.cc
  • M base/task/thread_pool/task_source_sort_key.cc
  • M base/test/gmock_expected_support_unittest.cc
  • M base/test/metrics/histogram_tester.cc
  • M base/test/metrics/histogram_tester.h
  • M base/test/rectify_callback_internal.h
  • M base/test/scoped_feature_list_unittest.cc
  • M base/test/test_suite.cc
  • M base/test/test_timeouts.cc
  • M base/test/tracing/trace_event_analyzer_unittest.cc
  • M base/third_party/cityhash/city.cc
  • M base/third_party/cityhash/city.h
  • M base/third_party/cityhash_v103/src/city_v103.cc
  • M base/third_party/cityhash_v103/src/city_v103.h
  • M base/third_party/double_conversion/double-conversion/bignum-dtoa.cc
  • M base/third_party/double_conversion/double-conversion/bignum-dtoa.h
  • M base/third_party/double_conversion/double-conversion/bignum.cc
  • M base/third_party/double_conversion/double-conversion/bignum.h
  • M base/third_party/double_conversion/double-conversion/cached-powers.cc
  • M base/third_party/double_conversion/double-conversion/cached-powers.h
  • M base/third_party/double_conversion/double-conversion/diy-fp.h
  • M base/third_party/double_conversion/double-conversion/double-conversion.h
  • M base/third_party/double_conversion/double-conversion/double-to-string.cc
  • M base/third_party/double_conversion/double-conversion/double-to-string.h
  • M base/third_party/double_conversion/double-conversion/fast-dtoa.cc
  • M base/third_party/double_conversion/double-conversion/fixed-dtoa.cc
  • M base/third_party/double_conversion/double-conversion/fixed-dtoa.h
  • M base/third_party/double_conversion/double-conversion/ieee.h
  • M base/third_party/double_conversion/double-conversion/string-to-double.cc
  • M base/third_party/double_conversion/double-conversion/string-to-double.h
  • M base/third_party/double_conversion/double-conversion/strtod.cc
  • M base/third_party/double_conversion/double-conversion/utils.h
  • M base/third_party/icu/icu_utf.h
  • M base/third_party/nspr/prtime.cc
  • M base/third_party/nspr/prtime.h
  • M base/third_party/superfasthash/superfasthash.c
  • M base/third_party/symbolize/demangle.cc
  • M base/third_party/symbolize/symbolize.cc
  • M base/third_party/symbolize/symbolize.h
  • M base/third_party/xdg_user_dirs/xdg_user_dir_lookup.cc
  • M base/third_party/xdg_user_dirs/xdg_user_dir_lookup.h
  • M base/threading/hang_watcher_unittest.cc
  • M base/threading/scoped_blocking_call_unittest.cc
  • M base/threading/sequence_local_storage_map.h
  • M base/threading/thread_collision_warner_unittest.cc
  • M base/threading/thread_local_storage_unittest.cc
  • M base/threading/thread_local_storage_win.cc
  • M base/threading/thread_restrictions.h
  • M base/time/time.h
  • M base/time/time_win.cc
  • M base/tools_sanity_unittest.cc
  • M base/trace_event/base_tracing_forward.h
  • M base/trace_event/trace_buffer.cc
  • M base/trace_event/trace_buffer.h
  • M base/trace_event/trace_event.h
  • M base/trace_event/trace_event_unittest.cc
  • M base/types/expected_macros_perftest.cc
  • M base/types/optional_unittest.cc
  • M base/types/strong_alias_unittest.cc
  • M base/win/com_init_check_hook_unittest.cc
  • M base/win/variant_conversions.h
  • M base/win/win_util.h
  • M buildtools/DEPS
Change size: XL
Delta: 154 files changed, 3473 insertions(+), 3096 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Yue She
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I38410b1d3f908e4e96a1dc3d6fd23a06dfb56c4a
Gerrit-Change-Number: 7867861
Gerrit-PatchSet: 2
Gerrit-Owner: Yue She <yue...@google.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-Attention: Yue She <yue...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages