Android: disable enable_code_ordering=false for is_component_build=false [chromium/src : main]
0 views
Skip to first unread message
Andrew Grieve (Gerrit)
Jan 27, 2026, 6:15:06 PM (11 days ago) Jan 27
to Andrew Grieve, Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Kartar Singh
Andrew Grieve voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Kartar Singh
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kartar Singh (Gerrit)
Jan 28, 2026, 6:00:17 AM (10 days ago) Jan 28
to Andrew Grieve, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Andrew Grieve
Kartar Singh added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
Line 32, Patchset 1 (Latest):
#if BUILDFLAG(SUPPORTS_CODE_ORDERING)Kartar Singh . unresolved
Just wondering if lack of code ordering support actually implies no support for unwinding? Or is it being used as a proxy for something else?
Related details
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Seckler (Gerrit)
Jan 28, 2026, 9:44:04 AM (10 days ago) Jan 28
to Andrew Grieve, Kartar Singh, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Andrew Grieve and Kartar Singh
Eric Seckler voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eric Seckler
| Code-Review | +1 |
1 comment
Patchset-level comments
Eric Seckler
Not too familiar with all the unwinding edge cases. I believe we don't require unwinding support in component builds (we mainly care about this working in release builds) -- so this is likely fine?
Related details
Attention is currently required from:
- Andrew Grieve
- Kartar Singh
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kartar Singh (Gerrit)
Jan 28, 2026, 9:55:56 AM (10 days ago) Jan 28
to Andrew Grieve, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Andrew Grieve
Kartar Singh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kartar Singh
| Code-Review | +1 |
1 comment
Patchset-level comments
Kartar Singh . resolved
Eric Seckler\+cc @esec...@chromium.org, since you might know the code a bit more :)
Not too familiar with all the unwinding edge cases. I believe we don't require unwinding support in component builds (we mainly care about this working in release builds) -- so this is likely fine?
Kartar Singh
Makes sense, I am not too sure either whether it currently works in component builds or not.
Related details
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
Jan 28, 2026, 9:56:52 AM (10 days ago) Jan 28
to Andrew Grieve, Kartar Singh, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Andrew Grieve voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrew Grieve
| Commit-Queue | +2 |
1 comment
File services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
Line 32, Patchset 1 (Latest):
#if BUILDFLAG(SUPPORTS_CODE_ORDERING)Kartar Singh . resolved
Just wondering if lack of code ordering support actually implies no support for unwinding? Or is it being used as a proxy for something else?
Andrew Grieve
Looking at what depends on code ordering, it's just `is_chrome_module()` part. I don't think the unwinding depends on it.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 28, 2026, 9:59:34 AM (10 days ago) Jan 28
to Andrew Grieve, Kartar Singh, Eric Seckler, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Android: disable enable_code_ordering=false for is_component_build=false
It doesn't make sense for component builds.
My actual motivation is that I'd like to explore using mold/wild for
debug Android builds, and they don't support the associated linker
script.
Bug: 40208899
Change-Id: I1e7246eebfc3e1cd9408dcece50a0aaf64e846d1
Auto-Submit: Andrew Grieve <agr...@chromium.org>
Reviewed-by: Kartar Singh <karta...@google.com>
Reviewed-by: Eric Seckler <esec...@chromium.org>
Commit-Queue: Andrew Grieve <agr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1575911}
Files:
- M base/BUILD.gn
- M services/tracing/public/cpp/stack_sampling/tracing_sampler_profiler.h
Change size: S
Delta: 2 files changed, 13 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kartar Singh, +1 by Eric Seckler
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages