Remove superfluous sequence_bound.h includes from headers [chromium/src : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Dec 11, 2025, 12:05:26 AM (10 days ago) Dec 11
to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, Hiroki Nakagawa, Chromium LUCI CQ, alexmo...@chromium.org, blink-work...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, creis...@chromium.org, cros-enterpris...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng

Lei Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I49dff2ddc2acc3821268dabdccd62b88737f5509
Gerrit-Change-Number: 7249588
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 05:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Dec 11, 2025, 12:08:47 AM (10 days ago) Dec 11
to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, Hiroki Nakagawa, Chromium LUCI CQ, alexmo...@chromium.org, blink-work...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, creis...@chromium.org, cros-enterpris...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Lei Zhang

Daniel Cheng voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I49dff2ddc2acc3821268dabdccd62b88737f5509
Gerrit-Change-Number: 7249588
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 05:08:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 11, 2025, 12:25:50 AM (10 days ago) Dec 11
to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, Hiroki Nakagawa, Chromium LUCI CQ, alexmo...@chromium.org, blink-work...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, creis...@chromium.org, cros-enterpris...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I49dff2ddc2acc3821268dabdccd62b88737f5509
Gerrit-Change-Number: 7249588
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 05:25:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 11, 2025, 12:28:51 AM (10 days ago) Dec 11
to Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, Hiroki Nakagawa, alexmo...@chromium.org, blink-work...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-gfx-...@google.com, creis...@chromium.org, cros-enterpris...@chromium.org, dmurph+wa...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com, eme-r...@chromium.org, enne...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove superfluous sequence_bound.h includes from headers

Since sequence_bound.h only provides base::SequenceBound, it is easy to
automate this cleanup:

git grep -l 'base/threading/sequence_bound.h"$' | grep '\.h$' | \
  xargs grep -L SequenceBound | xargs tools/add_header.py --remove \
    --header '"base/threading/sequence_bound.h"'

Then do IWYU to fix the build.
Bug: 40318405
Change-Id: I49dff2ddc2acc3821268dabdccd62b88737f5509
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1557123}
Files:
  • M chrome/browser/ash/file_system_provider/content_cache/content_cache_impl.h
  • M chrome/browser/net/profile_network_context_service.h
  • M chrome/updater/event_logger.h
  • M components/power_bookmarks/core/power_bookmark_service.h
  • M components/services/storage/dom_storage/leveldb/dom_storage_database_leveldb.h
  • M components/services/storage/shared_storage/async_shared_storage_database.h
  • M content/browser/cache_storage/cache_storage_context_impl.h
  • M content/browser/dom_storage/dom_storage_context_wrapper.h
  • M content/browser/file_system_access/file_system_access_bucket_path_watcher.h
  • M content/browser/indexed_db/indexed_db_control_wrapper.h
  • M content/browser/interest_group/interest_group_manager_impl.h
  • M content/browser/media/cdm_file_impl.h
  • M content/browser/service_worker/service_worker_registry.h
  • M content/browser/tracing/background_tracing_manager_impl.h
  • M content/renderer/local_resource_url_loader_factory.h
  • M content/renderer/render_frame_impl.h
  • M media/filters/manifest_demuxer.h
  • M media/gpu/windows/d3d11_video_decoder.h
  • M services/on_device_model/on_device_model_service.h
Change size: S
Delta: 19 files changed, 2 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I49dff2ddc2acc3821268dabdccd62b88737f5509
Gerrit-Change-Number: 7249588
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages